Re: nodejs packages should be fixed to use more system libraries

[digitalagedragon <digitalagedragon@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

New comment by digitalagedragon on void-packages repository

https://github.com/void-linux/void-packages/issues/29034#issuecomment-826402170

Comment:
```diff
diff --git a/srcpkgs/nodejs-lts-10/patches/ppc32.patch b/srcpkgs/nodejs-lts-10/patches/ppc32.patch
index 343eff5851..da8b6b7c7c 100644
--- a/srcpkgs/nodejs-lts-10/patches/ppc32.patch
+++ b/srcpkgs/nodejs-lts-10/patches/ppc32.patch
@@ -15,7 +15,7 @@
        'msvs_disabled_warnings!': [4244],

        'conditions': [
-+        [ 'host_arch=="mips" or host_arch=="mipsel" or host_arch=="ppc"', {
++        [ 'target_arch=="mips" or target_arch=="mipsel" or target_arch=="ppc" or target_arch=="arm"', {
 +        'link_settings': {
 +          'libraries': [ '-latomic' ],
 +        },
diff --git a/srcpkgs/nodejs-lts-10/template b/srcpkgs/nodejs-lts-10/template
index 3944d359c6..a680db30cc 100644
--- a/srcpkgs/nodejs-lts-10/template
+++ b/srcpkgs/nodejs-lts-10/template
@@ -37,9 +37,7 @@ if [ "$XBPS_WORDSIZE" -ne "$XBPS_TARGET_WORDSIZE" ]; then
        nocross="host and target must have the same pointer size"
 fi

-if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
-       makedepends+=" libatomic-devel"
-fi
+makedepends+=" libatomic-devel"
 if [ "$XBPS_NO_ATOMIC8" ]; then
        hostmakedepends+=" libatomic-devel"
 fi
```

Well this seems to work, at least - compiles on armv6l and armv7l, `node` pulls in `libatomic` on armv6l and doesn't on armv7l. I'd rather be able to pass `$XBPS_TARGET_NO_ATOMIC8` off to the build system directly but (granted, with 5 minutes of looking) there doesn't appear to be a good way to do that.