From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
Date: Wed, 28 Apr 2021 21:02:01 +0200 [thread overview]
Message-ID: <20210428190201.pLV9IlqzNTHyJmrjtlkC6Z1I1kA-hcP0x53TB0Y1w7s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30552@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/30552#discussion_r622457681
Comment:
I don't think the manual should call out poetry-core here. It is not the only PEP-517 builder and doesn't deserve special mention, especially because nothing in the repository currently uses it. To be somewhat generic, I'd recommend dropping this paragraph and adding a sentence at the end of the first paragraph (Line 1534) along the lines of
The `python3-pep517` build style does not depend on a specific build backend, so packages will need to add an appropriate backend provider to `hostmakedepends`.
I don't think the dependency mapping content is important here; discussion of the `setuptools` mapping was included because `setuptools` has a nasty tendency of fetching and locally installing everything needed to build a package. For the `pep517` build style, we explicitly disable fetching to force hard errors when dependencies are improperly specified.
next prev parent reply other threads:[~2021-04-28 19:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 19:56 [PR PATCH] " kwshi
2021-04-27 20:00 ` [PR REVIEW] " ericonr
2021-04-27 20:02 ` [PR PATCH] [Updated] " kwshi
2021-04-27 20:06 ` kwshi
2021-04-27 20:07 ` [PR PATCH] [Updated] " kwshi
2021-04-27 20:20 ` kwshi
2021-04-27 20:33 ` [PR PATCH] [Updated] " kwshi
2021-04-28 19:02 ` [PR REVIEW] " ahesford
2021-04-28 19:02 ` ahesford [this message]
2021-04-28 19:13 ` [PR PATCH] [Updated] " kwshi
2021-04-28 19:13 ` [PR REVIEW] " kwshi
2021-04-28 19:14 ` kwshi
2021-04-28 19:14 ` kwshi
2021-04-28 19:18 ` kwshi
2021-04-28 19:27 ` eli-schwartz
2021-04-28 20:06 ` [PR PATCH] [Updated] " kwshi
2021-04-28 20:07 ` kwshi
2021-04-30 20:10 ` kwshi
2021-05-19 3:02 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428190201.pLV9IlqzNTHyJmrjtlkC6Z1I1kA-hcP0x53TB0Y1w7s@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).