Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: python3-poetry-core-1.0.3
@ 2021-04-27 19:56 kwshi
  2021-04-27 20:00 ` [PR REVIEW] " ericonr
                   ` (17 more replies)
  0 siblings, 18 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 19:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is a new pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2636 bytes --]

From bd1a966fb76c7999979de96bc915fb53d0ed12d6 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..0366110f4cc0
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-pep517"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="https://github.com/python-poetry/poetry-core/archive/refs/tags/${version}.tar.gz"
+checksum="b5a9f8284c685c638796a322ea868843da5e2094c664436e44061e6bcea367ea"
+
+post_install() {
+	vlicense LICENSE
+}

From 515b5df655bb14c4e23791368a9e03fd06e10f12 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for Poetry-built Python
 packages

---
 Manual.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..d90158a4394d 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1533,7 +1533,11 @@ The `python3-pep517` build style provides means to build python packages that pr
 definition compliant with [PEP 517](https://www.python.org/dev/peps/pep-0517/) without a traditional
 `setup.py` script.
 
-Python packages that rely on `python3-setuptools` should generally map `setup_requires`
+Python packages that use [Poetry](https://github.com/python-poetry/poetry-core)
+as a build backend should specify the `python3-pep517` build style, add
+`python3-poetry-core` to `hostmakedepends` and approximately map
+`tool.poetry.dependencies` entries in `pyproject.toml` to `depends` in the
+template.  Python packages that rely on `python3-setuptools` should generally map `setup_requires`
 dependencies in `setup.py` to `hostmakedepends` in the template and `install_requires`
 dependencies to `depends` in the template; include `python3` in `depends` if there are no other
 python dependencies. If the package includes a compiled extension, the `python3-devel` packages

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
@ 2021-04-27 20:00 ` ericonr
  2021-04-27 20:02 ` [PR PATCH] [Updated] " kwshi
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ericonr @ 2021-04-27 20:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r621558299

Comment:
I think the poetry stuff, being new and less used (at least for now), should go below the `setuptools` instructions.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
  2021-04-27 20:00 ` [PR REVIEW] " ericonr
@ 2021-04-27 20:02 ` kwshi
  2021-04-27 20:06 ` kwshi
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 20:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From cf6fc312516efad2b1424d8aade7145ff1327ee5 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core-1.0.3

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..0366110f4cc0
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-pep517"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="https://github.com/python-poetry/poetry-core/archive/refs/tags/${version}.tar.gz"
+checksum="b5a9f8284c685c638796a322ea868843da5e2094c664436e44061e6bcea367ea"
+
+post_install() {
+	vlicense LICENSE
+}

From b6be09c09193f21c6b7866bd008de3826cfad055 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for Poetry-built Python
 packages

---
 Manual.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..d90158a4394d 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1533,7 +1533,11 @@ The `python3-pep517` build style provides means to build python packages that pr
 definition compliant with [PEP 517](https://www.python.org/dev/peps/pep-0517/) without a traditional
 `setup.py` script.
 
-Python packages that rely on `python3-setuptools` should generally map `setup_requires`
+Python packages that use [Poetry](https://github.com/python-poetry/poetry-core)
+as a build backend should specify the `python3-pep517` build style, add
+`python3-poetry-core` to `hostmakedepends` and approximately map
+`tool.poetry.dependencies` entries in `pyproject.toml` to `depends` in the
+template.  Python packages that rely on `python3-setuptools` should generally map `setup_requires`
 dependencies in `setup.py` to `hostmakedepends` in the template and `install_requires`
 dependencies to `depends` in the template; include `python3` in `depends` if there are no other
 python dependencies. If the package includes a compiled extension, the `python3-devel` packages

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
  2021-04-27 20:00 ` [PR REVIEW] " ericonr
  2021-04-27 20:02 ` [PR PATCH] [Updated] " kwshi
@ 2021-04-27 20:06 ` kwshi
  2021-04-27 20:07 ` [PR PATCH] [Updated] " kwshi
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 20:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-827894652

Comment:
Resolves. #30551

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (2 preceding siblings ...)
  2021-04-27 20:06 ` kwshi
@ 2021-04-27 20:07 ` kwshi
  2021-04-27 20:20 ` kwshi
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 20:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From cf6fc312516efad2b1424d8aade7145ff1327ee5 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core-1.0.3

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..0366110f4cc0
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-pep517"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="https://github.com/python-poetry/poetry-core/archive/refs/tags/${version}.tar.gz"
+checksum="b5a9f8284c685c638796a322ea868843da5e2094c664436e44061e6bcea367ea"
+
+post_install() {
+	vlicense LICENSE
+}

From e988cbdea8336acb347d9963ae3c84c5a2af3c75 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for Poetry-built Python
 packages

---
 Manual.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..d90158a4394d 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1533,7 +1533,11 @@ The `python3-pep517` build style provides means to build python packages that pr
 definition compliant with [PEP 517](https://www.python.org/dev/peps/pep-0517/) without a traditional
 `setup.py` script.
 
-Python packages that rely on `python3-setuptools` should generally map `setup_requires`
+Python packages that use [Poetry](https://github.com/python-poetry/poetry-core)
+as a build backend should specify the `python3-pep517` build style, add
+`python3-poetry-core` to `hostmakedepends` and approximately map
+`tool.poetry.dependencies` entries in `pyproject.toml` to `depends` in the
+template.  Python packages that rely on `python3-setuptools` should generally map `setup_requires`
 dependencies in `setup.py` to `hostmakedepends` in the template and `install_requires`
 dependencies to `depends` in the template; include `python3` in `depends` if there are no other
 python dependencies. If the package includes a compiled extension, the `python3-devel` packages

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (3 preceding siblings ...)
  2021-04-27 20:07 ` [PR PATCH] [Updated] " kwshi
@ 2021-04-27 20:20 ` kwshi
  2021-04-27 20:33 ` [PR PATCH] [Updated] " kwshi
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 20:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-827894652

Comment:
Resolves #30551

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (4 preceding siblings ...)
  2021-04-27 20:20 ` kwshi
@ 2021-04-27 20:33 ` kwshi
  2021-04-28 19:02 ` [PR REVIEW] " ahesford
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-27 20:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2277 bytes --]

From cf6fc312516efad2b1424d8aade7145ff1327ee5 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core-1.0.3

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..0366110f4cc0
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-pep517"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="https://github.com/python-poetry/poetry-core/archive/refs/tags/${version}.tar.gz"
+checksum="b5a9f8284c685c638796a322ea868843da5e2094c664436e44061e6bcea367ea"
+
+post_install() {
+	vlicense LICENSE
+}

From 9f9540de3b05e27e4684302490ba9b4229c86e51 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for Poetry-built Python
 packages

---
 Manual.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..bf515d5185e9 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1546,6 +1546,12 @@ dependencies at build time. If you notice warnings about `EasyInstall` deprecati
 present in `${wrksrc}/.eggs` after building the package, then those packages should be added to
 `hostmakedepends`.
 
+Python packages that use [Poetry](https://github.com/python-poetry/poetry-core)
+as a build backend should specify the `python3-pep517` build style, add
+`python3-poetry-core` to `hostmakedepends` and approximately map
+`tool.poetry.dependencies` entries in `pyproject.toml` to `depends` in the
+template.
+
 The following variables may influence how the python packages are built and configured
 at post-install time:
 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (5 preceding siblings ...)
  2021-04-27 20:33 ` [PR PATCH] [Updated] " kwshi
@ 2021-04-28 19:02 ` ahesford
  2021-04-28 19:02 ` ahesford
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ahesford @ 2021-04-28 19:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r622458509

Comment:
For Python distfiles, we generally prefer `${PYPI_SITE}` to source repos.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (6 preceding siblings ...)
  2021-04-28 19:02 ` [PR REVIEW] " ahesford
@ 2021-04-28 19:02 ` ahesford
  2021-04-28 19:13 ` [PR PATCH] [Updated] " kwshi
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: ahesford @ 2021-04-28 19:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r622457681

Comment:
I don't think the manual should call out poetry-core here. It is not the only PEP-517 builder and doesn't deserve special mention, especially because nothing in the repository currently uses it. To be somewhat generic, I'd recommend dropping this paragraph and adding a sentence at the end of the first paragraph (Line 1534) along the lines of

    The `python3-pep517` build style does not depend on a specific build backend, so packages will need to add an appropriate backend provider to `hostmakedepends`.

I don't think the dependency mapping content is important here; discussion of the `setuptools` mapping was included because `setuptools` has a nasty tendency of fetching and locally installing everything needed to build a package. For the `pep517` build style, we explicitly disable fetching to force hard errors when dependencies are improperly specified.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (7 preceding siblings ...)
  2021-04-28 19:02 ` ahesford
@ 2021-04-28 19:13 ` kwshi
  2021-04-28 19:13 ` [PR REVIEW] " kwshi
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2112 bytes --]

From bbdc83de0039a136abf1ed348087f4d1e700b705 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core-1.0.3

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..de1b1af0df62
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-pep517"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="${PYPI_SITE}/p/poetry-core/poetry-core-${version}.tar.gz"
+checksum="2315c928249fc3207801a81868b64c66273077b26c8d8da465dccf8f488c90c5"
+
+post_install() {
+	vlicense LICENSE
+}

From 6d524b606e58ef455ce812eb0a9cad6c78424dfa Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for PEP 517 Python package
 build backends

---
 Manual.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..851e4be41bfc 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1546,6 +1546,9 @@ dependencies at build time. If you notice warnings about `EasyInstall` deprecati
 present in `${wrksrc}/.eggs` after building the package, then those packages should be added to
 `hostmakedepends`.
 
+The `python3-pep517` build style does not provide a specific build backend, so
+packages will need to add an appropriate backend provider to `hostmakedepends`.
+
 The following variables may influence how the python packages are built and configured
 at post-install time:
 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (8 preceding siblings ...)
  2021-04-28 19:13 ` [PR PATCH] [Updated] " kwshi
@ 2021-04-28 19:13 ` kwshi
  2021-04-28 19:14 ` kwshi
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r622466434

Comment:
Makes sense--fixed in 6d524b.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (9 preceding siblings ...)
  2021-04-28 19:13 ` [PR REVIEW] " kwshi
@ 2021-04-28 19:14 ` kwshi
  2021-04-28 19:14 ` kwshi
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 19:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r622466434

Comment:
Makes sense--fixed in 6d524b6.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (10 preceding siblings ...)
  2021-04-28 19:14 ` kwshi
@ 2021-04-28 19:14 ` kwshi
  2021-04-28 19:18 ` kwshi
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 19:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#discussion_r622466704

Comment:
Fixed in bbdc83d.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (11 preceding siblings ...)
  2021-04-28 19:14 ` kwshi
@ 2021-04-28 19:18 ` kwshi
  2021-04-28 19:27 ` eli-schwartz
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 19:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-828715141

Comment:
@eli-schwartz has pointed out on #30551 that `python3-pep517` packages are currently using pip, which may exhibit undesirable behavior.  Currently, in this PR I've configured the package (`python3-poetry-core`) to build itself using PEP517, but should I switch to making it use the sdist `setup.py` from the PyPI tarball instead?

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (12 preceding siblings ...)
  2021-04-28 19:18 ` kwshi
@ 2021-04-28 19:27 ` eli-schwartz
  2021-04-28 20:06 ` [PR PATCH] [Updated] " kwshi
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: eli-schwartz @ 2021-04-28 19:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

New comment by eli-schwartz on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-828720146

Comment:
Using the setup.py has consistent semantics in line with all other python ecosystem packages and additionally reduces the bootstrap graph a bit (maybe a lot, if void were to properly devendor pip/setuptools to use system dependencies).

And the pep517 build style is not commonly used -- in fact my understanding is it was added as a precautionary measure in case it became impossible to continue maintaining existing packages without it.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (13 preceding siblings ...)
  2021-04-28 19:27 ` eli-schwartz
@ 2021-04-28 20:06 ` kwshi
  2021-04-28 20:07 ` kwshi
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 20:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages poetry-core
https://github.com/void-linux/void-packages/pull/30552

New package: python3-poetry-core-1.0.3
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-poetry-core-30552.patch --]
[-- Type: text/x-diff, Size: 2112 bytes --]

From 3c177c05d18a8b34a32f8141cb7646bc96853265 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:11:03 -0700
Subject: [PATCH 1/2] New package: python3-poetry-core-1.0.3

---
 srcpkgs/python3-poetry-core/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-poetry-core/template

diff --git a/srcpkgs/python3-poetry-core/template b/srcpkgs/python3-poetry-core/template
new file mode 100644
index 000000000000..6d4a7c507c90
--- /dev/null
+++ b/srcpkgs/python3-poetry-core/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-poetry-core'
+pkgname=python3-poetry-core
+version=1.0.3
+revision=1
+wrksrc="poetry-core-${version}"
+build_style="python3-module"
+make_install_target="poetry_core-${version}-*-*-*.whl"
+hostmakedepends="python3-wheel"
+depends="python3"
+short_desc="Poetry PEP 517 Build Backend & Core Utilities"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/python-poetry/poetry-core"
+distfiles="${PYPI_SITE}/p/poetry-core/poetry-core-${version}.tar.gz"
+checksum="2315c928249fc3207801a81868b64c66273077b26c8d8da465dccf8f488c90c5"
+
+post_install() {
+	vlicense LICENSE
+}

From 665c078ef67a465024b821bb6936314c9c87ca93 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Tue, 27 Apr 2021 12:50:44 -0700
Subject: [PATCH 2/2] Manual.md: add instructions for PEP 517 Python package
 build backends

---
 Manual.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Manual.md b/Manual.md
index 73cd9088f9bc..851e4be41bfc 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1546,6 +1546,9 @@ dependencies at build time. If you notice warnings about `EasyInstall` deprecati
 present in `${wrksrc}/.eggs` after building the package, then those packages should be added to
 `hostmakedepends`.
 
+The `python3-pep517` build style does not provide a specific build backend, so
+packages will need to add an appropriate backend provider to `hostmakedepends`.
+
 The following variables may influence how the python packages are built and configured
 at post-install time:
 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (14 preceding siblings ...)
  2021-04-28 20:06 ` [PR PATCH] [Updated] " kwshi
@ 2021-04-28 20:07 ` kwshi
  2021-04-30 20:10 ` kwshi
  2021-05-19  3:02 ` [PR PATCH] [Closed]: " ahesford
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-28 20:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-828743110

Comment:
Alright!  I have rewritten the template to build using `python3-module` instead of `python3-pep517` now.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (15 preceding siblings ...)
  2021-04-28 20:07 ` kwshi
@ 2021-04-30 20:10 ` kwshi
  2021-05-19  3:02 ` [PR PATCH] [Closed]: " ahesford
  17 siblings, 0 replies; 19+ messages in thread
From: kwshi @ 2021-04-30 20:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

New comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30552#issuecomment-830353727

Comment:
Since it looks like poetry-core might be pushing a new release soon, and there's a decent chance (fingers crossed!) it'll include tests in its sdist (see https://github.com/python-poetry/poetry-core/pull/173), perhaps we'll wait a couple days & I can update this to the newest release before merging!  :)

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Closed]: New package: python3-poetry-core-1.0.3
  2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
                   ` (16 preceding siblings ...)
  2021-04-30 20:10 ` kwshi
@ 2021-05-19  3:02 ` ahesford
  17 siblings, 0 replies; 19+ messages in thread
From: ahesford @ 2021-05-19  3:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

There's a closed pull request on the void-packages repository

New package: python3-poetry-core-1.0.3
https://github.com/void-linux/void-packages/pull/30552

Description:
- New package: python3-poetry-core
- Manual.md: add instructions for Poetry-built Python packages

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2021-05-19  3:02 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 19:56 [PR PATCH] New package: python3-poetry-core-1.0.3 kwshi
2021-04-27 20:00 ` [PR REVIEW] " ericonr
2021-04-27 20:02 ` [PR PATCH] [Updated] " kwshi
2021-04-27 20:06 ` kwshi
2021-04-27 20:07 ` [PR PATCH] [Updated] " kwshi
2021-04-27 20:20 ` kwshi
2021-04-27 20:33 ` [PR PATCH] [Updated] " kwshi
2021-04-28 19:02 ` [PR REVIEW] " ahesford
2021-04-28 19:02 ` ahesford
2021-04-28 19:13 ` [PR PATCH] [Updated] " kwshi
2021-04-28 19:13 ` [PR REVIEW] " kwshi
2021-04-28 19:14 ` kwshi
2021-04-28 19:14 ` kwshi
2021-04-28 19:18 ` kwshi
2021-04-28 19:27 ` eli-schwartz
2021-04-28 20:06 ` [PR PATCH] [Updated] " kwshi
2021-04-28 20:07 ` kwshi
2021-04-30 20:10 ` kwshi
2021-05-19  3:02 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).