[PR PATCH] jack: update to 1.9.17.

[PR PATCH] jack: update to 1.9.17.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

There is a new pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages jack
https://github.com/void-linux/void-packages/pull/28565

jack: update to 1.9.17.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28565.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jack-28565.patch --]
[-- Type: text/x-diff, Size: 1383 bytes --]

From cf6cda3f2e375890e4a4a62773c451d807d2189f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sun, 7 Feb 2021 13:47:31 +0100
Subject: [PATCH] jack: update to 1.9.17.

---
 srcpkgs/jack/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jack/template b/srcpkgs/jack/template
index 2358f9edc31..579590938d4 100644
--- a/srcpkgs/jack/template
+++ b/srcpkgs/jack/template
@@ -1,6 +1,6 @@
 # Template file for 'jack'
 pkgname=jack
-version=1.9.16
+version=1.9.17
 revision=1
 wrksrc="jack2-${version}"
 build_style=waf3
@@ -14,14 +14,14 @@ maintainer="Daniel Eyßer <daniel.eysser@gmail.com>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="https://jackaudio.org/"
 distfiles="https://github.com/jackaudio/jack2/archive/v${version}.tar.gz"
-checksum=e176d04de94dcaa3f9d32ca1825091e1b938783a78c84e7466abd06af7637d37
+checksum=38f674bbc57852a8eb3d9faa1f96a0912d26f7d5df14c11005ad499c8ae352f2
 python_version=3
 
 # Package build options
 build_options="ffado"
 desc_option_ffado="Enable support for FireWire audio devices"
 
-if [ -z "CROSS_BUILD" ]; then
+if [ -z "$CROSS_BUILD" ]; then
 	makedepends+=" eigen"
 fi
 
@@ -39,6 +39,7 @@ libjack_package() {
 		vmove usr/lib/jack
 	}
 }
+
 jack-devel_package() {
 	depends="libjack>=${version}_${revision}"
 	short_desc+=" - development files"

Re: jack: update to 1.9.17.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28565#issuecomment-776181578

Comment:
Do you know why eigen was disabled for cross builds? Testing locally, it is detected during configure and it builds. Maybe we could just enable for all of them (and mention it in the commit message, of course).

Re: jack: update to 1.9.17.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28565#issuecomment-776182521

Comment:
@pullmoll do you remember why it was initially disabled in e2b7963568c666e45233f48302484ad22aac0c7e ?

Re: jack: update to 1.9.17.

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/28565#issuecomment-828246547

Comment:
@daniel-eys Ping : bump release 1.9.18

Re: [PR PATCH] [Updated] jack: update to 1.9.17.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

There is an updated pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages jack
https://github.com/void-linux/void-packages/pull/28565

jack: update to 1.9.17.
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28565.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jack-28565.patch --]
[-- Type: text/x-diff, Size: 2052 bytes --]

From 72b087620a35dd7229f6bf7630080c52fd2caa28 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sun, 7 Feb 2021 13:47:31 +0100
Subject: [PATCH] jack: update to 1.9.18.

Also add eigen back to makedepends as cross-builds seem to be fine.
---
 srcpkgs/jack/template | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/jack/template b/srcpkgs/jack/template
index 2358f9edc310..092d7292d343 100644
--- a/srcpkgs/jack/template
+++ b/srcpkgs/jack/template
@@ -1,29 +1,27 @@
 # Template file for 'jack'
 pkgname=jack
-version=1.9.16
+version=1.9.18
 revision=1
 wrksrc="jack2-${version}"
 build_style=waf3
 configure_args="--alsa --classic --dbus"
 hostmakedepends="pkg-config"
-makedepends="opus-devel libsamplerate-devel readline-devel
- dbus-devel db-devel celt-devel $(vopt_if ffado libffado-devel)"
+makedepends="eigen opus-devel libsamplerate-devel readline-devel
+ dbus-devel db-devel celt-devel $(vopt_if ffado libffado-devel)
+ $(vopt_if zalsa 'zita-alsa-pcmi-devel zita-resampler-devel')"
 depends="python3-dbus"
 short_desc="JACK Audio Connection Kit low-latency sound server (pro audio)"
 maintainer="Daniel Eyßer <daniel.eysser@gmail.com>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="https://jackaudio.org/"
 distfiles="https://github.com/jackaudio/jack2/archive/v${version}.tar.gz"
-checksum=e176d04de94dcaa3f9d32ca1825091e1b938783a78c84e7466abd06af7637d37
+checksum=5a1d64118034d58529d68a9af42710f9d4843536257c496118065ea3d3e4ae2c
 python_version=3
 
 # Package build options
-build_options="ffado"
+build_options="ffado zalsa"
 desc_option_ffado="Enable support for FireWire audio devices"
-
-if [ -z "CROSS_BUILD" ]; then
-	makedepends+=" eigen"
-fi
+desc_option_zalsa="Enable support for internal zita-a2j/j2a clients"
 
 post_install() {
 	# pam_limits(8) support
@@ -39,6 +37,7 @@ libjack_package() {
 		vmove usr/lib/jack
 	}
 }
+
 jack-devel_package() {
 	depends="libjack>=${version}_${revision}"
 	short_desc+=" - development files"

Re: jack: update to 1.9.17.

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/28565#issuecomment-828700814

Comment:
Updated to 1.9.18 and also added the `zalsa` buildoption which has been introduced with jack 1.9.18.
I also re-added `eigen` to `makedepends` as cross-builds seem to be fine with that.

Re: [PR PATCH] [Merged]: jack: update to 1.9.17.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

There's a merged pull request on the void-packages repository

jack: update to 1.9.17.
https://github.com/void-linux/void-packages/pull/28565

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->