Github messages for voidlinux
 help / color / mirror / Atom feed
From: loreb <loreb@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: please update recutils - I know there's a script for that, in this case it didn't work
Date: Wed, 28 Apr 2021 23:40:22 +0200	[thread overview]
Message-ID: <20210428214022.S_uuq9CNB5wEbIHZjcF0uaoch9NWsfCD64gglo-CGYg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30546@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/issues/30546#issuecomment-828798182

Comment:
Basically if I were in your shoes (assuming you'll be reviewing it) I would grab the gnulib files mentioned in the patch,
check that the patch creates those EXACTLY, and then look at the rest which is thankfully small enough that you
can look at it and either trust it or criticize it in a reasonable amount of time.

Touching the manpage is a trick because they are automatically generated, and it will have to go away;
`xbps-query -Rvs help2man` showed nothing, that's why I did it.

Now that I think about it I should have added in the template something like
```
if test x"$version.$revision" != 1.8.2
 echo remove that automake crap and do not touch the manpages
 exit 1
fi
```


  parent reply	other threads:[~2021-04-28 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 12:09 [ISSUE] " loreb
2021-04-27 12:32 ` paper42
2021-04-27 14:29 ` loreb
2021-04-27 22:10 ` ericonr
2021-04-28 12:19 ` loreb
2021-04-28 12:56 ` loreb
2021-04-28 13:04 ` ericonr
2021-04-28 14:41 ` loreb
2021-04-28 15:08 ` ericonr
2021-04-28 16:00 ` loreb
2021-04-28 16:18 ` ericonr
2021-04-28 21:26 ` loreb
2021-04-28 21:28 ` ericonr
2021-04-28 21:34 ` loreb
2021-04-28 21:40 ` loreb [this message]
2022-05-18  2:09 ` github-actions
2022-05-21 18:40 ` [ISSUE] [CLOSED] " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428214022.S_uuq9CNB5wEbIHZjcF0uaoch9NWsfCD64gglo-CGYg@z \
    --to=loreb@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).