Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Update template
@ 2021-04-28 22:08 grim-cypher
  2021-04-28 22:52 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: grim-cypher @ 2021-04-28 22:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

There is a new pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 1102 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
@ 2021-04-28 22:52 ` ericonr
  2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-04-28 22:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-828832311

Comment:
Please use the correct commit message `gradle: update to 7.0`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
  2021-04-28 22:52 ` ericonr
@ 2021-04-28 23:08 ` grim-cypher
  2021-04-29  0:25 ` grim-cypher
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: grim-cypher @ 2021-04-28 23:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an updated pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 2280 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH 1/2] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

From 395d272d0e486e771fd3a9c9f2c22b90977d7bb6 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 04:38:23 +0530
Subject: [PATCH 2/2] Update template

---
 srcpkgs/gradle/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 88dab9e9d732..ca05694dac2f 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -9,12 +9,12 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
+checksum="https://services.gradle.org/distributions/gradle-${version}-bin.zip.sha256"
+
 
 do_install() {
-	vmkdir "usr/lib/gradle"
-	sed ${FILESDIR}/gradle -e "s;@VERSION@;${version};" > gradle
-	vbin gradle
-	vdoc README
-	mv lib ${DESTDIR}/usr/lib/gradle/
+	wget ${distfiles}
+	mkdir /opt/gradle
+	unzip -d /opt/gradle gradle-${version}-bin.zip
+	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
  2021-04-28 22:52 ` ericonr
  2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
@ 2021-04-29  0:25 ` grim-cypher
  2021-04-29  0:40 ` FollieHiyuki
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: grim-cypher @ 2021-04-29  0:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an updated pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 2996 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH 1/3] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

From 395d272d0e486e771fd3a9c9f2c22b90977d7bb6 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 04:38:23 +0530
Subject: [PATCH 2/3] Update template

---
 srcpkgs/gradle/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 88dab9e9d732..ca05694dac2f 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -9,12 +9,12 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
+checksum="https://services.gradle.org/distributions/gradle-${version}-bin.zip.sha256"
+
 
 do_install() {
-	vmkdir "usr/lib/gradle"
-	sed ${FILESDIR}/gradle -e "s;@VERSION@;${version};" > gradle
-	vbin gradle
-	vdoc README
-	mv lib ${DESTDIR}/usr/lib/gradle/
+	wget ${distfiles}
+	mkdir /opt/gradle
+	unzip -d /opt/gradle gradle-${version}-bin.zip
+	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
 }

From ea2e01deab46a64663efb2e4ae657eff70742634 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 05:55:20 +0530
Subject: [PATCH 3/3] Update template

---
 srcpkgs/gradle/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index ca05694dac2f..d43fa54eeccd 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -16,5 +16,6 @@ do_install() {
 	wget ${distfiles}
 	mkdir /opt/gradle
 	unzip -d /opt/gradle gradle-${version}-bin.zip
-	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
+	ln /opt/gradle/gradle-${version}/bin/gradle /usr/bin/gradle
 }
+do_install

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (2 preceding siblings ...)
  2021-04-29  0:25 ` grim-cypher
@ 2021-04-29  0:40 ` FollieHiyuki
  2021-04-29 14:46 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: FollieHiyuki @ 2021-04-29  0:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-828870056

Comment:
Please squash all your commits into 1 with message `gradle: update to 7.0`.

And don't do all the `wget` and `unzip` ... inside the template, `xbps-src` will handle that. This is not really an installer script either so drop the last line with `do_install` call as well.

Anyways you can always re-read the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) and checkout templates for other packages to know how to properly write a template.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (3 preceding siblings ...)
  2021-04-29  0:40 ` FollieHiyuki
@ 2021-04-29 14:46 ` ericonr
  2021-05-17  3:57 ` ericonr
  2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
  6 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-04-29 14:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-829300746

Comment:
I believe there is a misunderstanding here... A template isn't a script that installs a given piece of software on your system, it's instead supposed to be used to create a package (a compressed tarball), which is what the package manager (xbps) will use to install the software. The template did this correctly, but your changes seem to be moving in the direction of making it a script. If you look at the README, you will see that templates aren't supposed to be run directly, but instead that you're supposed to run `./xbps-src pkg gradle` and this will create a gradle package inside `hostdir/binpkgs/` which you can install using `xi gradle` (`xi` being a script from the `xtools` package).

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (5 preceding siblings ...)
  2021-05-17  3:57 ` ericonr
@ 2021-05-17  3:57 ` ericonr
  6 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-05-17  3:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

There's a closed pull request on the void-packages repository

Update template
https://github.com/void-linux/void-packages/pull/30568

Description:
updating to the new version of gradle 7.0



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (4 preceding siblings ...)
  2021-04-29 14:46 ` ericonr
@ 2021-05-17  3:57 ` ericonr
  2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
  6 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2021-05-17  3:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-841965575

Comment:
Closing due to inactivity. Feel free to reopen!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] Update template
  2021-05-04 19:00 [PR PATCH] " asymmetros
@ 2021-05-04 19:18 ` asymmetros
  0 siblings, 0 replies; 9+ messages in thread
From: asymmetros @ 2021-05-04 19:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

There is an updated pull request by asymmetros against master on the void-packages repository

https://github.com/asymmetros/void-packages strawberry-branch
https://github.com/void-linux/void-packages/pull/30680

Update template
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30680.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-strawberry-branch-30680.patch --]
[-- Type: text/x-diff, Size: 2097 bytes --]

From bc6363eb850c3ec60195628d232b6fc3da1554f9 Mon Sep 17 00:00:00 2001
From: asymmetros <83448175+asymmetros@users.noreply.github.com>
Date: Tue, 4 May 2021 18:53:26 +0000
Subject: [PATCH 1/2] Update template

---
 srcpkgs/strawberry/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/strawberry/template b/srcpkgs/strawberry/template
index 2621799c3421..b1a719711947 100644
--- a/srcpkgs/strawberry/template
+++ b/srcpkgs/strawberry/template
@@ -1,6 +1,6 @@
 # Template file for 'strawberry'
 pkgname=strawberry
-version=0.8.4
+version=0.9.3
 revision=1
 build_style=cmake
 hostmakedepends="pkg-config qt5-host-tools qt5-devel protobuf gettext"
@@ -14,5 +14,5 @@ short_desc="Audio player and music collection organizer"
 maintainer="q66 <daniel@octaforge.org>"
 license="GPL-3.0-or-later"
 homepage="https://www.strawberrymusicplayer.org/"
-distfiles="https://files.strawberrymusicplayer.org/${pkgname}-${version}.tar.xz"
-checksum=f93acf3217ae6b63c6ee469bf8b8a86317f724c018cf7e86c43d663c8066760b
+distfiles="https://files.strawberrymusicplayer.org/strawberry-0.9.3.tar.xz"
+checksum=0fe9c38c4d1e2f10c1130dbd87ea6e740bef729fe78820a84ffabe524a80c83e

From ed6595a63e989a6addf3714ec5cbea82e629d79c Mon Sep 17 00:00:00 2001
From: asymmetros <83448175+asymmetros@users.noreply.github.com>
Date: Tue, 4 May 2021 19:18:49 +0000
Subject: [PATCH 2/2] Update template

---
 srcpkgs/strawberry/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/strawberry/template b/srcpkgs/strawberry/template
index b1a719711947..653b98a5bf71 100644
--- a/srcpkgs/strawberry/template
+++ b/srcpkgs/strawberry/template
@@ -14,5 +14,5 @@ short_desc="Audio player and music collection organizer"
 maintainer="q66 <daniel@octaforge.org>"
 license="GPL-3.0-or-later"
 homepage="https://www.strawberrymusicplayer.org/"
-distfiles="https://files.strawberrymusicplayer.org/strawberry-0.9.3.tar.xz"
+distfiles="https://files.strawberrymusicplayer.org/${pkgname}-${version}.tar.xz"
 checksum=0fe9c38c4d1e2f10c1130dbd87ea6e740bef729fe78820a84ffabe524a80c83e

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-05-17  3:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 22:08 [PR PATCH] Update template grim-cypher
2021-04-28 22:52 ` ericonr
2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
2021-04-29  0:25 ` grim-cypher
2021-04-29  0:40 ` FollieHiyuki
2021-04-29 14:46 ` ericonr
2021-05-17  3:57 ` ericonr
2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
2021-05-04 19:00 [PR PATCH] " asymmetros
2021-05-04 19:18 ` [PR PATCH] [Updated] " asymmetros

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git