Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Update template
@ 2021-04-28 22:08 grim-cypher
  2021-04-28 22:52 ` ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 23+ messages in thread
From: grim-cypher @ 2021-04-28 22:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

There is a new pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 1102 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
@ 2021-04-28 22:52 ` ericonr
  2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-04-28 22:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-828832311

Comment:
Please use the correct commit message `gradle: update to 7.0`

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
  2021-04-28 22:52 ` ericonr
@ 2021-04-28 23:08 ` grim-cypher
  2021-04-29  0:25 ` grim-cypher
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: grim-cypher @ 2021-04-28 23:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an updated pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 2280 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH 1/2] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

From 395d272d0e486e771fd3a9c9f2c22b90977d7bb6 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 04:38:23 +0530
Subject: [PATCH 2/2] Update template

---
 srcpkgs/gradle/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 88dab9e9d732..ca05694dac2f 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -9,12 +9,12 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
+checksum="https://services.gradle.org/distributions/gradle-${version}-bin.zip.sha256"
+
 
 do_install() {
-	vmkdir "usr/lib/gradle"
-	sed ${FILESDIR}/gradle -e "s;@VERSION@;${version};" > gradle
-	vbin gradle
-	vdoc README
-	mv lib ${DESTDIR}/usr/lib/gradle/
+	wget ${distfiles}
+	mkdir /opt/gradle
+	unzip -d /opt/gradle gradle-${version}-bin.zip
+	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
 }

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Updated] Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
  2021-04-28 22:52 ` ericonr
  2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
@ 2021-04-29  0:25 ` grim-cypher
  2021-04-29  0:40 ` FollieHiyuki
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: grim-cypher @ 2021-04-29  0:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an updated pull request by grim-cypher against master on the void-packages repository

https://github.com/grim-cypher/void-packages patch-1
https://github.com/void-linux/void-packages/pull/30568

Update template
updating to the new version of gradle 7.0



A patch file from https://github.com/void-linux/void-packages/pull/30568.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-30568.patch --]
[-- Type: text/x-diff, Size: 2996 bytes --]

From dbf3c614c83def74df767701734676427412b82d Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Wed, 28 Apr 2021 21:44:36 +0530
Subject: [PATCH 1/3] Update template

updating to the new version of gradle 7.0
---
 srcpkgs/gradle/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 8e9f08a9910b..88dab9e9d732 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -1,6 +1,6 @@
 # Template file for 'gradle'
 pkgname=gradle
-version=6.8.1
+version=7.0
 revision=1
 depends="virtual?java-environment"
 short_desc="Build system for Java/C/C++ software"
@@ -9,7 +9,7 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=fd591a34af7385730970399f473afabdb8b28d57fd97d6625c388d090039d6fd
+checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
 
 do_install() {
 	vmkdir "usr/lib/gradle"

From 395d272d0e486e771fd3a9c9f2c22b90977d7bb6 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 04:38:23 +0530
Subject: [PATCH 2/3] Update template

---
 srcpkgs/gradle/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index 88dab9e9d732..ca05694dac2f 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -9,12 +9,12 @@ license="Apache-2.0"
 homepage="https://gradle.org/"
 changelog="https://docs.gradle.org/${version}/release-notes.html"
 distfiles="https://services.gradle.org/distributions/gradle-${version}-bin.zip"
-checksum=eb8b89184261025b0430f5b2233701ff1377f96da1ef5e278af6ae8bac5cc305
+checksum="https://services.gradle.org/distributions/gradle-${version}-bin.zip.sha256"
+
 
 do_install() {
-	vmkdir "usr/lib/gradle"
-	sed ${FILESDIR}/gradle -e "s;@VERSION@;${version};" > gradle
-	vbin gradle
-	vdoc README
-	mv lib ${DESTDIR}/usr/lib/gradle/
+	wget ${distfiles}
+	mkdir /opt/gradle
+	unzip -d /opt/gradle gradle-${version}-bin.zip
+	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
 }

From ea2e01deab46a64663efb2e4ae657eff70742634 Mon Sep 17 00:00:00 2001
From: grim-cypher <80390283+grim-cypher@users.noreply.github.com>
Date: Thu, 29 Apr 2021 05:55:20 +0530
Subject: [PATCH 3/3] Update template

---
 srcpkgs/gradle/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gradle/template b/srcpkgs/gradle/template
index ca05694dac2f..d43fa54eeccd 100644
--- a/srcpkgs/gradle/template
+++ b/srcpkgs/gradle/template
@@ -16,5 +16,6 @@ do_install() {
 	wget ${distfiles}
 	mkdir /opt/gradle
 	unzip -d /opt/gradle gradle-${version}-bin.zip
-	export PATH=$PATH:/opt/gradle/gradle-${version}/bin
+	ln /opt/gradle/gradle-${version}/bin/gradle /usr/bin/gradle
 }
+do_install

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (2 preceding siblings ...)
  2021-04-29  0:25 ` grim-cypher
@ 2021-04-29  0:40 ` FollieHiyuki
  2021-04-29 14:46 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 23+ messages in thread
From: FollieHiyuki @ 2021-04-29  0:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-828870056

Comment:
Please squash all your commits into 1 with message `gradle: update to 7.0`.

And don't do all the `wget` and `unzip` ... inside the template, `xbps-src` will handle that. This is not really an installer script either so drop the last line with `do_install` call as well.

Anyways you can always re-read the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) and checkout templates for other packages to know how to properly write a template.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (3 preceding siblings ...)
  2021-04-29  0:40 ` FollieHiyuki
@ 2021-04-29 14:46 ` ericonr
  2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
  2021-05-17  3:57 ` ericonr
  6 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-04-29 14:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-829300746

Comment:
I believe there is a misunderstanding here... A template isn't a script that installs a given piece of software on your system, it's instead supposed to be used to create a package (a compressed tarball), which is what the package manager (xbps) will use to install the software. The template did this correctly, but your changes seem to be moving in the direction of making it a script. If you look at the README, you will see that templates aren't supposed to be run directly, but instead that you're supposed to run `./xbps-src pkg gradle` and this will create a gradle package inside `hostdir/binpkgs/` which you can install using `xi gradle` (`xi` being a script from the `xtools` package).

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PR PATCH] [Closed]: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (4 preceding siblings ...)
  2021-04-29 14:46 ` ericonr
@ 2021-05-17  3:57 ` ericonr
  2021-05-17  3:57 ` ericonr
  6 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-05-17  3:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

There's a closed pull request on the void-packages repository

Update template
https://github.com/void-linux/void-packages/pull/30568

Description:
updating to the new version of gradle 7.0



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-04-28 22:08 [PR PATCH] Update template grim-cypher
                   ` (5 preceding siblings ...)
  2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
@ 2021-05-17  3:57 ` ericonr
  6 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2021-05-17  3:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30568#issuecomment-841965575

Comment:
Closing due to inactivity. Feel free to reopen!

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2023-10-04 13:16 [PR PATCH] " hk0O7
@ 2023-10-04 13:21 ` abenson
  0 siblings, 0 replies; 23+ messages in thread
From: abenson @ 2023-10-04 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/46429#issuecomment-1746867959

Comment:
Please update the commit message to following [convention](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes).

It should say: `kodi-addon-inputstream-adaptive: update to 19.0.7.`

You can edit your commit message by amending the commit:

    $ git commit --amend

This will open an editor allowing you to edit the commit message, then save and quit. Next, force push to your branch.

    $ git push -f



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
                   ` (6 preceding siblings ...)
  2022-01-30 17:41 ` zen0bit
@ 2022-01-30 17:41 ` paper42
  7 siblings, 0 replies; 23+ messages in thread
From: paper42 @ 2022-01-30 17:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025192936

Comment:
> ```
> >>> a = "123"
> >>> a is "123"
> <stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
> True
> >>> a == "123"
> True
> ```

This actually works only in some cases, if you describe what is actually happening, what is the bug and how can we reproduce this, we can reopen this PR.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
                   ` (5 preceding siblings ...)
  2022-01-30 17:02 ` paper42
@ 2022-01-30 17:41 ` zen0bit
  2022-01-30 17:41 ` paper42
  7 siblings, 0 replies; 23+ messages in thread
From: zen0bit @ 2022-01-30 17:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025192898

Comment:
Yes

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
                   ` (4 preceding siblings ...)
  2022-01-30 15:26 ` zen0bit
@ 2022-01-30 17:02 ` paper42
  2022-01-30 17:41 ` zen0bit
  2022-01-30 17:41 ` paper42
  7 siblings, 0 replies; 23+ messages in thread
From: paper42 @ 2022-01-30 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025185463

Comment:
```
>>> a = "123"
>>> a is "123"
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
True
>>> a == "123"
True
```
So this PR is not fixing anything other than syntax warnings, if I am wrong, please leave a comment. I asked multiple times what this PR is supposed to fix, but you didn't respond. 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
                   ` (3 preceding siblings ...)
  2022-01-14 22:05 ` paper42
@ 2022-01-30 15:26 ` zen0bit
  2022-01-30 17:02 ` paper42
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: zen0bit @ 2022-01-30 15:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025166819

Comment:
I cannot build it anymore even from official template...

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
                   ` (2 preceding siblings ...)
  2022-01-14 18:48 ` zen0bit
@ 2022-01-14 22:05 ` paper42
  2022-01-30 15:26 ` zen0bit
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: paper42 @ 2022-01-14 22:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013505004

Comment:
Please test the changes on your computer first, verify that git log shows what you expect and then force push here.

> The commit description is useless, is this fixing a bug? Could you describe it?

Could you describe what are you trying to achieve?

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
  2021-12-14 13:19 ` Duncaen
  2022-01-14 12:19 ` paper42
@ 2022-01-14 18:48 ` zen0bit
  2022-01-14 22:05 ` paper42
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: zen0bit @ 2022-01-14 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013371882

Comment:
I am already trying...
First try here
https://github.com/oSoWoSo/void-packages/tree/clearine-patch

Not tested yet

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
  2021-12-14 13:19 ` Duncaen
@ 2022-01-14 12:19 ` paper42
  2022-01-14 18:48 ` zen0bit
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: paper42 @ 2022-01-14 12:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013071032

Comment:
I looked at your fork and it is only one commit ahead of the archived upstream - https://github.com/oSoWoSo/clearine/commit/a59184e0e7c9ed49437c255e37944457bf531690. The commit description is useless, is this fixing a bug? Could you describe it? If it is, I think we should just include patch in this repository and not change the upstream.

cc @steinex - the package maintainer

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-12-14  1:28 [PR PATCH] " zen0bit
@ 2021-12-14 13:19 ` Duncaen
  2022-01-14 12:19 ` paper42
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: Duncaen @ 2021-12-14 13:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/34519#issuecomment-993531766

Comment:
1. You don't have to reopen PRs, force push to the branch instead of spamming new PRs.
2. Switching maintainer and upstream to your own without any reason/input/comment seems weird.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2021-05-04 19:00 [PR PATCH] " asymmetros
@ 2021-05-04 19:06 ` q66
  0 siblings, 0 replies; 23+ messages in thread
From: q66 @ 2021-05-04 19:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/30680#issuecomment-832175465

Comment:
fix commit message, also the URL shouldn't be replaced

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2020-09-11 21:57 [PR PATCH] " the-cleaner-66
                   ` (2 preceding siblings ...)
  2020-09-12  4:44 ` the-cleaner-66
@ 2020-09-12  7:55 ` pullmoll
  3 siblings, 0 replies; 23+ messages in thread
From: pullmoll @ 2020-09-12  7:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24840#issuecomment-691438863

Comment:
Working on it.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2020-09-11 21:57 [PR PATCH] " the-cleaner-66
  2020-09-12  0:15 ` ericonr
  2020-09-12  4:42 ` the-cleaner-66
@ 2020-09-12  4:44 ` the-cleaner-66
  2020-09-12  7:55 ` pullmoll
  3 siblings, 0 replies; 23+ messages in thread
From: the-cleaner-66 @ 2020-09-12  4:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

New comment by the-cleaner-66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407984

Comment:
Perfect, thanks for your help!

Kind regards
Michael Krahl

Am Fri, 11 Sep 2020 23:49:59 +0000 (UTC)
schrieb fosslinux <notifications@github.com>:

> @fosslinux commented on this pull request.
> 
> 
> 
> >  wrksrc="VirtualBox-${version%*a}"
>  short_desc="General-purpose full virtualizer for x86 hardware"
>  maintainer="Orphaned <orphan@voidlinux.org>"
>  license="GPL-2.0-only, CDDL-1.0"
>  homepage="https://www.virtualbox.org"
>  changelog="https://www.virtualbox.org/wiki/Changelog"
> -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2"
> -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0
> +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2"
> 
> `distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"`
> to make it clearer, imo
> 


-- 
Michael Krahl
Weiherstraße 16
D-89257 Illertissen
Tel.: 07303-43726


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2020-09-11 21:57 [PR PATCH] " the-cleaner-66
  2020-09-12  0:15 ` ericonr
@ 2020-09-12  4:42 ` the-cleaner-66
  2020-09-12  4:44 ` the-cleaner-66
  2020-09-12  7:55 ` pullmoll
  3 siblings, 0 replies; 23+ messages in thread
From: the-cleaner-66 @ 2020-09-12  4:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

New comment by the-cleaner-66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407721

Comment:
Thank you for the hints!
I have one question: Where do I have to place the [ci skip] flag?
Building the package took almost 60 minutes on my workstation laptop.

Kind regards
Michael Krahl

Am Fri, 11 Sep 2020 15:01:45 -0700
schrieb John Zimmermann <notifications@github.com>:

> @Johnnynator requested changes on this pull request.
> 
> Use commit naming as outlined in
> https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md
> 
> >  wrksrc="VirtualBox-${version%*a}"
>  short_desc="General-purpose full virtualizer for x86 hardware"
>  maintainer="Orphaned <orphan@voidlinux.org>"
>  license="GPL-2.0-only, CDDL-1.0"
>  homepage="https://www.virtualbox.org"
>  changelog="https://www.virtualbox.org/wiki/Changelog"
> -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2"
> -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0
> +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2"
> 
> Stay with $version and just append the `a` to the version string. And
> don't bump the revision.
> 


-- 
Michael Krahl
Weiherstraße 16
D-89257 Illertissen
Tel.: 07303-43726


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
  2020-09-11 21:57 [PR PATCH] " the-cleaner-66
@ 2020-09-12  0:15 ` ericonr
  2020-09-12  4:42 ` the-cleaner-66
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 23+ messages in thread
From: ericonr @ 2020-09-12  0:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24840#issuecomment-691362048

Comment:
This PR should include the changes from #24838 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Update template
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20137@inbox.vuxu.org>
@ 2020-03-16 15:37 ` Piraty
  0 siblings, 0 replies; 23+ messages in thread
From: Piraty @ 2020-03-16 15:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20137#issuecomment-599604717

Comment:
please follow the convention on how to format commit messages

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2023-10-04 13:21 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 22:08 [PR PATCH] Update template grim-cypher
2021-04-28 22:52 ` ericonr
2021-04-28 23:08 ` [PR PATCH] [Updated] " grim-cypher
2021-04-29  0:25 ` grim-cypher
2021-04-29  0:40 ` FollieHiyuki
2021-04-29 14:46 ` ericonr
2021-05-17  3:57 ` [PR PATCH] [Closed]: " ericonr
2021-05-17  3:57 ` ericonr
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04 13:16 [PR PATCH] " hk0O7
2023-10-04 13:21 ` abenson
2021-12-14  1:28 [PR PATCH] " zen0bit
2021-12-14 13:19 ` Duncaen
2022-01-14 12:19 ` paper42
2022-01-14 18:48 ` zen0bit
2022-01-14 22:05 ` paper42
2022-01-30 15:26 ` zen0bit
2022-01-30 17:02 ` paper42
2022-01-30 17:41 ` zen0bit
2022-01-30 17:41 ` paper42
2021-05-04 19:00 [PR PATCH] " asymmetros
2021-05-04 19:06 ` q66
2020-09-11 21:57 [PR PATCH] " the-cleaner-66
2020-09-12  0:15 ` ericonr
2020-09-12  4:42 ` the-cleaner-66
2020-09-12  4:44 ` the-cleaner-66
2020-09-12  7:55 ` pullmoll
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-20137@inbox.vuxu.org>
2020-03-16 15:37 ` Piraty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).