From: yopito <yopito@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WIP] New packages: qt6
Date: Sat, 01 May 2021 20:10:02 +0200 [thread overview]
Message-ID: <20210501181002.rqFISv0HRredxHmQOmqgXEFpzoV8mNaeGErWVsNDKVg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27349@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
New review comment by yopito on void-packages repository
https://github.com/void-linux/void-packages/pull/27349#discussion_r624544817
Comment:
I had a look on qt6-base and cmake. here my points:
"`-D-DQT_USE_CCACHE`" has no effect if ccache is enabled from xbps-src : ccache will be used.
I think "`-DQT_USE_CCACHE=OFF`" might be a better idea (similar to other packages)
qt6-base build uses precompiled headers (pch) when working with automoc. ccache does not handle pch until some additional configuration (see https://ccache.dev/manual/4.2.1.html#_precompiled_headers).
=> so ccache is rather useless in this case: about 150/1160 "objects" are stored in ccache
workarounds:
* hope that packagers will enable pch support in ccache. IMHO, this support is somewhat imprecise, afraid of false positive
* disable use of pch for building qt6-base with "`-DBUILD_WITH_PCH=OFF`" : some overhead (not that much) on first build, but ccache efficiency after (about 70 minutes on 1st run, 6 minutes then to build+package qt6-base). And no particular settings
next prev parent reply other threads:[~2021-05-01 18:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 13:35 [PR PATCH] common/build-style/cmake.sh: pass full path of TOOLCHAIN_FILE to cmake Johnnynator
2020-12-22 13:41 ` [PR PATCH] [Updated] [WIP] New packages: qt6 Johnnynator
2020-12-22 18:39 ` ericonr
2020-12-23 23:17 ` Johnnynator
2020-12-23 23:19 ` [PR PATCH] [Updated] " Johnnynator
2020-12-23 23:20 ` Johnnynator
2020-12-24 11:01 ` Johnnynator
2021-04-29 17:19 ` Johnnynator
2021-04-29 19:02 ` Johnnynator
2021-04-29 19:44 ` Johnnynator
2021-05-01 9:59 ` Johnnynator
2021-05-01 18:10 ` yopito [this message]
2021-05-01 18:10 ` [PR REVIEW] " yopito
2021-05-01 18:11 ` yopito
2021-05-01 22:06 ` [PR PATCH] [Updated] " Johnnynator
2021-05-05 14:44 ` Johnnynator
2021-05-05 22:06 ` [PR REVIEW] " yopito
2021-05-06 14:14 ` [PR PATCH] [Updated] " Johnnynator
2021-05-06 14:25 ` [PR PATCH] [Updated] " Johnnynator
2021-05-06 15:24 ` Johnnynator
2021-05-06 16:23 ` Johnnynator
2021-05-06 16:23 ` [PR PATCH] [Merged]: " Johnnynator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210501181002.rqFISv0HRredxHmQOmqgXEFpzoV8mNaeGErWVsNDKVg@z \
--to=yopito@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).