From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: nextdns-1.32.1
Date: Sun, 02 May 2021 23:27:38 +0200 [thread overview]
Message-ID: <20210502212738.5lcvppdzLEPCoDHLC0XDr7DeKHjz2IJi_SYodGxmHg0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30603@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/30603#discussion_r624757946
Comment:
This should not replicate the `build_style`s functions, instead use `pre_install` or `post_install` for `vsv` and `vlicense`.
next prev parent reply other threads:[~2021-05-02 21:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 6:53 [PR PATCH] " itsanubhavkini
2021-05-01 6:56 ` itsanubhavkini
2021-05-01 6:57 ` itsanubhavkini
2021-05-02 17:56 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-02 21:25 ` [PR REVIEW] " Duncaen
2021-05-02 21:27 ` Duncaen [this message]
2021-05-02 21:28 ` Duncaen
2021-05-03 3:46 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-09 4:48 ` anubhavkini
2021-05-09 6:45 ` [PR REVIEW] " anubhavkini
2021-05-10 10:06 ` anubhavkini
2021-05-10 13:15 ` ericonr
2021-05-10 15:49 ` anubhavkini
2021-05-10 16:22 ` anubhavkini
2021-05-11 2:08 ` anubhavkini
2021-05-17 3:35 ` [PR PATCH] [Updated] " anubhavkini
2021-06-03 5:55 ` [PR PATCH] [Closed]: New package: nextdns-1.32.2 anubhavkini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210502212738.5lcvppdzLEPCoDHLC0XDr7DeKHjz2IJi_SYodGxmHg0@z \
--to=duncaen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).