From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xen: update to 4.14.2.
Date: Mon, 03 May 2021 04:32:07 +0200 [thread overview]
Message-ID: <20210503023207.Wkuy4NH8Ee0RRND64hybCX8Q7Iz4G-eEDVwh3YCJJM8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30599@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/30599#issuecomment-830991722
Comment:
> I didn't say I thought `/proc` wasn't ugly, more that it's less ugly to use the native pid following in runit and then check the specific process details than it is to walk the entire process tree.
"[J]ust as ugly" is too strong; I agree using `/proc` isn't as bad as `pgrep`.
All of these are racy because no solutions guarantee that the daemon is in a usable state when the check is applied. I suppose a key question is what happens with `xenstore-write` if the necessary services aren't up. If the process just fails detectably, then drop the `check` script and the `sv check` and just monitor the return code on the `xenstore-write` invocations. Otherwise, if `xenstore-write` does unexpected things, the lock should accomplish what we need.
next prev parent reply other threads:[~2021-05-03 2:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 22:18 [PR PATCH] " CMB
2021-05-02 14:33 ` ericonr
2021-05-02 14:33 ` ericonr
2021-05-03 0:22 ` [PR REVIEW] " heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 0:22 ` heliocat
2021-05-03 1:51 ` ahesford
2021-05-03 1:51 ` ahesford
2021-05-03 1:51 ` ahesford
2021-05-03 1:51 ` ahesford
2021-05-03 1:51 ` ahesford
2021-05-03 2:00 ` ahesford
2021-05-03 2:00 ` ahesford
2021-05-03 2:09 ` heliocat
2021-05-03 2:15 ` heliocat
2021-05-03 2:19 ` heliocat
2021-05-03 2:23 ` [PR REVIEW] " ahesford
2021-05-03 2:32 ` ahesford [this message]
2021-05-03 3:16 ` heliocat
2021-05-03 8:32 ` Piraty
2021-06-27 1:14 ` [PR PATCH] [Updated] " CMB
2021-06-27 1:20 ` CMB
2021-06-27 1:22 ` CMB
2022-05-18 2:09 ` github-actions
2022-06-01 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503023207.Wkuy4NH8Ee0RRND64hybCX8Q7Iz4G-eEDVwh3YCJJM8@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).