Re: [PR PATCH] [Updated] Enable MSCHAPv2 with StrongSwan.

[dstolfa <dstolfa@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

There is an updated pull request by dstolfa against master on the void-packages repository

https://github.com/dstolfa/void-packages master
https://github.com/void-linux/void-packages/pull/30642

Enable MSCHAPv2 with StrongSwan.
StrongSwan on Void currently has issues with EAP-MSCHAPv2 in different ways.

(1) eap-identity needs to be enabled in order for config files with `eap_identity=%any` and similar lines to work (you essentially end up with `EAP_NAK` when `EAP_IDENTITY` is requested);
(2) eap-mschapv2 requires `md4` to be enabled as a plugin
(3) eap-dynamic **might** be required on some setups, so this pull request enables it to avoid issues in the future.

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [x] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [x] aarch64-musl
  - [x] armv7l
  - [x] armv6l-musl

I have **not tested** if it runs on any of the cross builds, I simply tested that it indeed does build.

A patch file from https://github.com/void-linux/void-packages/pull/30642.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-30642.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From d7cb895d4566bfcd4446bfa51ebcd0e1f5c30b3f Mon Sep 17 00:00:00 2001
From: Domagoj Stolfa <ds815@gmx.com>
Date: Mon, 3 May 2021 15:10:25 +0100
Subject: [PATCH] strongswan: enable options that are required for MSCHAPv2.

---
 srcpkgs/strongswan/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/strongswan/template b/srcpkgs/strongswan/template
index f0be1ff9bdc3..36abce68ea26 100644
--- a/srcpkgs/strongswan/template
+++ b/srcpkgs/strongswan/template
@@ -1,13 +1,12 @@
 # Template file for 'strongswan'
 pkgname=strongswan
 version=5.8.4
-revision=1
+revision=2
 build_style=gnu-configure
 # tpm support waits on libtss2
-configure_args="--disable-static --enable-blowfish --enable-curl
- --enable-eap-radius --enable-eap-mschapv2 --enable-eap-md5 --enable-led
- --enable-ha --enable-dhcp --enable-mediation --enable-soup --disable-des
- --enable-chapoly --enable-nm"
+configure_args="--disable-static --enable-blowfish --enable-curl --enable-md4
+ --enable-eap-radius --enable-eap-mschapv2 --enable-eap-md5 --enable-eap-identity --enable-eap-dynamic
+ --enable-led --enable-ha --enable-dhcp --enable-mediation --enable-soup --enable-chapoly --enable-nm"
 hostmakedepends="pkg-config flex bison python"
 makedepends="gmp-devel libsoup-devel libldns-devel unbound-devel libcurl-devel NetworkManager-devel"
 depends="iproute2 sqlite"