Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] update docker
@ 2021-04-14 22:56 radiden
  2021-04-20 17:22 ` [PR PATCH] [Closed]: " radiden
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: radiden @ 2021-04-14 22:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

There is a new pull request by radiden against master on the void-packages repository

https://github.com/radiden/void-packages moby-update
https://github.com/void-linux/void-packages/pull/30244

update docker
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-moby-update-30244.patch --]
[-- Type: text/x-diff, Size: 2378 bytes --]

From 2775888c43519f7f6f1a33c00fa46289185d441d Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Thu, 15 Apr 2021 00:49:22 +0200
Subject: [PATCH 1/2] docker-cli: update to 20.10.6.

---
 srcpkgs/docker-cli/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/docker-cli/template b/srcpkgs/docker-cli/template
index c337e08b39fa..d3854fb07a1a 100644
--- a/srcpkgs/docker-cli/template
+++ b/srcpkgs/docker-cli/template
@@ -1,6 +1,6 @@
 # Template file for 'docker-cli'
 pkgname=docker-cli
-version=20.10.5
+version=20.10.6
 revision=2
 wrksrc="cli-${version}"
 build_style=go
@@ -16,7 +16,7 @@ maintainer="PWA COLLECTIVE <mail@pwa.cya.cx>"
 license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/docker/cli/archive/v${version}.tar.gz"
-checksum=4ba845f8c7e2e0a2ca1ec6589847159ca8d0d37b609f0e6f78def7a893b9b342
+checksum=eda53b96ab83a59502df2e5e00ab7ee867243259407ef454be55e695303c1113
 system_groups="docker"
 
 pre_build() {

From cd6983b79374d90a095b6f0bd3108a03dae112ee Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Thu, 15 Apr 2021 00:54:21 +0200
Subject: [PATCH 2/2] moby: update to 20.10.6.

---
 srcpkgs/moby/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/moby/template b/srcpkgs/moby/template
index 6d8ef4e83729..fc57b7d82de8 100644
--- a/srcpkgs/moby/template
+++ b/srcpkgs/moby/template
@@ -1,8 +1,8 @@
 # Template file for 'moby'
 pkgname=moby
-version=20.10.5
+version=20.10.6
 revision=1
-_libnetwork_commit=fa125a3512ee0f6187721c88582bf8c4378bd4d7
+_libnetwork_commit=b3507428be5b458cb0e2b4086b13531fb0706e46
 create_wrksrc=yes
 build_style=go
 go_import_path="github.com/docker/docker"
@@ -15,8 +15,8 @@ license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/moby/moby/archive/v${version}.tar.gz>moby-$version.tar.gz
  https://github.com/docker/libnetwork/archive/$_libnetwork_commit.tar.gz>libnetwork-$_libnetwork_commit.tar.gz"
-checksum="bcf651d75e5c80421e8cd3b0d47f3425e01047cf67aef0eda83b68776905a583
- 9ce0fa64b00d9ef86971bdeb01cb24b02e6751c0d159ccb057521a41762750f4"
+checksum="fd7f5571b1f64f26b5ca520a3e1fefb33c190f3732b931051c23a76bdba5000e
+ 90a8dc84bc5d2d74dee0b2c3544f8786598ff85e9fc9f6a55a15b60b7cd78d63"
 system_groups="docker"
 
 _moby_builddir="moby-$version"

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Closed]: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
@ 2021-04-20 17:22 ` radiden
  2021-04-20 17:22 ` [PR PATCH] [Updated] " radiden
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: radiden @ 2021-04-20 17:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

There's a closed pull request on the void-packages repository

update docker
https://github.com/void-linux/void-packages/pull/30244

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
  2021-04-20 17:22 ` [PR PATCH] [Closed]: " radiden
@ 2021-04-20 17:22 ` radiden
  2021-04-20 17:39 ` radiden
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: radiden @ 2021-04-20 17:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is an updated pull request by radiden against master on the void-packages repository

https://github.com/radiden/void-packages moby-update
https://github.com/void-linux/void-packages/pull/30244

update docker
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-moby-update-30244.patch --]
[-- Type: text/x-diff, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
  2021-04-20 17:22 ` [PR PATCH] [Closed]: " radiden
  2021-04-20 17:22 ` [PR PATCH] [Updated] " radiden
@ 2021-04-20 17:39 ` radiden
  2021-04-20 18:23 ` radiden
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: radiden @ 2021-04-20 17:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is an updated pull request by radiden against master on the void-packages repository

https://github.com/radiden/void-packages moby-update
https://github.com/void-linux/void-packages/pull/30244

update docker
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-moby-update-30244.patch --]
[-- Type: text/x-diff, Size: 3913 bytes --]

From de30164b5e310690ae0ef85356e94d59d33cb74d Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 19:38:49 +0200
Subject: [PATCH 1/3] moby: update to 20.10.6.

---
 srcpkgs/moby/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/moby/template b/srcpkgs/moby/template
index 6d8ef4e83729..50e198d91574 100644
--- a/srcpkgs/moby/template
+++ b/srcpkgs/moby/template
@@ -1,8 +1,8 @@
 # Template file for 'moby'
 pkgname=moby
-version=20.10.5
+version=20.10.6
 revision=1
-_libnetwork_commit=fa125a3512ee0f6187721c88582bf8c4378bd4d7
+_libnetwork_commit=b3507428be5b458cb0e2b4086b13531fb0706e46
 create_wrksrc=yes
 build_style=go
 go_import_path="github.com/docker/docker"
@@ -10,13 +10,13 @@ hostmakedepends="pkg-config"
 makedepends="libbtrfs-devel device-mapper-devel libseccomp-devel"
 depends="containerd iptables xz"
 short_desc="Container engine for the Docker ecosystem"
-maintainer="PWA COLLECTIVE <mail@pwa.cya.cx>"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
 license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/moby/moby/archive/v${version}.tar.gz>moby-$version.tar.gz
  https://github.com/docker/libnetwork/archive/$_libnetwork_commit.tar.gz>libnetwork-$_libnetwork_commit.tar.gz"
-checksum="bcf651d75e5c80421e8cd3b0d47f3425e01047cf67aef0eda83b68776905a583
- 9ce0fa64b00d9ef86971bdeb01cb24b02e6751c0d159ccb057521a41762750f4"
+checksum="fd7f5571b1f64f26b5ca520a3e1fefb33c190f3732b931051c23a76bdba5000e
+ 90a8dc84bc5d2d74dee0b2c3544f8786598ff85e9fc9f6a55a15b60b7cd78d63"
 system_groups="docker"
 
 _moby_builddir="moby-$version"

From 60694422e28d74b86986b7594c6d195b35f0e6b9 Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 19:38:53 +0200
Subject: [PATCH 2/3] docker-cli: update to 20.10.6.

---
 srcpkgs/docker-cli/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/docker-cli/template b/srcpkgs/docker-cli/template
index c337e08b39fa..89ed71ad8293 100644
--- a/srcpkgs/docker-cli/template
+++ b/srcpkgs/docker-cli/template
@@ -1,6 +1,6 @@
 # Template file for 'docker-cli'
 pkgname=docker-cli
-version=20.10.5
+version=20.10.6
 revision=2
 wrksrc="cli-${version}"
 build_style=go
@@ -12,11 +12,11 @@ go_ldflags="-X \"${_cli_ver_path}.Version=${version}\"
 hostmakedepends="pkg-config"
 depends="git"
 short_desc="Command-line interface for the Docker daemon"
-maintainer="PWA COLLECTIVE <mail@pwa.cya.cx>"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
 license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/docker/cli/archive/v${version}.tar.gz"
-checksum=4ba845f8c7e2e0a2ca1ec6589847159ca8d0d37b609f0e6f78def7a893b9b342
+checksum=eda53b96ab83a59502df2e5e00ab7ee867243259407ef454be55e695303c1113
 system_groups="docker"
 
 pre_build() {

From 698958e068af5cbc39e2a789db69e4e736e6ed69 Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 19:39:02 +0200
Subject: [PATCH 3/3] New package: tini-0.19.0

---
 srcpkgs/tini/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tini/template

diff --git a/srcpkgs/tini/template b/srcpkgs/tini/template
new file mode 100644
index 000000000000..fb18b07ba3f2
--- /dev/null
+++ b/srcpkgs/tini/template
@@ -0,0 +1,17 @@
+# Template file for 'tini'
+pkgname=tini
+version=0.19.0
+revision=1
+build_style=cmake
+short_desc="Tiny but valid init for containers"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
+license="MIT"
+homepage="https://github.com/krallin/tini"
+distfiles="https://github.com/krallin/tini/archive/refs/tags/v$version.tar.gz"
+checksum=0fd35a7030052acd9f58948d1d900fe1e432ee37103c5561554408bdac6bbf0d
+CFLAGS="-DPR_SET_CHILD_SUBREAPER=36 -DPR_GET_CHILD_SUBREAPER=37"
+
+post_install() {
+	vlicense LICENSE
+	ln -s tini-static $DESTDIR/usr/bin/docker-init
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (2 preceding siblings ...)
  2021-04-20 17:39 ` radiden
@ 2021-04-20 18:23 ` radiden
  2021-04-20 18:52 ` pudiva
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: radiden @ 2021-04-20 18:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is an updated pull request by radiden against master on the void-packages repository

https://github.com/radiden/void-packages moby-update
https://github.com/void-linux/void-packages/pull/30244

update docker
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-moby-update-30244.patch --]
[-- Type: text/x-diff, Size: 4147 bytes --]

From 9aac89005ab1e4ecae7baf27982501c216cf3754 Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 20:20:25 +0200
Subject: [PATCH 1/3] moby: update to 20.10.6.

---
 srcpkgs/moby/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/moby/template b/srcpkgs/moby/template
index 6d8ef4e83729..50e198d91574 100644
--- a/srcpkgs/moby/template
+++ b/srcpkgs/moby/template
@@ -1,8 +1,8 @@
 # Template file for 'moby'
 pkgname=moby
-version=20.10.5
+version=20.10.6
 revision=1
-_libnetwork_commit=fa125a3512ee0f6187721c88582bf8c4378bd4d7
+_libnetwork_commit=b3507428be5b458cb0e2b4086b13531fb0706e46
 create_wrksrc=yes
 build_style=go
 go_import_path="github.com/docker/docker"
@@ -10,13 +10,13 @@ hostmakedepends="pkg-config"
 makedepends="libbtrfs-devel device-mapper-devel libseccomp-devel"
 depends="containerd iptables xz"
 short_desc="Container engine for the Docker ecosystem"
-maintainer="PWA COLLECTIVE <mail@pwa.cya.cx>"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
 license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/moby/moby/archive/v${version}.tar.gz>moby-$version.tar.gz
  https://github.com/docker/libnetwork/archive/$_libnetwork_commit.tar.gz>libnetwork-$_libnetwork_commit.tar.gz"
-checksum="bcf651d75e5c80421e8cd3b0d47f3425e01047cf67aef0eda83b68776905a583
- 9ce0fa64b00d9ef86971bdeb01cb24b02e6751c0d159ccb057521a41762750f4"
+checksum="fd7f5571b1f64f26b5ca520a3e1fefb33c190f3732b931051c23a76bdba5000e
+ 90a8dc84bc5d2d74dee0b2c3544f8786598ff85e9fc9f6a55a15b60b7cd78d63"
 system_groups="docker"
 
 _moby_builddir="moby-$version"

From cf83d4e9c1089a4e91b864db67333a9b6282dd11 Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 20:20:28 +0200
Subject: [PATCH 2/3] docker-cli: update to 20.10.6.

---
 srcpkgs/docker-cli/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/docker-cli/template b/srcpkgs/docker-cli/template
index c337e08b39fa..8299aba7846c 100644
--- a/srcpkgs/docker-cli/template
+++ b/srcpkgs/docker-cli/template
@@ -1,6 +1,6 @@
 # Template file for 'docker-cli'
 pkgname=docker-cli
-version=20.10.5
+version=20.10.6
 revision=2
 wrksrc="cli-${version}"
 build_style=go
@@ -12,11 +12,11 @@ go_ldflags="-X \"${_cli_ver_path}.Version=${version}\"
 hostmakedepends="pkg-config"
 depends="git"
 short_desc="Command-line interface for the Docker daemon"
-maintainer="PWA COLLECTIVE <mail@pwa.cya.cx>"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
 license="Apache-2.0"
 homepage="http://www.docker.io"
 distfiles="https://github.com/docker/cli/archive/v${version}.tar.gz"
-checksum=4ba845f8c7e2e0a2ca1ec6589847159ca8d0d37b609f0e6f78def7a893b9b342
+checksum=eda53b96ab83a59502df2e5e00ab7ee867243259407ef454be55e695303c1113
 system_groups="docker"
 
 pre_build() {
@@ -32,5 +32,5 @@ post_install() {
 docker_package() {
 	build_style="meta"
 	short_desc="Docker container runtime"
-	depends="${sourcepkg}>=${version}_${revision} moby"
+	depends="${sourcepkg}>=${version}_${revision} moby tini"
 }

From 43ce07e5dd8c7dc80d348490578f5c09d5d320b7 Mon Sep 17 00:00:00 2001
From: radiden <gabriel2012688@gmail.com>
Date: Tue, 20 Apr 2021 20:20:32 +0200
Subject: [PATCH 3/3] New package: tini-0.19.0

---
 srcpkgs/tini/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/tini/template

diff --git a/srcpkgs/tini/template b/srcpkgs/tini/template
new file mode 100644
index 000000000000..fb18b07ba3f2
--- /dev/null
+++ b/srcpkgs/tini/template
@@ -0,0 +1,17 @@
+# Template file for 'tini'
+pkgname=tini
+version=0.19.0
+revision=1
+build_style=cmake
+short_desc="Tiny but valid init for containers"
+maintainer="PWA COLLECTIVE <pwa@cya.cx>"
+license="MIT"
+homepage="https://github.com/krallin/tini"
+distfiles="https://github.com/krallin/tini/archive/refs/tags/v$version.tar.gz"
+checksum=0fd35a7030052acd9f58948d1d900fe1e432ee37103c5561554408bdac6bbf0d
+CFLAGS="-DPR_SET_CHILD_SUBREAPER=36 -DPR_GET_CHILD_SUBREAPER=37"
+
+post_install() {
+	vlicense LICENSE
+	ln -s tini-static $DESTDIR/usr/bin/docker-init
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (3 preceding siblings ...)
  2021-04-20 18:23 ` radiden
@ 2021-04-20 18:52 ` pudiva
  2021-04-20 19:09 ` pudiva
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 18:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823521246

Comment:
testing...

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (4 preceding siblings ...)
  2021-04-20 18:52 ` pudiva
@ 2021-04-20 19:09 ` pudiva
  2021-04-20 19:10 ` pudiva
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 19:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823531953

Comment:
Ok, the tini package does offer `docker-init`, as a symlink to `tini-static`, which fixes #30341.

Just one note though: I think that the docker package should provide this link, not tini, as tini is not restricted to docker, but a dependency of it. (but I might be wrong :woman_shrugging:)

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (5 preceding siblings ...)
  2021-04-20 19:09 ` pudiva
@ 2021-04-20 19:10 ` pudiva
  2021-04-20 19:43 ` ahesford
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 19:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823531953

Comment:
Ok, the tini package does offer `docker-init`, as a symlink to `tini-static`, which fixes #30341.

Just one note though: I think that one of the docker packages should provide this link, not tini, as tini is not restricted to docker, but a dependency of it. (but I might be wrong :woman_shrugging:)

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (6 preceding siblings ...)
  2021-04-20 19:10 ` pudiva
@ 2021-04-20 19:43 ` ahesford
  2021-04-20 21:39 ` endigma
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ahesford @ 2021-04-20 19:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823552484

Comment:
Moving the `docker-init` link to one of the `docker` packages is a good suggestion. It seems that having the `docker` metapackage depend on `tini`, and therefore offer the `docker-init` symlink, is reasonable because I believe both `moby` and `docker-cli` are usably without `tini` for some workflows.

Because I am not a major user of Docker---I prefer podman for Docker-style containers---I'd like to know what others think.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (7 preceding siblings ...)
  2021-04-20 19:43 ` ahesford
@ 2021-04-20 21:39 ` endigma
  2021-04-20 22:53 ` pudiva
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: endigma @ 2021-04-20 21:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823617239

Comment:
> Ok, the tini package does offer `docker-init`, as a symlink to `tini-static`, which fixes #30341.
> 
> Just one note though: I think that one of the docker packages should provide this link, not tini, as tini is not restricted to docker, but a dependency of it. (but I might be wrong )

It's not like the symlink is adding anything that will cause issues.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (8 preceding siblings ...)
  2021-04-20 21:39 ` endigma
@ 2021-04-20 22:53 ` pudiva
  2021-04-20 23:02 ` pudiva
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 22:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823650374

Comment:
> It's not like the symlink is adding anything that will cause issues.

except maybe disorganization and confusion...?

I mean, in this case, it's probably not a big deal, and I can understand if people decide to just merge the way it is because they have better things to do and don't want to waste their time... but I don't think that just _not causing issues_ is a good reason to oversee the quality of the packages.

I mean²: I wasn't having any issues before 9b3c344a79a1930062ec7a0df22882f3a04127ec, when the **docker** package was split into a bunch of mini packages. To me, having them altogether was _not causing issues_, so why care to split anway? :upside_down_face:

Actually... I looking at 9b3c344a79a1930062ec7a0df22882f3a04127ec again, it seems that **docker** was just renamed to **docker-cli**, and that it doesn't actually have any other **docker-** package... why was it split?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (9 preceding siblings ...)
  2021-04-20 22:53 ` pudiva
@ 2021-04-20 23:02 ` pudiva
  2021-04-20 23:06 ` ahesford
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 23:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823656530

Comment:
> Actually... I looking at 9b3c344 again, it seems that docker was just renamed to docker-cli, and that it doesn't actually have any other docker- package... why was it split?

I mean³: I understand there might be a benefit to splitting **moby** out of **docker**, but why rename **docker** to **docker-cli** instead of just adding **moby** as a dependency to **docker**? Is it even possible to use **docker-cli** without **moby**?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (10 preceding siblings ...)
  2021-04-20 23:02 ` pudiva
@ 2021-04-20 23:06 ` ahesford
  2021-04-20 23:10 ` pudiva
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ahesford @ 2021-04-20 23:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823657837

Comment:
It was split because Docker itself is no longer released as a monolithic package. This was the right call.

The purpose of the new `docker` meta is to pull in the new components and ensure a smooth transition. We bungled this by not including `tini` as `docker-init`. While I noticed the absence of the binary during review, I misinterpreted the `tini` README---which states that the package is included in Docker---as an indication that it would no longer be necessary. That was my mistake.

The only remaining question is whether the `docker-init` symlink belongs in `docker` or `tini`. I agree with @pudiva that it makes more sense in `docker` since that's where it will be used; however, as I said, I'd rather get some comments about this from other Void maintainers who use Docker.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (11 preceding siblings ...)
  2021-04-20 23:06 ` ahesford
@ 2021-04-20 23:10 ` pudiva
  2021-04-21  0:16 ` endigma
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: pudiva @ 2021-04-20 23:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by pudiva on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823659494

Comment:
> It was split because Docker itself is no longer released as a monolithic package. This was the right call.

ahhhhh fair enough :+1:

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (12 preceding siblings ...)
  2021-04-20 23:10 ` pudiva
@ 2021-04-21  0:16 ` endigma
  2021-04-21  0:17 ` endigma
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: endigma @ 2021-04-21  0:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823683268

Comment:
It's not really an issue either way, however thinking about it nobody should need the static binary called `docker-tini` except people using docker, so adding it to the meta-package is probably the best call, both for feature parity and cleanliness.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (13 preceding siblings ...)
  2021-04-21  0:16 ` endigma
@ 2021-04-21  0:17 ` endigma
  2021-04-22 20:13 ` endigma
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: endigma @ 2021-04-21  0:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-823683741

Comment:



> > Actually... I looking at [9b3c344](https://github.com/void-linux/void-packages/commit/9b3c344a79a1930062ec7a0df22882f3a04127ec) again, it seems that docker was just renamed to docker-cli, and that it doesn't actually have any other docker- package... why was it split?
> 
> I mean³: I understand there might be a benefit to splitting **moby** out of **docker**, but why rename **docker** to **docker-cli** instead of just adding **moby** as a dependency to **docker**? Is it even possible to use **docker-cli** without **moby**?

The `docker` package isn't a rename of docker-cli, it's a effectively a metapackage that pulls in `docker-cli`, `moby`, `tini`. This was done because these tools are not codependent, moby can function without docker-cli as docker-cli can function without moby.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (14 preceding siblings ...)
  2021-04-21  0:17 ` endigma
@ 2021-04-22 20:13 ` endigma
  2021-05-03 18:38 ` Skaytacium
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: endigma @ 2021-04-22 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by endigma on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-825154290

Comment:
Is this good to be merged?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (15 preceding siblings ...)
  2021-04-22 20:13 ` endigma
@ 2021-05-03 18:38 ` Skaytacium
  2021-05-03 18:41 ` Skaytacium
  2021-05-03 18:45 ` [PR PATCH] [Merged]: " ahesford
  18 siblings, 0 replies; 20+ messages in thread
From: Skaytacium @ 2021-05-03 18:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by Skaytacium on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-831451926

Comment:
Any idea when this will actually get merged because all the tests seem to be passing and it's approved.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (16 preceding siblings ...)
  2021-05-03 18:38 ` Skaytacium
@ 2021-05-03 18:41 ` Skaytacium
  2021-05-03 18:45 ` [PR PATCH] [Merged]: " ahesford
  18 siblings, 0 replies; 20+ messages in thread
From: Skaytacium @ 2021-05-03 18:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

New comment by Skaytacium on void-packages repository

https://github.com/void-linux/void-packages/pull/30244#issuecomment-831451926

Comment:
Any idea when this will actually get merged because all the tests seem to be passing and it's approved.

Currently, I had to compile `tini` manually and create a symlink to it in `/bin`, this could be automated pretty easily, and adds no breaking changes as far as I read into the PR and issue, to me it seems to be a problem of naming the package and including it?

It would be much better if the package was actually published and then all of this was discussed, as there are people like me who are trying to use docker-init, no offense meant at all, just my thoughts.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Merged]: update docker
  2021-04-14 22:56 [PR PATCH] update docker radiden
                   ` (17 preceding siblings ...)
  2021-05-03 18:41 ` Skaytacium
@ 2021-05-03 18:45 ` ahesford
  18 siblings, 0 replies; 20+ messages in thread
From: ahesford @ 2021-05-03 18:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

There's a merged pull request on the void-packages repository

update docker
https://github.com/void-linux/void-packages/pull/30244

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2021-05-03 18:45 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 22:56 [PR PATCH] update docker radiden
2021-04-20 17:22 ` [PR PATCH] [Closed]: " radiden
2021-04-20 17:22 ` [PR PATCH] [Updated] " radiden
2021-04-20 17:39 ` radiden
2021-04-20 18:23 ` radiden
2021-04-20 18:52 ` pudiva
2021-04-20 19:09 ` pudiva
2021-04-20 19:10 ` pudiva
2021-04-20 19:43 ` ahesford
2021-04-20 21:39 ` endigma
2021-04-20 22:53 ` pudiva
2021-04-20 23:02 ` pudiva
2021-04-20 23:06 ` ahesford
2021-04-20 23:10 ` pudiva
2021-04-21  0:16 ` endigma
2021-04-21  0:17 ` endigma
2021-04-22 20:13 ` endigma
2021-05-03 18:38 ` Skaytacium
2021-05-03 18:41 ` Skaytacium
2021-05-03 18:45 ` [PR PATCH] [Merged]: " ahesford

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git