Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: golang-migrate-4.14.1
@ 2021-05-02 21:44 kwshi
  2021-05-02 21:44 ` [PR PATCH] [Updated] " kwshi
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: kwshi @ 2021-05-02 21:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

There is a new pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1472 bytes --]

From fe056aedb15bde34db77361537e0b7a55f54e5dc Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..e781fdb85f77
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,23 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4/cmd/migrate"
+# https://github.com/golang-migrate/migrate/blob/af256da8ca1a8227cbe131eeafa6049b0154e4c4/Makefile#L1-L2
+go_build_tags="
+  postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb
+  sqlserver firebird neo4j pgx sqlite sqlcipher file go_bindata github
+  github_ee bitbucket aws_s3 google_cloud_storage godoc_vfs gitlab
+"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
@ 2021-05-02 21:44 ` kwshi
  2021-05-02 21:55 ` kwshi
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-02 21:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1472 bytes --]

From 06377012f02cdddcb70fba99a8e277fa47889f3e Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..e781fdb85f77
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,23 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4/cmd/migrate"
+# https://github.com/golang-migrate/migrate/blob/af256da8ca1a8227cbe131eeafa6049b0154e4c4/Makefile#L1-L2
+go_build_tags="
+  postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb
+  sqlserver firebird neo4j pgx sqlite sqlcipher file go_bindata github
+  github_ee bitbucket aws_s3 google_cloud_storage godoc_vfs gitlab
+"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
  2021-05-02 21:44 ` [PR PATCH] [Updated] " kwshi
@ 2021-05-02 21:55 ` kwshi
  2021-05-02 22:48 ` [PR REVIEW] " ericonr
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-02 21:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1469 bytes --]

From 8592dd5d07c3212e7a9add88d10f2d651351c984 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..9f71cac00e91
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,23 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4/cmd/migrate"
+# https://github.com/golang-migrate/migrate/blob/af256da8ca1a8227cbe131eeafa6049b0154e4c4/Makefile#L1-L2
+go_build_tags="
+	postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb
+	sqlserver firebird neo4j pgx sqlite sqlcipher file go_bindata github
+	github_ee bitbucket aws_s3 google_cloud_storage godoc_vfs gitlab
+"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
  2021-05-02 21:44 ` [PR PATCH] [Updated] " kwshi
  2021-05-02 21:55 ` kwshi
@ 2021-05-02 22:48 ` ericonr
  2021-05-02 22:48 ` ericonr
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-05-02 22:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r624792461

Comment:
Do they have a makefile or something with these tags, so we don't have to repeat and remember to update them?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (2 preceding siblings ...)
  2021-05-02 22:48 ` [PR REVIEW] " ericonr
@ 2021-05-02 22:48 ` ericonr
  2021-05-03  2:01 ` kwshi
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-05-02 22:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r624792562

Comment:
Also this should be indented with spaces.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (3 preceding siblings ...)
  2021-05-02 22:48 ` ericonr
@ 2021-05-03  2:01 ` kwshi
  2021-05-03  2:08 ` ericonr
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-03  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r624845922

Comment:
They do have a Makefile.  If I want to build using their Makefile, will I have to forgo the `build_style=go`?  Or will it be fine to just override the parts I need (e.g. `do_build`) and it will be okay?

Re. indenting: I indented it with spaces at first, but then `xlint` complained at me.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (4 preceding siblings ...)
  2021-05-03  2:01 ` kwshi
@ 2021-05-03  2:08 ` ericonr
  2021-05-03 22:30 ` [PR PATCH] [Updated] " kwshi
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-05-03  2:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r624846872

Comment:
Do use the build style, just override the functions.

Multiline strings should definitely be indented with spaces (just one!), so let xlint complain if it will.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (5 preceding siblings ...)
  2021-05-03  2:08 ` ericonr
@ 2021-05-03 22:30 ` kwshi
  2021-05-03 22:30 ` [PR REVIEW] " kwshi
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-03 22:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1194 bytes --]

From 1861ef7e1e8275043359ac57a317e37dfc194e93 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..1b8bc59d04f1
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,22 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4/cmd/migrate"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+  vbin migrate
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (6 preceding siblings ...)
  2021-05-03 22:30 ` [PR PATCH] [Updated] " kwshi
@ 2021-05-03 22:30 ` kwshi
  2021-05-03 22:31 ` [PR PATCH] [Updated] " kwshi
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-03 22:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by kwshi on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r625407603

Comment:
Updated the template to override `do_build` and use their Makefile.  No longer have to worry about multiline strings since it's not needed anymore!

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (7 preceding siblings ...)
  2021-05-03 22:30 ` [PR REVIEW] " kwshi
@ 2021-05-03 22:31 ` kwshi
  2021-05-03 23:25 ` [PR REVIEW] " ericonr
  2021-05-03 23:28 ` [PR PATCH] [Updated] " kwshi
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-03 22:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 293e24f701a80459d3191c091f9a5712dae38112 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..a5f0b4cda779
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,22 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4/cmd/migrate"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR REVIEW] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (8 preceding siblings ...)
  2021-05-03 22:31 ` [PR PATCH] [Updated] " kwshi
@ 2021-05-03 23:25 ` ericonr
  2021-05-03 23:28 ` [PR PATCH] [Updated] " kwshi
  10 siblings, 0 replies; 12+ messages in thread
From: ericonr @ 2021-05-03 23:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/30634#discussion_r625427360

Comment:
```suggestion
go_import_path="github.com/golang-migrate/migrate/v4"
go_package="cmd/migrate"
```

I think. Even if the value isn't being used anyway :p

Can probably omit `go_package`.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: golang-migrate-4.14.1
  2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
                   ` (9 preceding siblings ...)
  2021-05-03 23:25 ` [PR REVIEW] " ericonr
@ 2021-05-03 23:28 ` kwshi
  10 siblings, 0 replies; 12+ messages in thread
From: kwshi @ 2021-05-03 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

There is an updated pull request by kwshi against master on the void-packages repository

https://github.com/kwshi/void-packages golang-migrate
https://github.com/void-linux/void-packages/pull/30634

New package: golang-migrate-4.14.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/30634.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-golang-migrate-30634.patch --]
[-- Type: text/x-diff, Size: 1181 bytes --]

From 40939df0084fe7fe6f9b92eb841b5214c497ca63 Mon Sep 17 00:00:00 2001
From: Kye Shi <shi.kye@gmail.com>
Date: Sun, 2 May 2021 14:43:17 -0700
Subject: [PATCH] New package: golang-migrate-4.14.1

---
 srcpkgs/golang-migrate/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/golang-migrate/template

diff --git a/srcpkgs/golang-migrate/template b/srcpkgs/golang-migrate/template
new file mode 100644
index 000000000000..0a9b7b108c22
--- /dev/null
+++ b/srcpkgs/golang-migrate/template
@@ -0,0 +1,22 @@
+# Template file for 'golang-migrate'
+pkgname=golang-migrate
+version=4.14.1
+revision=1
+wrksrc="migrate-${version}"
+build_style=go
+go_import_path="github.com/golang-migrate/migrate/v4"
+short_desc="Database migrations CLI written in Golang"
+maintainer="Kye Shi <shi.kye@gmail.com>"
+license="MIT"
+homepage="https://github.com/golang-migrate/migrate"
+distfiles="https://github.com/golang-migrate/migrate/archive/refs/tags/v${version}.tar.gz"
+checksum="c4bb59dd2a1c99980b453f37d0838d292aef9feab86ff5ec230f13e097761017"
+
+do_build() {
+	VERSION="$version" make build
+}
+
+do_install() {
+	vbin migrate
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-05-03 23:28 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-02 21:44 [PR PATCH] New package: golang-migrate-4.14.1 kwshi
2021-05-02 21:44 ` [PR PATCH] [Updated] " kwshi
2021-05-02 21:55 ` kwshi
2021-05-02 22:48 ` [PR REVIEW] " ericonr
2021-05-02 22:48 ` ericonr
2021-05-03  2:01 ` kwshi
2021-05-03  2:08 ` ericonr
2021-05-03 22:30 ` [PR PATCH] [Updated] " kwshi
2021-05-03 22:30 ` [PR REVIEW] " kwshi
2021-05-03 22:31 ` [PR PATCH] [Updated] " kwshi
2021-05-03 23:25 ` [PR REVIEW] " ericonr
2021-05-03 23:28 ` [PR PATCH] [Updated] " kwshi

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git