From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mako: update to 1.5
Date: Wed, 05 May 2021 16:23:24 +0200 [thread overview]
Message-ID: <20210505142324._5sJH1ydnjLtLab_vngQpYlN8Sj00E7hkjPLob9SYj4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30672@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/30672#discussion_r626612993
Comment:
Not sure this part of the patch is necessary, I'd be okay with still printing the warning, since otherwise it's more stuff to rebase if they change the build system.
next prev parent reply other threads:[~2021-05-05 14:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 12:09 [PR PATCH] " itsanubhavkini
2021-05-04 12:12 ` [PR REVIEW] " ericonr
2021-05-04 12:12 ` ericonr
2021-05-04 12:18 ` itsanubhavkini
2021-05-04 12:20 ` itsanubhavkini
2021-05-04 12:23 ` ericonr
2021-05-04 13:02 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-04 13:07 ` FollieHiyuki
2021-05-04 13:17 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-04 13:22 ` itsanubhavkini
2021-05-04 13:25 ` Duncaen
2021-05-04 13:26 ` [PR REVIEW] " Duncaen
2021-05-04 14:03 ` ericonr
2021-05-04 14:06 ` Duncaen
2021-05-04 14:09 ` itsanubhavkini
2021-05-04 14:20 ` ericonr
2021-05-04 14:21 ` ericonr
2021-05-05 9:01 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-05 9:09 ` itsanubhavkini
2021-05-05 9:10 ` itsanubhavkini
2021-05-05 14:23 ` ericonr [this message]
2021-05-05 17:05 ` [PR PATCH] [Updated] " itsanubhavkini
2021-05-09 4:08 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505142324._5sJH1ydnjLtLab_vngQpYlN8Sj00E7hkjPLob9SYj4@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).