From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: ndpi: update to 3.4
Date: Wed, 05 May 2021 18:02:38 +0200 [thread overview]
Message-ID: <20210505160238.8W3bOMrCsaLXFQePUN8u3wPlXHAC8zmZMUSgqw3kKN0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30688@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
New comment by heliocat on void-packages repository
https://github.com/void-linux/void-packages/pull/30688#issuecomment-832814276
Comment:
> Could quote the `vmove` commands, I guess?
? I didn't change any of the vmove lines and quoting them would break glob expansion.
> The `do_configure` change looks ok.
I had a debate with myself if we should keep extracting the business end of autogen.sh and then letting configure run itself, overriding do_configure, or patching autogen.sh to not run ./configure itself. Obviously I went with option 2 but the third is arguably the more correct one.
As for the i686 build failure, I'd be fine marking the package broken on that architecture since nothing depends on nDPI, but I'd want @Vaelatern to weigh in first.
next prev parent reply other threads:[~2021-05-05 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 4:43 [PR PATCH] " heliocat
2021-05-05 4:52 ` heliocat
2021-05-05 14:32 ` ericonr
2021-05-05 16:02 ` heliocat [this message]
2021-05-05 16:24 ` Vaelatern
2021-05-05 16:32 ` ericonr
2021-05-05 16:34 ` ericonr
2021-05-09 4:04 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505160238.8W3bOMrCsaLXFQePUN8u3wPlXHAC8zmZMUSgqw3kKN0@z \
--to=heliocat@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).