Github messages for voidlinux
 help / color / mirror / Atom feed
From: lane-brain <lane-brain@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Signal-Desktop: update to 5.0.0.
Date: Wed, 05 May 2021 20:45:08 +0200	[thread overview]
Message-ID: <20210505184508.0pUaBZKc_6-Bcz5lVDgbyECQCsbKG-6oIkE9tWvtAGU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30696@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

New comment by lane-brain on void-packages repository

https://github.com/void-linux/void-packages/pull/30696#issuecomment-832924054

Comment:
The openssl linking and epoch source date patch yes. The former seemed justified because now we use openssl, the other one seemed necessitated by using tarballs instead of git. As far as I know about git-lfs, the documentation from Signal's github indicate that it's necessary for one of the yarn dependencies. 

As an aside, I fixed the linting error (vlicense).

And now the build has concluded but I ran into an error at post_install:

```
...
rm: cannot remove '/tmp/go/pkg/mod/golang.org/x/exp@v0.0.0-20200513190911-00229845015e/utf8string/string_test.go': Permission denied
rm: cannot remove '/tmp/go/pkg/mod/golang.org/x/exp@v0.0.0-20200513190911-00229845015e/winfsnotify/winfsnotify.go': Permission denied
rm: cannot remove '/tmp/go/pkg/mod/golang.org/x/exp@v0.0.0-20200513190911-00229845015e/winfsnotify/winfsnotify_test.go': Permission denied
=> ERROR: Signal-Desktop-5.0.0_1: post_install: 'rm -rf $HOME' exited with 1
=> ERROR:   in post_install() at srcpkgs/Signal-Desktop/template:65
```

  parent reply	other threads:[~2021-05-05 18:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 17:52 [PR PATCH] " lane-brain
2021-05-05 17:54 ` lane-brain
2021-05-05 17:55 ` ericonr
2021-05-05 18:03 ` ericonr
2021-05-05 18:45 ` lane-brain [this message]
2021-05-05 19:13 ` [PR REVIEW] " ericonr
2021-05-05 19:14 ` ericonr
2021-05-05 19:27 ` [PR REVIEW] " lane-brain
2021-05-05 19:46 ` lane-brain
2021-05-05 19:58 ` lane-brain
2021-05-05 20:14 ` lane-brain
2021-05-05 22:43 ` [PR PATCH] [Updated] " lane-brain
2021-08-01 13:03 ` notthewave
2021-08-27 17:33 ` [PR PATCH] [Closed]: " ericonr
2021-08-27 17:33 ` ericonr
  -- strict thread matches above, loose matches on Subject: below --
2021-04-26  3:21 [PR PATCH] " ScrelliCopter
2021-05-02 23:13 ` kwshi
2021-06-24 22:34 ` ScrelliCopter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210505184508.0pUaBZKc_6-Bcz5lVDgbyECQCsbKG-6oIkE9tWvtAGU@z \
    --to=lane-brain@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).