Re: x2goserver package is non-functional

[eoli3n <eoli3n@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3563 bytes --]

New comment by eoli3n on void-packages repository

https://github.com/void-linux/void-packages/issues/30781#issuecomment-837297270

Comment:
sqlite db exists in ``/var/lib/x2go/x2go_sessions``
some references:
- https://lists.x2go.org/pipermail/x2go-user/2019-March/005522.html : no answer
- https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1482 : no answer
--------
to print real error, edit ``/usr/lib/x2go/x2gocheckport`` at line 131
```
  # Filter out any empty or invalid values.
  typeset -i item_i='0'
  typeset item=''

  # add echo of the var between delimiters
  echo "##### ${used_display_ports_work[@]} #####"
  for item in "${used_display_ports_work[@]}"; do
       item_i="${item}"
```
real error is
```
Can't locate Switch.pm in @INC (you may need to install the Switch module) (@INC contains: /usr/lib/perl5/site_perl /usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper.pl line 23. BEGIN failed--compilation aborted at /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper.pl line 23.
```
```
cpan install Switch
```
solved it, but it is not packaged in the repo
- [x] create ``perl-Switch`` package

--------
now i get
```
DBI connect('dbname=/var/lib/x2go/x2go_sessions','',...) failed: unable to open database file at /usr/share/perl5/vendor_perl/X2Go/Server/DB/SQLite3.pm line 66.
```
following https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1063
```
➜ x2golistsessions
DBIconnect('dbname=/var/lib/x2go/x2go_sessions','',...)failed:unabletoopendatabasefileat/usr/share/perl5/vendor_perl/X2Go/Server/DB/SQLite3.pmline66.
```

Fix with
```
chmod g+s /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper
chown root:x2gouser /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper
```
See https://www.cvedetails.com/cve/CVE-2013-4376/

Note : useless reverse engineering, in the ``INSTALL`` file...
```

3.) SGID GROUP
--------------
Configure ownership, permissions and setgid group bits of
libx2go-server-db-sqlite3-wrapper and x2goprint:

  NOTE: The described actions have already been performed by the Makefile
  run, leaving this here for documentation only.

 $ chown root:x2gouser /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper
 $ chmod 2755 /usr/lib/x2go/libx2go-server-db-sqlite3-wrapper

 $ chown root:x2goprint /usr/bin/x2goprint
 $ chmod 2755 /usr/bin/x2goprint

 $ chown 0440 /etc/sudoers.d/x2goserver
```
During the build the ``x2gouser`` group doesn't exist
```
➜ ./xbps-src install x2goserver
[...]
➜ sudo chroot masterdir /bin/bash
bash-5.1# getent group x2gouser
bash-5.1# 
```
It seems that the test fo the group ``x2gouser`` during the build phase fails : https://github.com/eugenesan/x2goserver/blob/master/libx2go-server-db-perl/Makefile#L58
```
	getent group x2gouser &>/dev/null && chown root:x2gouser $(DESTDIR)$(LIBDIR)/libx2go-server-db-sqlite3-wrapper || true
```
- [x] add ``INSTALL`` file to automate this

--------
Check spec to see if missing deps: https://github.com/eugenesan/x2goserver/blob/master/x2goserver.spec
- [x] which
- [x] pwgen
- [x] net-tools
- [x] perl-Try-Tiny
- [x] perl-Switch 

--------
Now i get
```
Échec de la connexion xauth: file /home/user/.Xauthority does not exist xauth: (argv):1: bad display name "voidlinux:50" in "add" command Failed to start X2Go Agent session with ID user-50-1620685786_stDxterm_dp32. X2Go Agent terminated unexpectedly. Aborting session startup.
```