From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] x2goserver and nx-libs fixed
Date: Tue, 11 May 2021 21:52:37 +0200 [thread overview]
Message-ID: <20210511195237.ubL9MNE0ZJO55MkbIM_Ny-EEfYKZF3uiqaqgaEiaczc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30805@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/30805#discussion_r630472252
Comment:
This whole block can be removed:
1. Patching the Makefiles is probably not necessary, since the only reference is `PREFIX ?= /usr/local`. This is probably only used during install time, and the build style already sets `PREFIX=/usr` for you.
2. If some of the variables (`BINDIR`, `SBINDIR`, `LIBDIR`, `MANDIR` or `SHAREDIR`) in these makefiles are used at build time, then you should just do `make_build_args="PREFIX=/usr"`. Build first without patching or setting this variable and see if any of the products contain references to `/usr/local`. If so, use `make_build_args`.
3. `x2goterminate-desktopsharing` does not need to be patched, since the script uses `type -p` to find `pidof` first, which will do the right thing provided that `pidof` exists.
4. Do not patch the manual pages, they reference possible paths rather than refer incorrectly to `/usr/local`.
next prev parent reply other threads:[~2021-05-11 19:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 18:54 [PR PATCH] " eoli3n
2021-05-11 18:59 ` eoli3n
2021-05-11 19:01 ` eoli3n
2021-05-11 19:14 ` [PR PATCH] [Updated] " eoli3n
2021-05-11 19:52 ` [PR REVIEW] " ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford
2021-05-11 19:52 ` ahesford [this message]
2021-05-11 19:58 ` eoli3n
2021-05-11 20:01 ` eoli3n
2021-05-11 20:09 ` eoli3n
2021-05-11 20:10 ` ahesford
2021-05-11 20:18 ` eoli3n
2021-05-11 20:18 ` eoli3n
2021-05-11 20:41 ` eoli3n
2021-05-11 21:05 ` eoli3n
2021-05-11 21:07 ` eoli3n
2021-05-11 21:13 ` eoli3n
2021-05-11 21:41 ` ahesford
2021-05-11 21:41 ` eoli3n
2021-05-11 21:42 ` eoli3n
2021-05-11 21:42 ` ahesford
2021-05-11 21:44 ` eoli3n
2021-05-11 21:45 ` eoli3n
2021-05-11 22:15 ` [PR PATCH] [Updated] " eoli3n
2021-05-11 22:16 ` [PR REVIEW] " eoli3n
2021-05-11 22:16 ` ahesford
2021-05-11 22:18 ` ahesford
2021-05-11 22:20 ` [PR PATCH] [Updated] " eoli3n
2021-05-11 22:21 ` eoli3n
2021-05-11 22:23 ` eoli3n
2021-05-11 22:28 ` [PR PATCH] [Updated] " eoli3n
2021-05-11 23:48 ` ahesford
2021-05-11 23:55 ` ahesford
2021-05-12 7:43 ` [PR PATCH] [Updated] " eoli3n
2021-05-12 8:23 ` eoli3n
2021-05-12 8:24 ` eoli3n
2021-05-12 13:58 ` [PR PATCH] [Updated] " ahesford
2021-05-12 13:58 ` ahesford
2021-05-12 20:16 ` eoli3n
2021-05-24 2:30 ` ahesford
2021-05-24 9:03 ` eoli3n
2021-05-27 9:01 ` eoli3n
2021-05-31 20:27 ` ahesford
2021-05-31 22:19 ` eoli3n
2021-05-31 23:01 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511195237.ubL9MNE0ZJO55MkbIM_Ny-EEfYKZF3uiqaqgaEiaczc@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).