Re: [PR PATCH] [Updated] [WIP] New package: Vieb-4.5.1

[FollieHiyuki <FollieHiyuki@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages vieb
https://github.com/void-linux/void-packages/pull/30935

[WIP] New package: Vieb-4.5.1
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I got error when launching vieb:
```
fish: Job 1, 'vieb' terminated by signal SIGSEGV (Address boundary error)
```

I have 0 knowledge about Electron, so I don't know how to fix.


A patch file from https://github.com/void-linux/void-packages/pull/30935.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vieb-30935.patch --]
[-- Type: text/x-diff, Size: 2877 bytes --]

From fcff65c81455bef0e008e41a8da9a40c0be5deac Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Sun, 16 May 2021 18:59:50 +0300
Subject: [PATCH] New package: Vieb-4.5.1

---
 srcpkgs/Vieb/files/vieb         |  2 ++
 srcpkgs/Vieb/files/vieb.desktop | 10 ++++++++
 srcpkgs/Vieb/template           | 44 +++++++++++++++++++++++++++++++++
 3 files changed, 56 insertions(+)
 create mode 100755 srcpkgs/Vieb/files/vieb
 create mode 100644 srcpkgs/Vieb/files/vieb.desktop
 create mode 100644 srcpkgs/Vieb/template

diff --git a/srcpkgs/Vieb/files/vieb b/srcpkgs/Vieb/files/vieb
new file mode 100755
index 000000000000..360014a83973
--- /dev/null
+++ b/srcpkgs/Vieb/files/vieb
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec electron12 /usr/lib/vieb.asar "$@"
diff --git a/srcpkgs/Vieb/files/vieb.desktop b/srcpkgs/Vieb/files/vieb.desktop
new file mode 100644
index 000000000000..5a5dcc71e220
--- /dev/null
+++ b/srcpkgs/Vieb/files/vieb.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Vieb
+Exec=vieb
+Terminal=false
+Type=Application
+Icon=vieb
+StartupWMClass=Vieb
+Comment=Vim Inspired Electron Browser
+MimeType=x-scheme-handler/ftp;x-scheme-handler/http;x-scheme-handler/https;
+Categories=Network;WebBrowser;
diff --git a/srcpkgs/Vieb/template b/srcpkgs/Vieb/template
new file mode 100644
index 000000000000..8b3b37d3c579
--- /dev/null
+++ b/srcpkgs/Vieb/template
@@ -0,0 +1,44 @@
+# Template file for 'Vieb'
+pkgname=Vieb
+version=4.5.1
+revision=1
+_electron_ver=12
+hostmakedepends="yarn nodejs python3 pkg-config app-builder libnotify-devel"
+makedepends="electron${_electron_ver}"
+depends="electron${_electron_ver} c-ares ffmpeg gtk+3 http-parser libevent
+ libvpx6 libxslt minizip nss re2 snappy"
+short_desc="Vim inspired Electron browser"
+maintainer="FollieHiyuki <folliekazetani@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://vieb.dev/"
+distfiles="https://github.com/Jelmerro/Vieb/archive/${version}.tar.gz"
+checksum=cc0bdb19769f012bf3b7ebd41c85dcef6a38a50caf770f713874bdf529f0c917
+
+export USE_SYSTEM_APP_BUILDER=true
+
+do_configure() {
+	yarn install
+	local carch=x64
+	case "$XBPS_TARGET_MACHINE" in
+		i686*) carch=ia32 ;;
+	esac
+	npm_config_arch=$carch \
+		yarn upgrade electron@"$(</usr/lib/electron${_electron_ver}/version)" \
+			--non-interactive
+}
+
+do_build() {
+	export NODE_ENV=production
+	yarn run electron-builder --linux --x64 --dir \
+		-c.electronDist=/usr/lib/electron${_electron_ver} \
+		-c.electronVersion="$(</usr/lib/electron${_electron_ver}/version)"
+}
+
+do_install() {
+	vinstall "${FILESDIR}/vieb.desktop" 644 usr/share/applications
+	vbin "${FILESDIR}/vieb"
+	for i in 16 24 48 64 96 128 256 512 1024; do
+		vinstall ${wrksrc}/app/img/icons/${i}x${i}.png 644 /usr/share/icons/hicolor/${i}x${i}/apps/ vieb.png
+	done
+	vinstall "dist/linux-unpacked/resources/app.asar" 644 /usr/lib vieb.asar
+}