Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: font-jetbrains-mono-2.225
@ 2021-05-24 14:28 gbrlsnchs
  2021-05-24 14:33 ` ahesford
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-05-24 14:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

There is a new pull request by gbrlsnchs against master on the void-packages repository

https://github.com/gbrlsnchs/void-packages font-jetbrains-mono
https://github.com/void-linux/void-packages/pull/31086

New package: font-jetbrains-mono-2.225
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31086.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-jetbrains-mono-31086.patch --]
[-- Type: text/x-diff, Size: 1296 bytes --]

From 17736c078bd76ee500d748b1eb3c8fd0db607dd7 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Fri, 9 Apr 2021 15:00:51 -0300
Subject: [PATCH] New package: font-jetbrains-mono-2.225

---
 srcpkgs/font-jetbrains-mono/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/font-jetbrains-mono/template

diff --git a/srcpkgs/font-jetbrains-mono/template b/srcpkgs/font-jetbrains-mono/template
new file mode 100644
index 000000000000..5fa1fa7b3560
--- /dev/null
+++ b/srcpkgs/font-jetbrains-mono/template
@@ -0,0 +1,23 @@
+# Template file for 'font-jetbrains-mono'
+pkgname=font-jetbrains-mono
+version=2.225
+revision=1
+wrksrc="JetBrainsMono-${version}"
+create_wrksrc=yes
+depends="font-util"
+short_desc="JetBrains's free and open-source typeface for developers"
+maintainer="Gabriel Sanches <gabriel@gsr.dev>"
+license="OFL-1.1"
+homepage="https://jetbrains.com/mono"
+distfiles="https://github.com/JetBrains/JetBrainsMono/releases/download/v${version}/JetBrainsMono-${version}.zip"
+checksum=03b2e2c0e3285703a204b6efbe2d277bf568e0bb53a395e9f4e74e9b77c4aeb2
+font_dirs="/usr/share/fonts/TTF"
+
+do_install() {
+	vmkdir usr/share/fonts/TTF
+	vcopy fonts/ttf/*.ttf usr/share/fonts/TTF
+}
+
+post_install() {
+	vlicense OFL.txt
+}

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: font-jetbrains-mono-2.225
  2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
@ 2021-05-24 14:33 ` ahesford
  2021-05-24 14:45 ` gbrlsnchs
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-05-24 14:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31086#issuecomment-847083667

Comment:
From the quality requirements:
> New fonts may be accepted if they provide value beyond aesthetics (e.g. they contain glyphs for a script missing in already packaged fonts).

What's your argument in favor of this font? (Code ligatures fall in the "aesthetics" category.)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: font-jetbrains-mono-2.225
  2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
  2021-05-24 14:33 ` ahesford
@ 2021-05-24 14:45 ` gbrlsnchs
  2021-05-24 14:49 ` ahesford
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-05-24 14:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/31086#issuecomment-847091045

Comment:
It's a pretty popular programming font. I am basing my argument mostly on [GitHub stars](https://github.com/JetBrains/JetBrainsMono/stargazers). Also, it's made by JetBrains, making it even more popular and well maintained.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: font-jetbrains-mono-2.225
  2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
  2021-05-24 14:33 ` ahesford
  2021-05-24 14:45 ` gbrlsnchs
@ 2021-05-24 14:49 ` ahesford
  2021-05-24 14:49 ` [PR PATCH] [Closed]: " ahesford
  2021-05-24 14:50 ` gbrlsnchs
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-05-24 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31086#issuecomment-847093815

Comment:
Fonts can be installed per-user by copying into `~/.fonts` with the default configuration.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: New package: font-jetbrains-mono-2.225
  2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
                   ` (2 preceding siblings ...)
  2021-05-24 14:49 ` ahesford
@ 2021-05-24 14:49 ` ahesford
  2021-05-24 14:50 ` gbrlsnchs
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2021-05-24 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

There's a closed pull request on the void-packages repository

New package: font-jetbrains-mono-2.225
https://github.com/void-linux/void-packages/pull/31086

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: New package: font-jetbrains-mono-2.225
  2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
                   ` (3 preceding siblings ...)
  2021-05-24 14:49 ` [PR PATCH] [Closed]: " ahesford
@ 2021-05-24 14:50 ` gbrlsnchs
  4 siblings, 0 replies; 6+ messages in thread
From: gbrlsnchs @ 2021-05-24 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/31086#issuecomment-847094674

Comment:
Sure, no problem. Thanks for reviewing.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-24 14:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 14:28 [PR PATCH] New package: font-jetbrains-mono-2.225 gbrlsnchs
2021-05-24 14:33 ` ahesford
2021-05-24 14:45 ` gbrlsnchs
2021-05-24 14:49 ` ahesford
2021-05-24 14:49 ` [PR PATCH] [Closed]: " ahesford
2021-05-24 14:50 ` gbrlsnchs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).