Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [WIP] New package: onivim2-0.5.5
@ 2021-05-23  8:32 kawaiiamber
  2021-05-23 11:55 ` FollieHiyuki
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-23  8:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]

There is a new pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[skip ci]

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1577 bytes --]

From 5022034ae4d8b3c63dc40dd77990e8649df0f21e Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..a7d4eb48b498
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,38 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+# No pkg for esy, so installing in this template
+hostmakedepends="nodejs git nasm m4 ragel"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+
+do_configure() {
+	npm install -g esy
+	npm install -g node-gyp
+	node-gyp install 14.15.4
+	node install-node-deps.js
+}
+
+do_build() {
+	esy install
+	esy bootstrap
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense ThirdPartyLicenses.txt
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
@ 2021-05-23 11:55 ` FollieHiyuki
  2021-05-23 16:17 ` F0Xde
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: FollieHiyuki @ 2021-05-23 11:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846550956

Comment:
It's nonfree so put it into `restricted`. And use `yarn` for safety purpose :)

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
  2021-05-23 11:55 ` FollieHiyuki
@ 2021-05-23 16:17 ` F0Xde
  2021-05-23 16:33 ` ericonr
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: F0Xde @ 2021-05-23 16:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by F0Xde on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846588126

Comment:
Alternatively the [MIT licensed version](https://github.com/onivim/oni2-mit) could be used, which would always be 1.5 years behind :(

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
  2021-05-23 11:55 ` FollieHiyuki
  2021-05-23 16:17 ` F0Xde
@ 2021-05-23 16:33 ` ericonr
  2021-05-23 17:04 ` FollieHiyuki
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2021-05-23 16:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846590334

Comment:
Nonfree doesn't necessarily mean restricted, just `repository=nonfree`. We use restricted if, besides being nonfree, the package can't be distributed.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (2 preceding siblings ...)
  2021-05-23 16:33 ` ericonr
@ 2021-05-23 17:04 ` FollieHiyuki
  2021-05-23 23:51 ` kawaiiamber
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: FollieHiyuki @ 2021-05-23 17:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846594328

Comment:
From the EULA:

> You shall use the Software strictly in accordance with the terms of this Agreement and shall not: (a) distribute the Software (b) make the Software available over a network or other environment permitting access or use by multiple users at the same time; (c) violate any applicable laws, rules, or regulations in connection with Your access or use of the Software; (d) use the Software for any revenue generating endeavor, commercial enterprise, employment, or other purpose for which it is not designed or intended; (e) remove proprietary notices from the Software or the Documentation.

If I understand correctly this should go to `restricted`.

I agree with @F0Xde. The safer route is to use the MIT version, but that defeat the point of packaging it due to the fact that it will be 18 months behind development.


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (3 preceding siblings ...)
  2021-05-23 17:04 ` FollieHiyuki
@ 2021-05-23 23:51 ` kawaiiamber
  2021-05-23 23:54 ` kawaiiamber
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-23 23:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846645911

Comment:
Oh wow. I wasn't aware that onivim2 also copies the bad licensing practices from vs code, too. It's a shame that in order to distribute this software you must use a one and a half year old version at the very least. Onivim seemed pretty cool, it's a shame upstream seems to be anti-freedom in that sense, though. I don't want to make a template for a version over a year old, so I guess I'll update the template to be restricted when I get back home - RIP

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (4 preceding siblings ...)
  2021-05-23 23:51 ` kawaiiamber
@ 2021-05-23 23:54 ` kawaiiamber
  2021-05-23 23:55 ` kawaiiamber
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-23 23:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846645911

Comment:
Oh wow. I wasn't aware that onivim2 also copies the bad licensing practices from vs code, too. It's a shame that in order to distribute this software you must use a one and a half year old version at the very least. Onivim seemed pretty cool, it's a shame upstream seems to be anti-freedom in that sense, though. I don't want to make a template for a version over a year old, so I guess I'll update the template to be restricted when I get back home - RIP

Since onivim2 doesn't allow distribution, does this mean the AUR is in license violation as it pulls from the current repo, not the mit one? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=onivim2

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (5 preceding siblings ...)
  2021-05-23 23:54 ` kawaiiamber
@ 2021-05-23 23:55 ` kawaiiamber
  2021-05-24  0:00 ` kawaiiamber
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-23 23:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846645911

Comment:
Oh wow. I wasn't aware that onivim2 also copies the bad licensing practices from vs code, too. It's a shame that in order to distribute this software you must use a one-and-a-half-year-old version at the very least. Onivim seemed pretty cool, it's a shame upstream seems to be anti-freedom in that sense, though. I don't want to make a template for a version over a year old, so I guess I'll update the template to be restricted when I get back home - RIP

Since onivim2 doesn't allow distribution, does this mean the AUR is in license violation as it pulls from the current repo, not the mit one? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=onivim2

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (6 preceding siblings ...)
  2021-05-23 23:55 ` kawaiiamber
@ 2021-05-24  0:00 ` kawaiiamber
  2021-05-24 11:38 ` kawaiiamber
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-24  0:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846647427

Comment:
> It's nonfree so put it into `restricted`. And use `yarn` for safety purpose :)

Use `yarn`? As apposed to something else currently being used in the template? I'm not too familiar with it.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (7 preceding siblings ...)
  2021-05-24  0:00 ` kawaiiamber
@ 2021-05-24 11:38 ` kawaiiamber
  2021-05-24 11:45 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-24 11:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846984679

Comment:
I believe there may have been a mix of words. The template will be updated to be restricted. `nonfree` refers to proprietary source code, not proprietary license. The project itself only contains open source code as far as I know and is built from source.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (8 preceding siblings ...)
  2021-05-24 11:38 ` kawaiiamber
@ 2021-05-24 11:45 ` kawaiiamber
  2021-05-24 11:46 ` kawaiiamber
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-24 11:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[ci skip]

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1606 bytes --]

From fc5722c993d6e9fe7cf78b97d10b138892fb2a0f Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..5313c741dfc2
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,39 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+hostmakedepends="nodejs git nasm m4 ragel yarn"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom:Outrun-Lans-EULA"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+# proprietary license
+restricted=yes
+
+do_configure() {
+	npm install -g node-gyp
+	node-gyp install 14.15.4
+	node install-node-deps.js
+}
+
+do_build() {
+	yarn install
+	yarn bootstrap
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense Outrun-Labs-EULA-v1.1.md
+	vlicense ThirdPartyLicenses.txt
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (9 preceding siblings ...)
  2021-05-24 11:45 ` [PR PATCH] [Updated] " kawaiiamber
@ 2021-05-24 11:46 ` kawaiiamber
  2021-05-24 11:58 ` kawaiiamber
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-24 11:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846988698

Comment:
I assume @FollieHiyuki meant to replace `esy` with `yarn` as there's no package for `esy`? I've done that and updated to be restricted due to proprietary license. Do I need to `vlicense` the Third Party Licenses, as well?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (10 preceding siblings ...)
  2021-05-24 11:46 ` kawaiiamber
@ 2021-05-24 11:58 ` kawaiiamber
  2021-05-24 15:49 ` FollieHiyuki
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-24 11:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-846993878

Comment:
> Alternatively the [MIT licensed version](https://github.com/onivim/oni2-mit) could be used, which would always be 1.5 years behind :(

It looks like that repo doesn't have any releases / tags, unfortunately, or a `onivim2-mit` package could also be added.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (11 preceding siblings ...)
  2021-05-24 11:58 ` kawaiiamber
@ 2021-05-24 15:49 ` FollieHiyuki
  2021-05-25  0:32 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: FollieHiyuki @ 2021-05-24 15:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-847140379

Comment:
@kawaiiamber what I meant was to use `yarn` instead of `npm`.

Packaging the MIT code is a bad idea. It will have no security fixes, etc. It is just the 1.5 years behind snapshot of the main code base with the license changed. So ... the licensing model is worse then Vscode :(

> Since onivim2 doesn't allow distribution, does this mean the AUR is in license violation as it pulls from the current repo, not the mit one? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=onivim2

The AUR and our `restricted` packages doesn't provide binaries or the source code. They only have the build instructions, and the users are the ones pulling the source themselves. So it is not a violation.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (12 preceding siblings ...)
  2021-05-24 15:49 ` FollieHiyuki
@ 2021-05-25  0:32 ` kawaiiamber
  2021-05-25  0:33 ` kawaiiamber
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-25  0:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

[ci skip]

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1601 bytes --]

From 7a34c5bd74b8646683254d3a300c723d3016674d Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..7d138c1fd28b
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,40 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+hostmakedepends="nodejs git nasm m4 ragel yarn curl tar"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom:Outrun-Lans-EULA"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+# proprietary license
+restricted=yes
+
+do_configure() {
+	yarn install esy
+	yarn node-gyp
+	node-gyp install 14.15.4
+	yarn install-node-deps.js
+}
+
+do_build() {
+	esy install
+	esy bootstrap
+	esy build
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense Outrun-Labs-EULA-v1.1.md
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (13 preceding siblings ...)
  2021-05-25  0:32 ` [PR PATCH] [Updated] " kawaiiamber
@ 2021-05-25  0:33 ` kawaiiamber
  2021-05-25  0:35 ` [PR PATCH] [Updated] " kawaiiamber
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-25  0:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-847444716

Comment:
Updated to use `yarn` over `npm`. Adding `curl` and `tar` to `hostmakedepends` fixed some build errors.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (14 preceding siblings ...)
  2021-05-25  0:33 ` kawaiiamber
@ 2021-05-25  0:35 ` kawaiiamber
  2021-05-25  0:41 ` kawaiiamber
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-25  0:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]

From 08d6dddcc71ea7244c113ba5eb1131aabe9aebc8 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..d482875cac36
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,40 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+hostmakedepends="git nasm m4 ragel yarn curl tar"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom:Outrun-Lans-EULA"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+# proprietary license
+restricted=yes
+
+do_configure() {
+	yarn install esy
+	yarn node-gyp
+	node-gyp install 14.15.4
+	yarn install-node-deps.js
+}
+
+do_build() {
+	esy install
+	esy bootstrap
+	esy build
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense Outrun-Labs-EULA-v1.1.md
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (15 preceding siblings ...)
  2021-05-25  0:35 ` [PR PATCH] [Updated] " kawaiiamber
@ 2021-05-25  0:41 ` kawaiiamber
  2022-05-20  2:12 ` github-actions
  2022-06-18  2:12 ` [PR PATCH] [Closed]: " github-actions
  18 siblings, 0 replies; 20+ messages in thread
From: kawaiiamber @ 2021-05-25  0:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]

From 7d703ead2a24620ff6132d47283fff0ffb7132aa Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..42c0942059fe
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,40 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+hostmakedepends="git nasm m4 ragel yarn curl tar"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom:Outrun-Lans-EULA"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+# proprietary license
+restricted=yes
+
+do_configure() {
+	yarn add esy
+	yarn add node-gyp
+	node-gyp install 14.15.4
+	yarn install-node-deps.js
+}
+
+do_build() {
+	esy install
+	esy bootstrap
+	esy build
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense Outrun-Labs-EULA-v1.1.md
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (16 preceding siblings ...)
  2021-05-25  0:41 ` kawaiiamber
@ 2022-05-20  2:12 ` github-actions
  2022-06-18  2:12 ` [PR PATCH] [Closed]: " github-actions
  18 siblings, 0 replies; 20+ messages in thread
From: github-actions @ 2022-05-20  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/31076#issuecomment-1132374728

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Closed]: [WIP] New package: onivim2-0.5.5
  2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
                   ` (17 preceding siblings ...)
  2022-05-20  2:12 ` github-actions
@ 2022-06-18  2:12 ` github-actions
  18 siblings, 0 replies; 20+ messages in thread
From: github-actions @ 2022-06-18  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

There's a closed pull request on the void-packages repository

[WIP] New package: onivim2-0.5.5
https://github.com/void-linux/void-packages/pull/31076

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-06-18  2:12 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23  8:32 [PR PATCH] [WIP] New package: onivim2-0.5.5 kawaiiamber
2021-05-23 11:55 ` FollieHiyuki
2021-05-23 16:17 ` F0Xde
2021-05-23 16:33 ` ericonr
2021-05-23 17:04 ` FollieHiyuki
2021-05-23 23:51 ` kawaiiamber
2021-05-23 23:54 ` kawaiiamber
2021-05-23 23:55 ` kawaiiamber
2021-05-24  0:00 ` kawaiiamber
2021-05-24 11:38 ` kawaiiamber
2021-05-24 11:45 ` [PR PATCH] [Updated] " kawaiiamber
2021-05-24 11:46 ` kawaiiamber
2021-05-24 11:58 ` kawaiiamber
2021-05-24 15:49 ` FollieHiyuki
2021-05-25  0:32 ` [PR PATCH] [Updated] " kawaiiamber
2021-05-25  0:33 ` kawaiiamber
2021-05-25  0:35 ` [PR PATCH] [Updated] " kawaiiamber
2021-05-25  0:41 ` kawaiiamber
2022-05-20  2:12 ` github-actions
2022-06-18  2:12 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).