Github messages for voidlinux
 help / color / mirror / Atom feed
From: kawaiiamber <kawaiiamber@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [WIP] New package: onivim2-0.5.5
Date: Tue, 25 May 2021 02:35:09 +0200	[thread overview]
Message-ID: <20210525003509.aMCvDX3_BiOTCHQjZVBDEYXO0k4iw0vRiaAhEykhpnU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31076@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages onivim2
https://github.com/void-linux/void-packages/pull/31076

[WIP] New package: onivim2-0.5.5
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

I tried to put together a template based off of the build instructions from upstream and looking at the AUR PKGBUILD. At the moment the build fails at `node install-node-deps.js` in `do_configure`. I noticed there's no `esy` package, so I had it install in `do_configure` with `npm` from `nodejs` package to test build. Not too sure if I did licensing correctly, was no `COPYING` or `NOTICE` or `LICENSE` file or mention of it in `README.md`. So, just did `vlicense` on `ThirdPartyLicenses.txt`. Upstream build and install instructions don't seem to actually tell how to install. Only states that once it's built, can be ran by `esy run`.

A patch file from https://github.com/void-linux/void-packages/pull/31076.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-onivim2-31076.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]

From 08d6dddcc71ea7244c113ba5eb1131aabe9aebc8 Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 23 May 2021 02:27:47 -0600
Subject: [PATCH] New package: onivim2-0.5.5

---
 srcpkgs/onivim2/template | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 srcpkgs/onivim2/template

diff --git a/srcpkgs/onivim2/template b/srcpkgs/onivim2/template
new file mode 100644
index 000000000000..d482875cac36
--- /dev/null
+++ b/srcpkgs/onivim2/template
@@ -0,0 +1,40 @@
+# Template file for 'onivim2'
+pkgname=onivim2
+version=0.5.5
+revision=1
+wrksrc="oni2-${version}"
+hostmakedepends="git nasm m4 ragel yarn curl tar"
+makedepends="libpng-devel bzip2-devel xorg-server-devel glu-devel
+ harfbuzz-devel libXext-devel fontconfig-devel libXrandr-devel libXi-devel
+ libXcursor-devel libXinerama-devel libXxf86vm-devel"
+short_desc="Native, lightweight modal code editor"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="custom:Outrun-Lans-EULA"
+homepage="https://v2.onivim.io"
+distfiles="https://github.com/onivim/oni2/archive/refs/tags/v${version}.tar.gz"
+checksum=a73112c447a6747fc407784d017270a7fd83c13e8b8be9f0ea953316ba2dc76d
+# proprietary license
+restricted=yes
+
+do_configure() {
+	yarn install esy
+	yarn node-gyp
+	node-gyp install 14.15.4
+	yarn install-node-deps.js
+}
+
+do_build() {
+	esy install
+	esy bootstrap
+	esy build
+}
+
+do_install() {
+	# Not sure how to install yet
+	# pass as : to allow testing of build
+	:
+}
+
+post_install() {
+	vlicense Outrun-Labs-EULA-v1.1.md
+}

  parent reply	other threads:[~2021-05-25  0:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23  8:32 [PR PATCH] " kawaiiamber
2021-05-23 11:55 ` FollieHiyuki
2021-05-23 16:17 ` F0Xde
2021-05-23 16:33 ` ericonr
2021-05-23 17:04 ` FollieHiyuki
2021-05-23 23:51 ` kawaiiamber
2021-05-23 23:54 ` kawaiiamber
2021-05-23 23:55 ` kawaiiamber
2021-05-24  0:00 ` kawaiiamber
2021-05-24 11:38 ` kawaiiamber
2021-05-24 11:45 ` [PR PATCH] [Updated] " kawaiiamber
2021-05-24 11:46 ` kawaiiamber
2021-05-24 11:58 ` kawaiiamber
2021-05-24 15:49 ` FollieHiyuki
2021-05-25  0:32 ` [PR PATCH] [Updated] " kawaiiamber
2021-05-25  0:33 ` kawaiiamber
2021-05-25  0:35 ` kawaiiamber [this message]
2021-05-25  0:41 ` [PR PATCH] [Updated] " kawaiiamber
2022-05-20  2:12 ` github-actions
2022-06-18  2:12 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525003509.aMCvDX3_BiOTCHQjZVBDEYXO0k4iw0vRiaAhEykhpnU@z \
    --to=kawaiiamber@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).