Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: kdepim-addons 21.04.0
Date: Thu, 27 May 2021 22:12:26 +0200	[thread overview]
Message-ID: <20210527201226.YD6QNF_m4FuKgC-iWl6wWF9lagALaPTv4JQp9-syW64@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30798@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/30798#discussion_r640934285

Comment:
Best to work it out with upstream, things like below have potential to make people sad.

```diff
@@ -209,11 +181,7 @@
             },
             "departureDay": "2016-06-10",
             "departureTerminal": "2F",
-            "departureTime": {
-                "@type": "QDateTime",
-                "@value": "2016-06-10T13:00:00+02:00",
-                "timezone": "Europe/Paris"
-            },
+            "departureTime": "2016-06-10T13:00:00",
             "flightNumber": "8680"
         },
         "reservationNumber": "123456",
FAIL!  : ExtractorTest::testExtract(amadeus-amadeus_1.txt) Compared values are not the same
```

  parent reply	other threads:[~2021-05-27 20:12 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  8:28 [PR PATCH] " DBLouis
2021-05-11 11:56 ` amak79
2021-05-11 12:09 ` DBLouis
2021-05-11 12:17 ` DBLouis
2021-05-11 12:23 ` amak79
2021-05-13 12:44 ` Johnnynator
2021-05-14  9:39 ` [PR PATCH] [Updated] " DBLouis
2021-05-14  9:47 ` DBLouis
2021-05-14 11:57 ` DBLouis
2021-05-14 18:57 ` Johnnynator
2021-05-15  5:40 ` DBLouis
2021-05-15 11:19 ` [PR REVIEW] " Johnnynator
2021-05-15 12:25 ` DBLouis
2021-05-15 12:31 ` Johnnynator
2021-05-16  6:29 ` [PR PATCH] [Updated] " DBLouis
2021-05-16  6:29 ` [PR REVIEW] " DBLouis
2021-05-16  6:33 ` [PR PATCH] [Updated] " DBLouis
2021-05-17  6:55 ` DBLouis
2021-05-17 20:21 ` [PR REVIEW] " Chocimier
2021-05-17 20:21 ` Chocimier
2021-05-18  7:39 ` [PR PATCH] [Updated] " DBLouis
2021-05-23  8:58 ` DBLouis
2021-05-23  9:50 ` [PR REVIEW] " DBLouis
2021-05-23 13:28 ` paper42
2021-05-24  6:24 ` Chocimier
2021-05-25  4:35 ` DBLouis
2021-05-27 20:12 ` Chocimier [this message]
2021-05-29  9:24 ` DBLouis
2021-05-29 10:17 ` Chocimier
2021-12-05 16:05 ` [PR PATCH] [Updated] " DBLouis
2021-12-05 16:08 ` DBLouis
2021-12-05 16:09 ` [PR PATCH] [Updated] New package: kdepim-addons 21.08.3 DBLouis
2021-12-05 20:45 ` DBLouis
2021-12-05 20:56 ` DBLouis
2021-12-05 21:46 ` DBLouis
2021-12-06 11:19 ` [PR PATCH] [Updated] " DBLouis
2021-12-09 21:39 ` DBLouis
2021-12-09 21:42 ` DBLouis
2021-12-10  9:53 ` [PR REVIEW] " Johnnynator
2021-12-10  9:56 ` Johnnynator
2021-12-10 19:27 ` [PR PATCH] [Updated] " DBLouis
2021-12-10 19:29 ` DBLouis
2021-12-11  8:39 ` DBLouis
2021-12-11 23:35 ` [PR PATCH] [Updated] " Johnnynator
2021-12-11 23:37 ` Johnnynator
2021-12-13 13:59 ` [PR PATCH] [Closed]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527201226.YD6QNF_m4FuKgC-iWl6wWF9lagALaPTv4JQp9-syW64@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).