From: ailiop-git <ailiop-git@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: iptables: adjust run scripts for more configuration flexibility
Date: Fri, 28 May 2021 11:00:19 +0200 [thread overview]
Message-ID: <20210528090019.qnd0T5hvr52-PTc4WBz3J8KnvS-6PwtZy8vS0lK38JU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31145@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
New comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/pull/31145#issuecomment-850267277
Comment:
> > The variable should probably be named 'fragment' and in general I think there's also a case here in the fragment case that isn't being checked, which is that if iptables-restore fails for any fragment that should abort the load.
>
> `iptables-restore file || exit 1` should do just that (unless I misunderstood something).
We probably also need to flush everything in case a fragment fails, since it may leave the ruleset in an undesirable state, and also subsequent sv starts/restores will end up duplicating ruleset entries.
next prev parent reply other threads:[~2021-05-28 9:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 4:29 [PR PATCH] " heliocat
2021-05-27 4:30 ` heliocat
2021-05-27 4:39 ` [PR PATCH] [Updated] " heliocat
2021-05-27 4:44 ` [PR REVIEW] " the-maldridge
2021-05-27 4:44 ` the-maldridge
2021-05-27 4:44 ` the-maldridge
2021-05-27 4:54 ` [PR PATCH] [Updated] " heliocat
2021-05-27 4:54 ` [PR REVIEW] " heliocat
2021-05-27 4:55 ` [PR PATCH] [Updated] " heliocat
2021-05-27 4:58 ` [PR REVIEW] " heliocat
2021-05-27 4:58 ` heliocat
2021-05-27 5:02 ` [PR PATCH] [Updated] " heliocat
2021-05-27 5:07 ` heliocat
2021-05-27 11:20 ` ailiop-git
2021-05-27 11:24 ` ailiop-git
2021-05-27 17:42 ` heliocat
2021-05-27 22:26 ` heliocat
2021-05-28 7:27 ` the-maldridge
2021-05-28 7:30 ` heliocat
2021-05-28 7:32 ` heliocat
2021-05-28 9:00 ` ailiop-git [this message]
2021-05-28 18:31 ` heliocat
2021-06-07 15:48 ` heliocat
2021-06-10 4:38 ` [PR PATCH] [Updated] " heliocat
2021-06-18 6:25 ` heliocat
2022-05-20 2:12 ` github-actions
2022-06-04 2:08 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528090019.qnd0T5hvr52-PTc4WBz3J8KnvS-6PwtZy8vS0lK38JU@z \
--to=ailiop-git@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).