From: reback00 <reback00@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: goocanvas: update to 3.0.0
Date: Fri, 28 May 2021 12:50:28 +0200 [thread overview]
Message-ID: <20210528105028.DKt5KmdtjoPqgkGTcfin8Ln18tkKRiL4izuR2Xe4ZmY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31159@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/31159#issuecomment-850332099
Comment:
I see. I just tried on my machine for updating my package for [akira](https://notabug.org/reback00/void-goodies/src/master/srcpkgs/akira). It worked so thought of committing the changes. Didn't know it has so many things attached to it.
Arch Linux has recently moved to goocanvas 3. I think I got some hints. Arch's `perl-goocanvas2` has had [these changes](https://github.com/archlinux/svntogit-community/commit/18f64b84269d2eab6ad8005b5997fe22e1d691e5#diff-3e341d2d9c67be01819b25b25d5e53ea3cdf3a38d28846cda85a195eb9b7203a) for updating to goocanvas 3. Mainly a sed line is needed. So we can have something like this:
```
pre_configure() {
# For adapting to goocanvas 3.0
sed -i "s/version => '2.0'/version => '3.0'/" lib/GooCanvas2.pm
}
```
[`gpredict`](https://aur.archlinux.org/packages/gpredict) and [`gpredict-git`](https://aur.archlinux.org/packages/gpredict-git/) haven't been updated for years, so we'd have to solve it ourselves. I've looked into `gpredict` source tree for `goocanvas` references and I found the most prominent instance in `configure`:
```
if pkg-config --atleast-version=2.0 goocanvas-2.0; then
CFLAGS="$CFLAGS `pkg-config --cflags goocanvas-2.0`"
LIBS="$LIBS `pkg-config --libs goocanvas-2.0`"
else
as_fn_error $? "Gpredict requires libgoocanvas-2.0-dev" "$LINENO" 5
fi
...
GOOC_V=`pkg-config --modversion goocanvas-2.0`
```
`configure.ac` also has similar code. I used [this patch](https://gist.github.com/reback00/b3b0cf8d367d114900b0e2b00f1af37b) to update them. However, changing these to `3.0` shows this message:
```
WARNING: 'aclocal-1.15' is missing on your system.
You should only need it if you modified 'acinclude.m4' or
'configure.ac' or m4 files included by 'configure.ac'.
```
To remedy this, something like this has to be added to template:
```
pre_configure() {
# To allow patched configure files by goocanvas 3 patches
# Details: https://github.com/apereo/mod_auth_cas/issues/97
touch *
}
```
I haven't looked into `gscan2pdf` ( cc @Hoshpak ) but I think it should build fine if `perl-goocanvas2` is updated.
next prev parent reply other threads:[~2021-05-28 10:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 4:30 [PR PATCH] " reback00
2021-05-28 4:50 ` reback00
2021-05-28 7:03 ` newbluemoon
2021-05-28 10:50 ` reback00 [this message]
2021-05-28 10:55 ` reback00
2021-05-28 10:56 ` reback00
2021-05-28 12:17 ` newbluemoon
2021-05-28 12:56 ` newbluemoon
2021-05-28 13:03 ` newbluemoon
2021-05-28 13:13 ` newbluemoon
2021-05-28 13:25 ` newbluemoon
2021-05-28 17:17 ` [PR PATCH] [Updated] " reback00
2021-05-28 17:24 ` reback00
2021-05-28 17:31 ` newbluemoon
2021-05-28 17:37 ` reback00
2021-05-28 17:50 ` newbluemoon
2021-05-28 17:50 ` reback00
2021-05-28 17:55 ` [PR PATCH] [Updated] " reback00
2021-05-28 18:09 ` reback00
2021-05-28 18:16 ` reback00
2022-05-20 2:12 ` github-actions
2022-06-04 2:08 ` [PR PATCH] [Closed]: " github-actions
2022-10-03 1:36 [PR PATCH] " Wesley-Chan
2022-10-03 9:38 ` Wesley-Chan
2022-10-03 11:10 ` classabbyamp
2022-10-03 13:24 ` classabbyamp
2022-10-03 13:24 ` classabbyamp
2022-10-03 13:35 ` Wesley-Chan
2022-10-03 13:47 ` classabbyamp
2023-01-02 1:57 ` github-actions
2023-01-02 5:31 ` newbluemoon
2023-04-04 1:53 ` github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528105028.DKt5KmdtjoPqgkGTcfin8Ln18tkKRiL4izuR2Xe4ZmY@z \
--to=reback00@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).