From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ReText: update to 7.2.1.
Date: Fri, 28 May 2021 21:53:46 +0200 [thread overview]
Message-ID: <20210528195346.WT1XxUaY_xq8-Wx_CCbfNwOq1XfDfSdjwkcJhNnynTI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31121@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 3814 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/31121#discussion_r641785436
Comment:
Doing tests the right way causes python to abort in this case, which is why we want tests that actually run against the stuff we build rather than whatever wheels pip downloads.
```
Fatal Python error: Aborted
Current thread 0x00007fee655f7740 (most recent call first):
File "/builddir/retext-7.2.1/tests/test_editor.py", line 33 in <module>
File "/usr/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 170 in exec_module
File "<frozen importlib._bootstrap>", line 680 in _load_unlocked
File "<frozen importlib._bootstrap>", line 986 in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 1007 in _find_and_load
File "<frozen importlib._bootstrap>", line 1030 in _gcd_import
File "/usr/lib/python3.9/importlib/__init__.py", line 127 in import_module
File "/usr/lib/python3.9/site-packages/_pytest/pathlib.py", line 524 in import_path
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 578 in _importtestmodule
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 500 in _getobj
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 291 in obj
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 516 in _inject_setup_module_fixture
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 503 in collect
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 341 in <lambda>
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 341 in pytest_make_collect_report
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 458 in collect_one_node
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 808 in genitems
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 811 in genitems
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 634 in perform_collect
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 333 in pytest_collection
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 322 in _main
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
File "/usr/bin/pytest", line 33 in <module>
/void-packages/srcpkgs/ReText/template: line 19: 25691 Aborted QT_QPA_PLATFORM=offsreen PYTHONPATH="$(cd build/lib* && pwd)" pytest tests
```
next prev parent reply other threads:[~2021-05-28 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:26 [PR PATCH] " mobinmob
2021-05-26 3:57 ` [PR REVIEW] " ericonr
2021-05-26 9:05 ` mobinmob
2021-05-26 12:14 ` ericonr
2021-05-28 19:53 ` ahesford
2021-05-28 19:53 ` ahesford [this message]
2021-05-29 14:48 ` [PR PATCH] [Updated] " mobinmob
2021-05-29 14:49 ` [PR REVIEW] " mobinmob
2021-06-12 2:17 ` [PR PATCH] [Closed]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528195346.WT1XxUaY_xq8-Wx_CCbfNwOq1XfDfSdjwkcJhNnynTI@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).