Github messages for voidlinux
 help / color / mirror / Atom feed
From: FollieHiyuki <FollieHiyuki@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [WIP] nnn: update to 4.1
Date: Wed, 02 Jun 2021 18:43:32 +0200	[thread overview]
Message-ID: <20210602164332.gG6jFtTO_MLsN2tzuApVP1ylRAVOPJoyoUWT42z5e6Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31261@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

There is an updated pull request by FollieHiyuki against master on the void-packages repository

https://github.com/FollieHiyuki/void-packages nnn-update
https://github.com/void-linux/void-packages/pull/31261

[WIP] nnn: update to 4.1
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

`nnn` now uses fts for disk usage calculation.
They also introduce patching system, and I'm hesitating to include the official git status patch (all we need to do is addding 1 build flag, and `libgit2-devel` to hostmakedepends).
I can compile with `x86_64-linux-musl-gcc` on my system (x86_64-musl), using `cc` fails build. I don't know how to do this nicely in the template for other archs.


A patch file from https://github.com/void-linux/void-packages/pull/31261.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-update-31261.patch --]
[-- Type: text/x-diff, Size: 1288 bytes --]

From ea4e9ded15e6c851ee1e056dafe0d43e1a6c6a14 Mon Sep 17 00:00:00 2001
From: FollieHiyuki <folliekazetani@protonmail.com>
Date: Wed, 2 Jun 2021 18:54:09 +0300
Subject: [PATCH] nnn: update to 4.1

---
 srcpkgs/nnn/template | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index 7d905198b749..c1a41dec0ab1 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,7 +1,7 @@
 # Template file for 'nnn'
 pkgname=nnn
-version=4.0
-revision=2
+version=4.1
+revision=1
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
@@ -12,7 +12,17 @@ license="BSD-2-Clause"
 homepage="https://github.com/jarun/nnn"
 changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
-checksum=a219ec8fad3dd0512aadae5840176f3265188c4c22da3b17b133bac602b40754
+checksum=8549ac5f3007337da4841e62da696507e753035f36ac4e0537502e261ce701e6
+
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	makedepends+=" musl-fts-devel"
+fi
+
+pre_build() {
+	if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+		export LDLIBS=-lfts
+	fi
+}
 
 post_install() {
 	vinstall misc/auto-completion/bash/nnn-completion.bash 644 \

  parent reply	other threads:[~2021-06-02 16:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 16:00 [PR PATCH] " FollieHiyuki
2021-06-02 16:34 ` ericonr
2021-06-02 16:34 ` ericonr
2021-06-02 16:43 ` FollieHiyuki [this message]
2021-06-02 16:44 ` FollieHiyuki
2021-06-02 16:56 ` ericonr
2021-06-02 16:58 ` [PR PATCH] [Updated] " FollieHiyuki
2021-06-02 17:04 ` FollieHiyuki
2021-06-03 20:58 ` FollieHiyuki
2021-06-03 21:12 ` ericonr
2021-06-04 17:07 ` FollieHiyuki
2021-06-04 18:49 ` [PR PATCH] [Merged]: " ericonr
2021-06-04 22:14 ` tuxliban
2021-06-04 22:18 ` tuxliban
2021-06-04 22:20 ` tuxliban
2021-06-04 23:20 ` sgn
2021-06-05  0:09 ` tuxliban
2021-06-05 21:46 ` tuxliban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602164332.gG6jFtTO_MLsN2tzuApVP1ylRAVOPJoyoUWT42z5e6Q@z \
    --to=folliehiyuki@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).