Github messages for voidlinux
 help / color / mirror / Atom feed
From: loreb <loreb@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: recutils: patch to fix recins not working outside of $TMPDIR
Date: Mon, 07 Jun 2021 17:44:39 +0200	[thread overview]
Message-ID: <20210607154439.utthRB2YV7SRcYak7U3443MFBxin1sWO6G7Fe4ZvNMU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-30567@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/pull/30567#issuecomment-856051789

Comment:
It's been one month since I asked upstream and still no response... to recap:
1. the fix is small, and most importantly the patch is literally copied from upstream
2. unfortunately it pull in a stupid amount of tiny dependencies, nearly 2kloc
3. I've given up generating number 2 in automatically
4. one month with no response means upstream will wait until 1.9 is out

`qcopy_file_preserving` above replaces all those stupid dependencies in the megapatch, at the cost of calling an external process; I tested it a couple of times to check for silly mistakes, then ran "make check" and all tests passed.
It's not even part of the shared libraries, so there should be no concerns like "what if something is using librec.{a,so} in a chroot without /bin/cp" - unless I'm mistaken of course.

TLDR: if you think it's fine, I'll replace the megapatch with qcopy_file_preserving above + any suggestion/modification etc,
otherwise just tell me and I'll close the PR, no big deal and no more time wasted :)

  parent reply	other threads:[~2021-06-07 15:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 21:30 [PR PATCH] " loreb
2021-04-28 21:38 ` [PR REVIEW] " ericonr
2021-04-28 21:46 ` [PR PATCH] [Updated] " loreb
2021-04-28 21:48 ` [PR REVIEW] " loreb
2021-04-28 21:52 ` ericonr
2021-04-28 21:55 ` loreb
2021-04-28 21:58 ` loreb
2021-04-28 21:58 ` [PR PATCH] [Updated] " loreb
2021-05-17 13:12 ` loreb
2021-06-07 15:44 ` loreb [this message]
2021-06-08  2:29 ` ericonr
2021-06-08 12:54 ` [PR PATCH] [Updated] " loreb
2021-06-08 13:02 ` loreb
2021-06-08 13:21 ` [PR REVIEW] " ericonr
2021-06-08 13:21 ` ericonr
2021-06-08 13:21 ` ericonr
2021-06-08 14:33 ` [PR PATCH] [Updated] " loreb
2021-06-08 14:34 ` [PR REVIEW] " loreb
2021-06-08 14:35 ` loreb
2021-06-08 15:17 ` [PR PATCH] [Updated] " loreb
2021-06-08 15:19 ` [PR REVIEW] " loreb
2022-05-18  2:09 ` github-actions
2022-05-18 14:46 ` [PR PATCH] [Closed]: " loreb
2022-05-18 14:46 ` loreb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607154439.utthRB2YV7SRcYak7U3443MFBxin1sWO6G7Fe4ZvNMU@z \
    --to=loreb@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).