From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: build-style/python3-{module,pep517}.sh: improve pytest usage
Date: Tue, 08 Jun 2021 19:53:49 +0200 [thread overview]
Message-ID: <20210608175349.ixBbETbYWlF91o3keK7DhDWsE2-TI9IFJN06cv8K_4g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31354@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
There's a closed pull request on the void-packages repository
build-style/python3-{module,pep517}.sh: improve pytest usage
https://github.com/void-linux/void-packages/pull/31354
Description:
1. Relying on `python3 -m pytest --help` to test for pytest can fail
because the pytest packages's __main__ is still invoked; this can
trigger import problems and falsely indicate that pytest is missing.
A simpler test is to just confirm that pytest is importable. If so,
the interpreter returns 0. Otherwise, an ImportError is thrown and
the interpreter will return 1.
2. Many templates require a custom do_check just to set PYTHONPATH to
either a build directory (especially for compiled extensions) or some
subdirectory of the source tree. Setting PYTHONPATH automatically to
the build directory should drastically reduce the need for custom
do_check in py3 templates. (This only applies to python3-module.sh
because pep517 builders will have unpredictable build directories.)
prev parent reply other threads:[~2021-06-08 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 3:48 [PR PATCH] build-style/python3-{module,pep517}.sh: fix check for pytest ahesford
2021-06-08 4:16 ` [PR PATCH] [Updated] " ahesford
2021-06-08 5:00 ` ahesford
2021-06-08 17:53 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608175349.ixBbETbYWlF91o3keK7DhDWsE2-TI9IFJN06cv8K_4g@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).