From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: mailnag-2.2.0
Date: Tue, 08 Jun 2021 20:00:22 +0200 [thread overview]
Message-ID: <20210608180022.ST3U8MAz5IvDCYGJw3gdnXD7_eX7n6VlO4l2G5Kv0Fw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31367@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/31367#discussion_r647673538
Comment:
Generally all dependencies should be added as stated by upstream, to be prepared to dropping dependencies by other packages. Python interpreter is one of few cases where it's obvious that it is needed by modules, so listing it is noise.
Dependencies detected and listed in build log by 04-generate-runtime-deps hook aren't listed either. There are none for this package as it is written in python, but for compiled packages it's often all dependencies.
next prev parent reply other threads:[~2021-06-08 18:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 16:00 [PR PATCH] " Cnoob41
2021-06-08 16:56 ` [PR REVIEW] " Chocimier
2021-06-08 16:56 ` Chocimier
2021-06-08 16:57 ` Chocimier
2021-06-08 16:57 ` Chocimier
2021-06-08 17:10 ` Cnoob41
2021-06-08 17:19 ` Chocimier
2021-06-08 17:22 ` Cnoob41
2021-06-08 17:24 ` [PR PATCH] [Updated] " Cnoob41
2021-06-08 17:25 ` [PR REVIEW] " Chocimier
2021-06-08 17:25 ` Cnoob41
2021-06-08 17:25 ` Cnoob41
2021-06-08 17:25 ` Cnoob41
2021-06-08 17:30 ` Cnoob41
2021-06-08 17:34 ` Chocimier
2021-06-08 17:45 ` Cnoob41
2021-06-08 18:00 ` Chocimier [this message]
2021-06-08 18:04 ` Cnoob41
2021-06-08 18:13 ` Cnoob41
2021-06-08 18:33 ` [PR REVIEW] " ericonr
2021-06-11 14:56 ` Cnoob41
2021-06-11 15:09 ` [PR PATCH] [Updated] " Cnoob41
2021-06-11 15:10 ` [PR REVIEW] " Cnoob41
2021-06-12 10:12 ` [PR PATCH] [Updated] " meator
2021-06-12 11:26 ` meator
2021-06-12 11:46 ` meator
2021-06-12 11:48 ` meator
2021-06-12 14:18 ` [PR PATCH] [Updated] " meator
2021-06-12 15:55 ` [PR PATCH] [Updated] [WIP] " meator
2021-06-12 16:31 ` [PR PATCH] [Updated] New packages: mailnag-2.2.0, mailnag-goa-plugin-2.0.0 meator
2021-06-12 16:39 ` meator
2021-06-12 16:40 ` Chocimier
2021-06-12 16:40 ` meator
2021-06-12 16:43 ` meator
2021-06-12 17:05 ` [PR PATCH] [Updated] " meator
2021-06-12 17:19 ` meator
2021-06-13 18:59 ` meator
2021-06-14 16:03 ` [PR PATCH] [Updated] " meator
2021-06-14 20:04 ` Chocimier
2021-06-14 20:04 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608180022.ST3U8MAz5IvDCYGJw3gdnXD7_eX7n6VlO4l2G5Kv0Fw@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).