Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Add tzdata to base-chroot
Date: Wed, 09 Jun 2021 13:31:50 +0200	[thread overview]
Message-ID: <20210609113150.-s9iRmC4xRn40JlsT9dGHU9nCmrWFpOn72gSbu7Lq0M@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31377@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages add-tzdata-to-base-chroot
https://github.com/void-linux/void-packages/pull/31377

Add tzdata to base-chroot
@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/31377.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-tzdata-to-base-chroot-31377.patch --]
[-- Type: text/x-diff, Size: 4157 bytes --]

From 2526d0530ee88ef103340139401ed140e015a600 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 9 Jun 2021 18:31:25 +0700
Subject: [PATCH 1/3] tzutils: fix version, setbootstrap

---
 srcpkgs/tzutils/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/tzutils/template b/srcpkgs/tzutils/template
index 3bd79fb85cbb..6dc565b2c96a 100644
--- a/srcpkgs/tzutils/template
+++ b/srcpkgs/tzutils/template
@@ -1,16 +1,18 @@
 # Template file for 'tzutils'
 pkgname=tzutils
 version=2021a
-revision=1
+revision=3
+bootstrap=yes
 wrksrc="tz-${version}"
 short_desc="Time zone and daylight-saving time utilities"
-maintainer="Anthony Iliopoulos <ailiop@altatus.com>"
+maintainer="Đoàn Trần Công Danh <congdanhqx@gmail.com>"
 license="Public Domain, BSD-3-Clause"
 homepage="https://www.iana.org/time-zones"
 distfiles="https://github.com/eggert/tz/archive/${version}.tar.gz"
 checksum=bd7ecd99cbb0a2f15bb7e38be2cbc04dced89922fce4ac0ffcd1ca844ba9362f
 
 do_build() {
+	echo "$version" >version
 	make TZDIR=/usr/share/zoneinfo CC=$CC CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS"
 }
 
@@ -21,8 +23,5 @@ do_install() {
 	vman zic.8
 	vman zdump.8
 	vman tzselect.8
-}
-
-post_install() {
 	vlicense LICENSE
 }

From 263dc2d8958a245eff7a572297acd0e13db610a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 9 Jun 2021 18:31:27 +0700
Subject: [PATCH 2/3] tzdata: set bootstrap=yes

---
 srcpkgs/tzdata/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/tzdata/template b/srcpkgs/tzdata/template
index 25f79d0a1926..618ad6c9e10a 100644
--- a/srcpkgs/tzdata/template
+++ b/srcpkgs/tzdata/template
@@ -2,7 +2,7 @@
 pkgname=tzdata
 version=2021a
 revision=1
-wrksrc=tzdata
+bootstrap=yes
 create_wrksrc=yes
 hostmakedepends="tzutils"
 short_desc="Time zone and daylight-saving time data"

From 330f2dbeb19fd2f05ddd2fefbeaa38a2e3fd9923 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 9 Jun 2021 18:31:28 +0700
Subject: [PATCH 3/3] base-chroot: add tzdata

Some packages require tzdata to testing, however, adding `tzdata` to
those checkdepends will break masterdir, since `tzdata` provides
`/usr/share/zoneinfo/UTC`, hence, it will be removed upon cleanup.

Let's add `tzdata` into `base-chroot` and remove the shenanigan in
`chroot.sh`.
---
 common/xbps-src/shutils/chroot.sh | 10 +---------
 srcpkgs/base-chroot/template      |  2 +-
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/common/xbps-src/shutils/chroot.sh b/common/xbps-src/shutils/chroot.sh
index c7ada3151618..53e3d4a4c70f 100644
--- a/common/xbps-src/shutils/chroot.sh
+++ b/common/xbps-src/shutils/chroot.sh
@@ -109,15 +109,7 @@ chroot_prepare() {
     # Some software expects /etc/localtime to be a symbolic link it can read to
     # determine the name of the time zone, so set up the expected link
     # structure.
-    if [ -f /usr/share/zoneinfo/UTC ]; then
-        tzfile=/usr/share/zoneinfo/UTC
-        mkdir -p $XBPS_MASTERDIR/usr/share/zoneinfo
-        cp /usr/share/zoneinfo/UTC $XBPS_MASTERDIR/usr/share/zoneinfo/UTC
-        ln -sf ../usr/share/zoneinfo/UTC $XBPS_MASTERDIR/etc/localtime
-    else
-        # Should never happen.
-        msg_warn "No local timezone configuration file created.\n"
-    fi
+    ln -sf ../usr/share/zoneinfo/UTC $XBPS_MASTERDIR/etc/localtime
 
     for f in dev sys tmp proc host boot; do
         [ ! -d $XBPS_MASTERDIR/$f ] && mkdir -p $XBPS_MASTERDIR/$f
diff --git a/srcpkgs/base-chroot/template b/srcpkgs/base-chroot/template
index 5003e3c37247..599183f8c54b 100644
--- a/srcpkgs/base-chroot/template
+++ b/srcpkgs/base-chroot/template
@@ -19,7 +19,7 @@ depends+="
  patch sed findutils diffutils make gzip coreutils
  file bsdtar xbps mpfr ncurses libreadline8
  chroot-bash chroot-grep chroot-gawk chroot-distcc
- chroot-util-linux chroot-git"
+ chroot-util-linux chroot-git tzdata"
 
 if [ "$CHROOT_READY" ]; then
 	depends+=" ccache"

  reply	other threads:[~2021-06-09 11:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 11:24 [PR PATCH] " sgn
2021-06-09 11:31 ` sgn [this message]
2021-06-09 17:35 ` the-maldridge
2021-06-09 18:54 ` [PR REVIEW] " ericonr
2021-06-09 18:54 ` ericonr
2021-06-10  0:35 ` sgn
2021-06-10  0:37 ` [PR PATCH] [Updated] " sgn
2021-06-10  0:38 ` [PR REVIEW] " sgn
2021-06-10  0:38 ` sgn
2021-06-10  0:52 ` [PR PATCH] [Updated] " sgn
2021-06-10 10:14 ` sgn
2021-06-15 18:18 ` sgn
2021-06-16  0:50 ` [PR PATCH] [Updated] " sgn
2021-06-17  0:33 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609113150.-s9iRmC4xRn40JlsT9dGHU9nCmrWFpOn72gSbu7Lq0M@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).