Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: ulogd: enable pcap output as a build option
Date: Thu, 10 Jun 2021 02:57:49 +0200	[thread overview]
Message-ID: <20210610005749.2dnsiTI-eOQutA3AS3mSNLjDWnf0u_GaXpSQ8uIrKc4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31331@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31331#issuecomment-858199760

Comment:
It doesn't seem to have created any additional dependency in the binary package, I assume because it dlopens things? In this case I agree with ahesford that a build option isn't truly necessary, but it doesn't hurt either. In any case, if you can confirm the new plugin is working, I'd feel comfortable merging as is.

```
=> ulogd-2.0.7_2: running pre-pkg hook: 04-generate-runtime-deps ...
   SONAME: libc.so.6 <-> glibc>=2.32_1
   SONAME: ld-linux-armhf.so.3 <-> glibc>=2.32_1
   SONAME: libnetfilter_log.so.1 <-> libnetfilter_log>=1.0.1_1
   SONAME: libnfnetlink.so.0 <-> libnfnetlink>=1.0.1_1
   SONAME: libmnl.so.0 <-> libmnl>=1.0.3_1
   SONAME: libnetfilter_acct.so.1 <-> libnetfilter_acct>=1.0.2_1
   SONAME: libnetfilter_conntrack.so.3 <-> libnetfilter_conntrack>=1.0.4_1
   SONAME: libdl.so.2 <-> glibc>=2.32_1
   SONAME: libpthread.so.0 <-> glibc>=2.32_1
```

  parent reply	other threads:[~2021-06-10  0:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 23:15 [PR PATCH] " ailiop-git
2021-06-07 13:58 ` ahesford
2021-06-07 14:04 ` ailiop-git
2021-06-10  0:57 ` ericonr [this message]
2021-06-10  9:40 ` ailiop-git
2021-06-10  9:44 ` [PR PATCH] [Updated] " ailiop-git
2021-06-10 14:45 ` [PR PATCH] [Merged]: " ericonr
2021-06-10 14:45 ` ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610005749.2dnsiTI-eOQutA3AS3mSNLjDWnf0u_GaXpSQ8uIrKc4@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).