From ca38f428898ca145e30aef8046b51ba535362844 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Rolim?= Date: Mon, 1 Feb 2021 12:14:28 -0300 Subject: [PATCH 1/2] environment/hardening: add -Werror=implicit-function-declaration. Warnings for implicit function declarations should be errors, since they can lead to issues down the line when the implicit type rules get things wrong, especially with variadic functions. --- common/environment/configure/hardening.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/environment/configure/hardening.sh b/common/environment/configure/hardening.sh index 9e02364f2a1d..c2c4bf5a3598 100644 --- a/common/environment/configure/hardening.sh +++ b/common/environment/configure/hardening.sh @@ -28,3 +28,5 @@ else FFLAGS="-fno-PIE ${FFLAGS}" LDFLAGS="-no-pie ${LDFLAGS}" fi + +CFLAGS+=" -Werror=implicit-function-declaration" From ddf8b6a8bf97bea3fcdaccfafdeedf4456908e67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Nogueira?= Date: Thu, 10 Jun 2021 13:42:50 -0300 Subject: [PATCH 2/2] build-style/gnu-configure: remove Werror from implicit declarations. Many configure scripts depend on -Werror=implicit-function-declaration to work correctly, so we can't set it for gnu-configure builds. --- common/build-style/gnu-configure.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/build-style/gnu-configure.sh b/common/build-style/gnu-configure.sh index 8121136cd121..6f7f044fcce1 100644 --- a/common/build-style/gnu-configure.sh +++ b/common/build-style/gnu-configure.sh @@ -4,6 +4,8 @@ do_configure() { : ${configure_script:=./configure} + export CFLAGS="${CFLAGS/-Werror=implicit-function-declaration/}" + echo $CFLAGS export lt_cv_sys_lib_dlsearch_path_spec="/usr/lib64 /usr/lib32 /usr/lib /lib /usr/local/lib" ${configure_script} ${configure_args} }