From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Add abstract initramfs-regenerate trigger to xbps-triggers
Date: Thu, 10 Jun 2021 19:00:50 +0200 [thread overview]
Message-ID: <20210610170050.s-RKUsoqAmUKG4cdvh2mW64NL2IW5pmVvoZtNEk9b0s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31403@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/31403#discussion_r649367817
Comment:
I'm open to that argument, but I think ZFS and nvidia are somewhat special cases; for example, `acpi_call-dkms` probably never needs to be folded into an initramfs image, so triggering a rebuild of them would be wasteful. Adding an opt-in trigger is a bit of a compromise (the downside, of course, is that the trigger order matters so we can't rely on `dkms_modules` to automatically insert `dkms` without breaking the ordering).
next prev parent reply other threads:[~2021-06-10 17:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 16:07 [PR PATCH] " ahesford
2021-06-10 16:52 ` [PR REVIEW] " ericonr
2021-06-10 16:52 ` ericonr
2021-06-10 16:52 ` ericonr
2021-06-10 16:57 ` ahesford
2021-06-10 16:58 ` ahesford
2021-06-10 17:00 ` ahesford [this message]
2021-06-10 17:01 ` ericonr
2021-06-10 17:02 ` ericonr
2021-06-10 17:34 ` [PR PATCH] [Updated] " ahesford
2021-06-10 17:36 ` [PR REVIEW] " ahesford
2021-06-10 17:36 ` ahesford
2021-06-10 17:47 ` [PR PATCH] [Updated] " ahesford
2021-06-11 2:14 ` ahesford
2021-06-15 7:03 ` Vaelatern
2021-06-15 15:21 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610170050.s-RKUsoqAmUKG4cdvh2mW64NL2IW5pmVvoZtNEk9b0s@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).