[PR PATCH] ReText: update to 7.2.1.

[PR PATCH] ReText: update to 7.2.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages retext
https://github.com/void-linux/void-packages/pull/31121

ReText: update to 7.2.1.
Also fix tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-retext-31121.patch --]
[-- Type: text/x-diff, Size: 1491 bytes --]

From 7e2ab37cafed90e34ffee76b1c97b204778f232d Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Tue, 25 May 2021 23:25:31 +0300
Subject: [PATCH] ReText: update to 7.2.1.

Also fix tests.
---
 srcpkgs/ReText/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ReText/template b/srcpkgs/ReText/template
index 99c003962178..924188281026 100644
--- a/srcpkgs/ReText/template
+++ b/srcpkgs/ReText/template
@@ -1,19 +1,24 @@
 # Template file for 'ReText'
 pkgname=ReText
-version=7.1.0
-revision=2
+version=7.2.1
+revision=1
 wrksrc="${pkgname,,}-${version}"
 build_style=python3-module
 hostmakedepends="ImageMagick python3 qt5-host-tools qt5-tools python3-setuptools"
 makedepends="python3-Markdown python3-Markups python3-PyQt5-webkit qt5-tools"
 depends="desktop-file-utils python3-chardet python3-docutils python3-Markdown
  python3-Markups python3-PyQt5-webkit"
+checkdepends="python3-pip"
 short_desc="Simple editor for Markdown and reStructuredText"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/retext-project/retext"
 distfiles="https://github.com/retext-project/retext/archive/${version}.tar.gz"
-checksum=a51cf19232e74a6972ce5d875ed1f24b07e6922841ce04558b99ecfc34b34134
+checksum=a1e8784fcb4e186a6e6e42a0f2be4098c27bedb96a9711aa17a9846278e7d932
+
+pre_check() {
+	export QT_QPA_PLATFORM=offscreen
+}
 
 post_install() {
 	local icondir=usr/share/icons/hicolor

Re: [PR REVIEW] ReText: update to 7.2.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r639383412

Comment:
Fixing tests with pip means we are testing using packages from pypi instead of the void ones. Do `checkdepends="$depends"` instead and see where it fails. If it complains about trying to install pytest, add it as well.

Re: [PR REVIEW] ReText: update to 7.2.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r639539911

Comment:
I get that, but I am not going to spend the time, sorry.

Re: [PR REVIEW] ReText: update to 7.2.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r639667181

Comment:
Then don't add pip at all and allow the tests to be fixed in the future.

Re: [PR REVIEW] ReText: update to 7.2.1.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r641785436

Comment:
Doing tests the right way causes python to abort in this case, which is why we want tests that actually run against the stuff we build rather than whatever wheels pip downloads.

Re: [PR REVIEW] ReText: update to 7.2.1.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 3814 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r641785436

Comment:
Doing tests the right way causes python to abort in this case, which is why we want tests that actually run against the stuff we build rather than whatever wheels pip downloads.
```
Fatal Python error: Aborted

Current thread 0x00007fee655f7740 (most recent call first):
  File "/builddir/retext-7.2.1/tests/test_editor.py", line 33 in <module>
  File "/usr/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 170 in exec_module
  File "<frozen importlib._bootstrap>", line 680 in _load_unlocked
  File "<frozen importlib._bootstrap>", line 986 in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1007 in _find_and_load
  File "<frozen importlib._bootstrap>", line 1030 in _gcd_import
  File "/usr/lib/python3.9/importlib/__init__.py", line 127 in import_module
  File "/usr/lib/python3.9/site-packages/_pytest/pathlib.py", line 524 in import_path
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 578 in _importtestmodule
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 500 in _getobj
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 291 in obj
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 516 in _inject_setup_module_fixture
  File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 503 in collect
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 341 in <lambda>
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 341 in pytest_make_collect_report
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 458 in collect_one_node
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 808 in genitems
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 811 in genitems
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 634 in perform_collect
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 333 in pytest_collection
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 322 in _main
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
  File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
  File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
  File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
  File "/usr/bin/pytest", line 33 in <module>
/void-packages/srcpkgs/ReText/template: line 19: 25691 Aborted                 QT_QPA_PLATFORM=offsreen PYTHONPATH="$(cd build/lib* && pwd)" pytest tests
```

Re: [PR PATCH] [Updated] ReText: update to 7.2.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages retext
https://github.com/void-linux/void-packages/pull/31121

ReText: update to 7.2.1.
Also fix tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-retext-31121.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]

From 7ef02c61670dcf8a40e3e72a098bfff437603d97 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Tue, 25 May 2021 23:25:31 +0300
Subject: [PATCH] ReText: update to 7.2.1.

---
 srcpkgs/ReText/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ReText/template b/srcpkgs/ReText/template
index 99c003962178..2cfa724ab370 100644
--- a/srcpkgs/ReText/template
+++ b/srcpkgs/ReText/template
@@ -1,7 +1,7 @@
 # Template file for 'ReText'
 pkgname=ReText
-version=7.1.0
-revision=2
+version=7.2.1
+revision=1
 wrksrc="${pkgname,,}-${version}"
 build_style=python3-module
 hostmakedepends="ImageMagick python3 qt5-host-tools qt5-tools python3-setuptools"
@@ -13,7 +13,11 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/retext-project/retext"
 distfiles="https://github.com/retext-project/retext/archive/${version}.tar.gz"
-checksum=a51cf19232e74a6972ce5d875ed1f24b07e6922841ce04558b99ecfc34b34134
+checksum=a1e8784fcb4e186a6e6e42a0f2be4098c27bedb96a9711aa17a9846278e7d932
+
+do_check() {
+	: # XX tests do not run with packages as checkdepends, they run with pip.
+}
 
 post_install() {
 	local icondir=usr/share/icons/hicolor

Re: [PR REVIEW] ReText: update to 7.2.1.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/31121#discussion_r641947313

Comment:
@ahesford @ericonr I just added a comments that tests fail with packages and succeed with pip. Thank you.

Re: [PR PATCH] [Closed]: ReText: update to 7.2.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

There's a closed pull request on the void-packages repository

ReText: update to 7.2.1.
https://github.com/void-linux/void-packages/pull/31121

Description:
Also fix tests.

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->