Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dhcp: add basic logging functionality
@ 2021-02-08  2:26 heliocat
  2021-02-08  4:15 ` heliocat
                   ` (19 more replies)
  0 siblings, 20 replies; 21+ messages in thread
From: heliocat @ 2021-02-08  2:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

There is a new pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 2769 bytes --]

From fa50145267927aa935a1933d592bafa17be4d583 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 2 ++
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 srcpkgs/dhcp/template               | 2 +-
 7 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/dhcp/files/dhclient/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 100644
index 00000000000..39fd511f560
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhclient
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5..19b924ab3c2 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 100644
index 00000000000..e57255cfa35
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd4
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726e..423d87cc70d 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 100644
index 00000000000..79d390c638a
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd6
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f33221..57b86926acb 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}
diff --git a/srcpkgs/dhcp/template b/srcpkgs/dhcp/template
index 47fa43fb02e..62819c4f81e 100644
--- a/srcpkgs/dhcp/template
+++ b/srcpkgs/dhcp/template
@@ -1,7 +1,7 @@
 # Template file for 'dhcp'
 pkgname=dhcp
 version=4.4.2
-revision=2
+revision=3
 wrksrc="dhcp-${version/P/-P}"
 build_style=gnu-configure
 hostmakedepends="perl tar automake libtool"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
@ 2021-02-08  4:15 ` heliocat
  2021-02-09 15:55 ` leahneukirchen
                   ` (18 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-02-08  4:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-774854262

Comment:
I know right? A lot of services are silent over stdout/err and only use syslog but clearly dhclient/dhcpd are not in that boat. I'm sure there's a lot of other low-hanging cleanup fruit in the issues queue so I'll probably end up making a bunch of PRs over the course of the week.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
  2021-02-08  4:15 ` heliocat
@ 2021-02-09 15:55 ` leahneukirchen
  2021-02-09 16:17 ` heliocat
                   ` (17 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: leahneukirchen @ 2021-02-09 15:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776044220

Comment:
Should use `-p daemon.notice`, no? Which is what dhcpd uses without `-d`.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
  2021-02-08  4:15 ` heliocat
  2021-02-09 15:55 ` leahneukirchen
@ 2021-02-09 16:17 ` heliocat
  2021-02-09 16:23 ` heliocat
                   ` (16 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-02-09 16:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776058280

Comment:
Good call. I forgot that user.notice is the default and all of the other appendant loggers defined in void-packages fail to define a log facility.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (2 preceding siblings ...)
  2021-02-09 16:17 ` heliocat
@ 2021-02-09 16:23 ` heliocat
  2021-02-09 18:30 ` [PR PATCH] [Updated] " Hoshpak
                   ` (15 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-02-09 16:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776060718

Comment:
Good call. I forgot that user.notice is the default and all of the other appendant loggers defined in void-packages fail to define a log facility.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (3 preceding siblings ...)
  2021-02-09 16:23 ` heliocat
@ 2021-02-09 18:30 ` Hoshpak
  2021-02-09 18:46 ` Duncaen
                   ` (14 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Hoshpak @ 2021-02-09 18:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is an updated pull request by Hoshpak against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 2820 bytes --]

From ace37d26e54931b4208af5b0081deaaf4f98f944 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 2 ++
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 srcpkgs/dhcp/template               | 2 +-
 7 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/dhcp/files/dhclient/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 100644
index 00000000000..7b61af43424
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhclient -p daemon.notice
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5..19b924ab3c2 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 100644
index 00000000000..5886e26b9c9
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd4 -p daemon.notice
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726e..423d87cc70d 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 100644
index 00000000000..f219ef89866
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd6 -p daemon.notice
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f33221..57b86926acb 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}
diff --git a/srcpkgs/dhcp/template b/srcpkgs/dhcp/template
index 47fa43fb02e..62819c4f81e 100644
--- a/srcpkgs/dhcp/template
+++ b/srcpkgs/dhcp/template
@@ -1,7 +1,7 @@
 # Template file for 'dhcp'
 pkgname=dhcp
 version=4.4.2
-revision=2
+revision=3
 wrksrc="dhcp-${version/P/-P}"
 build_style=gnu-configure
 hostmakedepends="perl tar automake libtool"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (4 preceding siblings ...)
  2021-02-09 18:30 ` [PR PATCH] [Updated] " Hoshpak
@ 2021-02-09 18:46 ` Duncaen
  2021-02-09 18:48 ` Duncaen
                   ` (13 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Duncaen @ 2021-02-09 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776157520

Comment:
If you use the link mode where you link vlogger to log/run then it will set the tag by the service name and daemon.info.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (5 preceding siblings ...)
  2021-02-09 18:46 ` Duncaen
@ 2021-02-09 18:48 ` Duncaen
  2021-02-10 17:11 ` heliocat
                   ` (12 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Duncaen @ 2021-02-09 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776158498

Comment:
Nevermind, thats just part of my local branch and I've never commit that.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (6 preceding siblings ...)
  2021-02-09 18:48 ` Duncaen
@ 2021-02-10 17:11 ` heliocat
  2021-05-13 16:34 ` [PR PATCH] [Updated] " heliocat
                   ` (11 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-02-10 17:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-776060718

Comment:
Good call. I forgot that user.notice is the default and all of the other appendant loggers defined in void-packages fail to define a log facility.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (7 preceding siblings ...)
  2021-02-10 17:11 ` heliocat
@ 2021-05-13 16:34 ` heliocat
  2021-06-08  5:30 ` heliocat
                   ` (10 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-05-13 16:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 2783 bytes --]

From 544ccb1f38d8a82c1e49f64a42bb573d6f358422 Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 2 ++
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 srcpkgs/dhcp/template               | 2 +-
 7 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/dhcp/files/dhclient/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 100644
index 000000000000..39fd511f560e
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhclient
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5a..19b924ab3c29 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 100644
index 000000000000..e57255cfa359
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd4
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726ed..423d87cc70dd 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 100644
index 000000000000..79d390c638ac
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -t dhcpd6
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f332212..57b86926acb7 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}
diff --git a/srcpkgs/dhcp/template b/srcpkgs/dhcp/template
index 47fa43fb02ec..62819c4f81e5 100644
--- a/srcpkgs/dhcp/template
+++ b/srcpkgs/dhcp/template
@@ -1,7 +1,7 @@
 # Template file for 'dhcp'
 pkgname=dhcp
 version=4.4.2
-revision=2
+revision=3
 wrksrc="dhcp-${version/P/-P}"
 build_style=gnu-configure
 hostmakedepends="perl tar automake libtool"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (8 preceding siblings ...)
  2021-05-13 16:34 ` [PR PATCH] [Updated] " heliocat
@ 2021-06-08  5:30 ` heliocat
  2021-06-08  5:31 ` heliocat
                   ` (9 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-08  5:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 2544 bytes --]

From 94906d4c79f15d31f83b698516ac1815e78160aa Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

vlogger should properly set tag and facility identically to logger if
you don't set anything special so it shoud be entirely safe to simply
exec straight into vlogger without explicitly setting those flags.

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 2 ++
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 2 ++
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 6 files changed, 9 insertions(+)
 create mode 100644 srcpkgs/dhcp/files/dhclient/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 100644 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 100644
index 000000000000..801e7bfcb843
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5a..19b924ab3c29 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 100644
index 000000000000..801e7bfcb843
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726ed..423d87cc70dd 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 100644
index 000000000000..801e7bfcb843
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f332212..57b86926acb7 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (9 preceding siblings ...)
  2021-06-08  5:30 ` heliocat
@ 2021-06-08  5:31 ` heliocat
  2021-06-08  5:33 ` heliocat
                   ` (8 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-08  5:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-856455610

Comment:
@Gottox adding you as a reviewer since you're the package owner.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (10 preceding siblings ...)
  2021-06-08  5:31 ` heliocat
@ 2021-06-08  5:33 ` heliocat
  2021-06-08 13:18 ` ericonr
                   ` (7 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-08  5:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-856455610

Comment:
@Gottox adding you as a reviewer since you're the package maintainer.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (11 preceding siblings ...)
  2021-06-08  5:33 ` heliocat
@ 2021-06-08 13:18 ` ericonr
  2021-06-11 22:53 ` [PR PATCH] [Updated] " heliocat
                   ` (6 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-06-08 13:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-856759874

Comment:
We should switch from `exec vlogger` to the symlink, like is done for `bluez`.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (12 preceding siblings ...)
  2021-06-08 13:18 ` ericonr
@ 2021-06-11 22:53 ` heliocat
  2021-06-11 22:54 ` heliocat
                   ` (5 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-11 22:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 2598 bytes --]

From b941cbeb567b3153ece3f3795d76723c46c6ff2c Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

vlogger should properly set tag and facility identically to logger if
you don't set anything special so it shoud be entirely safe to simply
exec straight into vlogger without explicitly setting those flags.

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 1 +
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 1 +
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 1 +
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 6 files changed, 6 insertions(+)
 create mode 120000 srcpkgs/dhcp/files/dhclient/log/run
 create mode 120000 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 120000 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5a..19b924ab3c29 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726ed..423d87cc70dd 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f332212..57b86926acb7 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (13 preceding siblings ...)
  2021-06-11 22:53 ` [PR PATCH] [Updated] " heliocat
@ 2021-06-11 22:54 ` heliocat
  2021-06-12 18:12 ` ericonr
                   ` (4 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-11 22:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-859946807

Comment:
I've never particularly liked using symlinks as run scripts since it makes things somewhat more difficult to audit for usage. However, it will make the nebulous future plan of giving everything a logger easier since at that point you can very easily have the packaging system drop a log/run symlink in any servicedir that fails to declare a logger.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (14 preceding siblings ...)
  2021-06-11 22:54 ` heliocat
@ 2021-06-12 18:12 ` ericonr
  2021-06-12 22:13 ` heliocat
                   ` (3 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-06-12 18:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-860089510

Comment:
Should be a separate commit for each package + a revbump.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (15 preceding siblings ...)
  2021-06-12 18:12 ` ericonr
@ 2021-06-12 22:13 ` heliocat
  2021-06-12 22:14 ` [PR PATCH] [Updated] " heliocat
                   ` (2 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-12 22:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-860119908

Comment:
They are sub-packages of dhcp.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (16 preceding siblings ...)
  2021-06-12 22:13 ` heliocat
@ 2021-06-12 22:14 ` heliocat
  2021-06-12 22:15 ` heliocat
  2021-06-13 17:11 ` [PR PATCH] [Merged]: " ericonr
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-12 22:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

There is an updated pull request by heliocat against master on the void-packages repository

https://github.com/heliocat/void-packages dhcp
https://github.com/void-linux/void-packages/pull/28576

dhcp: add basic logging functionality
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/28576.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcp-28576.patch --]
[-- Type: text/x-diff, Size: 3014 bytes --]

From 0360d00c5ece87097e158509371dd0a34218439e Mon Sep 17 00:00:00 2001
From: Colin Booth <colin@heliocat.net>
Date: Sun, 7 Feb 2021 13:08:10 -0800
Subject: [PATCH] dhcp: add basic logging functionality

vlogger should properly set tag and facility identically to logger if
you don't set anything special so it shoud be entirely safe to simply
exec straight into vlogger without explicitly setting those flags.

Fixes #25558
---
 srcpkgs/dhcp/files/dhclient/log/run | 1 +
 srcpkgs/dhcp/files/dhclient/run     | 1 +
 srcpkgs/dhcp/files/dhcpd4/log/run   | 1 +
 srcpkgs/dhcp/files/dhcpd4/run       | 1 +
 srcpkgs/dhcp/files/dhcpd6/log/run   | 1 +
 srcpkgs/dhcp/files/dhcpd6/run       | 1 +
 srcpkgs/dhcp/template               | 2 +-
 7 files changed, 7 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/dhcp/files/dhclient/log/run
 create mode 120000 srcpkgs/dhcp/files/dhcpd4/log/run
 create mode 120000 srcpkgs/dhcp/files/dhcpd6/log/run

diff --git a/srcpkgs/dhcp/files/dhclient/log/run b/srcpkgs/dhcp/files/dhclient/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhclient/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhclient/run b/srcpkgs/dhcp/files/dhclient/run
index 5cb45f19cf5a..19b924ab3c29 100644
--- a/srcpkgs/dhcp/files/dhclient/run
+++ b/srcpkgs/dhcp/files/dhclient/run
@@ -1,3 +1,4 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 exec dhclient ${OPTS:=-d} 
diff --git a/srcpkgs/dhcp/files/dhcpd4/log/run b/srcpkgs/dhcp/files/dhcpd4/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd4/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhcpd4/run b/srcpkgs/dhcp/files/dhcpd4/run
index 05d9f9b726ed..423d87cc70dd 100644
--- a/srcpkgs/dhcp/files/dhcpd4/run
+++ b/srcpkgs/dhcp/files/dhcpd4/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-4 -q -pf /run/dhcpd4.pid}
diff --git a/srcpkgs/dhcp/files/dhcpd6/log/run b/srcpkgs/dhcp/files/dhcpd6/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/dhcp/files/dhcpd6/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/dhcp/files/dhcpd6/run b/srcpkgs/dhcp/files/dhcpd6/run
index 2dc26f332212..57b86926acb7 100644
--- a/srcpkgs/dhcp/files/dhcpd6/run
+++ b/srcpkgs/dhcp/files/dhcpd6/run
@@ -1,4 +1,5 @@
 #!/bin/sh
+exec 2>&1
 [ -r conf ] && . ./conf
 touch /var/lib/dhcp/dhcpd.leases
 exec dhcpd -f ${OPTS:=-6 -q -pf /run/dhcpd6.pid}
diff --git a/srcpkgs/dhcp/template b/srcpkgs/dhcp/template
index 1b6f7de5b6cc..2db18dcc60b0 100644
--- a/srcpkgs/dhcp/template
+++ b/srcpkgs/dhcp/template
@@ -1,7 +1,7 @@
 # Template file for 'dhcp'
 pkgname=dhcp
 version=4.4.2P1
-revision=1
+revision=2
 wrksrc="dhcp-${version/P/-P}"
 build_style=gnu-configure
 hostmakedepends="perl tar automake libtool"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (17 preceding siblings ...)
  2021-06-12 22:14 ` [PR PATCH] [Updated] " heliocat
@ 2021-06-12 22:15 ` heliocat
  2021-06-13 17:11 ` [PR PATCH] [Merged]: " ericonr
  19 siblings, 0 replies; 21+ messages in thread
From: heliocat @ 2021-06-12 22:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/28576#issuecomment-860119908

Comment:
They are sub-packages of dhcp. I did miss the revbump though since that got undone at some point in the lifecycle of this PR.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Merged]: dhcp: add basic logging functionality
  2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
                   ` (18 preceding siblings ...)
  2021-06-12 22:15 ` heliocat
@ 2021-06-13 17:11 ` ericonr
  19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2021-06-13 17:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

There's a merged pull request on the void-packages repository

dhcp: add basic logging functionality
https://github.com/void-linux/void-packages/pull/28576

Description:
Fixes #25558

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [X] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2021-06-13 17:11 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08  2:26 [PR PATCH] dhcp: add basic logging functionality heliocat
2021-02-08  4:15 ` heliocat
2021-02-09 15:55 ` leahneukirchen
2021-02-09 16:17 ` heliocat
2021-02-09 16:23 ` heliocat
2021-02-09 18:30 ` [PR PATCH] [Updated] " Hoshpak
2021-02-09 18:46 ` Duncaen
2021-02-09 18:48 ` Duncaen
2021-02-10 17:11 ` heliocat
2021-05-13 16:34 ` [PR PATCH] [Updated] " heliocat
2021-06-08  5:30 ` heliocat
2021-06-08  5:31 ` heliocat
2021-06-08  5:33 ` heliocat
2021-06-08 13:18 ` ericonr
2021-06-11 22:53 ` [PR PATCH] [Updated] " heliocat
2021-06-11 22:54 ` heliocat
2021-06-12 18:12 ` ericonr
2021-06-12 22:13 ` heliocat
2021-06-12 22:14 ` [PR PATCH] [Updated] " heliocat
2021-06-12 22:15 ` heliocat
2021-06-13 17:11 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).