Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] gawk: fix tests
Date: Tue, 15 Jun 2021 22:02:53 +0200	[thread overview]
Message-ID: <20210615200253.IsmgiaSAJg1n8yZKe4ID6NAHOvHX2itvWTaJfIBJjMM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31497@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages gawk-fix-tests
https://github.com/void-linux/void-packages/pull/31497

gawk: fix tests
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31497.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-fix-tests-31497.patch --]
[-- Type: text/x-diff, Size: 816 bytes --]

From ccad6b9cca302dc86d0a39f5a19ba8f5ed0bd19e Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Mon, 17 May 2021 21:15:23 +0200
Subject: [PATCH] gawk: fix tests

---
 srcpkgs/gawk/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index 0a79c2ca2c5e..b922097b01f7 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -21,6 +21,11 @@ alternatives="
 pre_check() {
 	vsed -i 's/done | more/done/g' test/Makefile
 
+	# This fixes tests on glibc, relevant tests on musl are disabled
+	# because the locale command doesn't exist.
+	vsed -i 's/en_US.ISO-8859-1//' test/localenl.sh
+	vsed -i '/^LC_ALL=en_US.ISO-8859-1 passed$/d' test/localenl.ok
+
 	case "$XBPS_TARGET_MACHINE" in
 		*-musl)
 			vsed -i '/testext/d' test/Makefile

  parent reply	other threads:[~2021-06-15 20:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 16:04 [PR PATCH] " paper42
2021-06-14 18:06 ` ericonr
2021-06-14 18:59 ` paper42
2021-06-15 14:07 ` ericonr
2021-06-15 20:02 ` paper42 [this message]
2021-06-17  1:13 ` sgn
2021-06-17  1:13 ` sgn
2021-06-17  1:13 ` sgn
2022-03-29 21:13 ` [PR PATCH] [Updated] " paper42
2022-04-02 16:00 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615200253.IsmgiaSAJg1n8yZKe4ID6NAHOvHX2itvWTaJfIBJjMM@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).