From: Vaelatern <Vaelatern@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New packages: xplr-0.14.2
Date: Tue, 22 Jun 2021 17:51:07 +0200 [thread overview]
Message-ID: <20210622155107.6N4A5JlWmpcs5Tm2A5CY0tTN9IOOsFlYger86FKvVS0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31606@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/31606#issuecomment-866108168
Comment:
> > not for commit names, not for package style,
>
> Didn't understand these
Commit names are documented at the bottom of the Manual.
> > not for building
>
> By reading this [package-build-phases](https://github.com/void-linux/void-packages/blob/master/Manual.md#package-build-phases). I understand that I need to create `do_extract()` and `do_clean()`
No, you want to avoid creating any functions at all.
> > not for getting the distfiles,
>
> So I removed the `do_fetch()` and now it shows `ERROR: xplr-0.14.2_1: unknown distfile suffix for LICENSE.`
Better than having the `do_fetch`. This error can be fixed.
> > not for 1 package per PR (but acceptable in this case, please force push to this PR when you fix things, instead of losing history),
>
> Fixed this by removing xcolor PR
Acceptable, thank you for doing this and staying within this PR.
> > nor for supported architectures.
>
> Can't verify this but will look to build on a 32-bit architecture using virtualbox
`xbps-src` will cross build if you tell it to.
> If there are resources I can look into to gain knowledge, please share. I'm a fan of void and would like to contribute as a gesture for appreciation of this distro
The Manual is a great source. Between the Manual and README, you should have all the reference material necessary. You can also look at other rust packages to see how it's done there.
next prev parent reply other threads:[~2021-06-22 15:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:14 [PR PATCH] " shubham-cpp
2021-06-22 11:54 ` [PR REVIEW] " biopsin
2021-06-22 11:56 ` biopsin
2021-06-22 14:38 ` Vaelatern
2021-06-22 14:57 ` [PR REVIEW] " shubham-cpp
2021-06-22 15:01 ` shubham-cpp
2021-06-22 15:10 ` shubham-cpp
2021-06-22 15:16 ` Vaelatern
2021-06-22 15:42 ` shubham-cpp
2021-06-22 15:51 ` Vaelatern [this message]
2021-06-23 3:33 ` [PR PATCH] [Updated] " shubham-cpp
2021-06-23 3:38 ` shubham-cpp
2021-06-23 3:46 ` shubham-cpp
2021-06-23 4:05 ` Vaelatern
2021-06-23 4:24 ` shubham-cpp
2021-06-23 6:06 ` [PR PATCH] [Updated] " shubham-cpp
2021-06-23 6:10 ` shubham-cpp
2021-06-23 16:05 ` Vaelatern
2021-06-23 16:32 ` [PR REVIEW] " biopsin
2021-06-23 16:46 ` shubham-cpp
2021-06-23 17:09 ` Vaelatern
2021-06-23 17:10 ` Vaelatern
2021-06-23 18:01 ` shubham-cpp
2021-06-23 18:03 ` ericonr
2021-06-23 18:20 ` shubham-cpp
2021-06-23 18:21 ` [PR PATCH] [Closed]: " shubham-cpp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622155107.6N4A5JlWmpcs5Tm2A5CY0tTN9IOOsFlYger86FKvVS0@z \
--to=vaelatern@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).