From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: gnome-photos: remove an old patch
Date: Tue, 22 Jun 2021 22:24:07 +0200 [thread overview]
Message-ID: <20210622202407.mXo-obHTkkm4OxuCS1dHJCFW9ngzLj-74NAXJSuWvzE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31619@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31619#issuecomment-866308109
Comment:
```
[162/207] Compiling C object src/gnome-photos.p/photos-query-builder.c.o
../src/photos-query-builder.c: In function 'photos_query_builder_query':
../src/photos-query-builder.c:153:21: warning: implicit declaration of function 'photos_base_manager_get_sparql_template'; did you mean 'photos_base_manager_get_all_filter'? [-Wimplicit-function-declaration]
153 | sparql_template = photos_base_manager_get_sparql_template (state->srch_typ_mngr, flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| photos_base_manager_get_all_filter
../src/photos-query-builder.c:153:21: warning: nested extern declaration of 'photos_base_manager_get_sparql_template' [-Wnested-externs]
../src/photos-query-builder.c:153:19: warning: assignment to 'PhotosSparqlTemplate *' {aka 'struct _PhotosSparqlTemplate *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
153 | sparql_template = photos_base_manager_get_sparql_template (state->srch_typ_mngr, flags);
| ^
../src/photos-query-builder.c: In function 'photos_query_builder_count_query':
../src/photos-query-builder.c:284:19: warning: assignment to 'PhotosSparqlTemplate *' {aka 'struct _PhotosSparqlTemplate *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
284 | sparql_template = photos_base_manager_get_sparql_template (state->srch_typ_mngr, flags);
| ^
```
Why warnings matter (I have a PR to make this specific warning an error as well).
next prev parent reply other threads:[~2021-06-22 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 20:20 [PR PATCH] " paper42
2021-06-22 20:24 ` ericonr [this message]
2021-06-23 12:07 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622202407.mXo-obHTkkm4OxuCS1dHJCFW9ngzLj-74NAXJSuWvzE@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).