From: 4ricci <4ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] fossil: fix distfiles url
Date: Tue, 22 Jun 2021 23:08:40 +0200 [thread overview]
Message-ID: <20210622210840.F9EPO2VHihzt0GxH7XoAM7xCAjFidNfM0wPVkJ3_fJU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31614@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]
There is an updated pull request by 4ricci against master on the void-packages repository
https://github.com/4ricci/void-packages fossil-fix
https://github.com/void-linux/void-packages/pull/31614
fossil: fix distfiles url
Tarballs are [generated on demand](https://fossil-scm.org/home/help?cmd=/tarball) by fossil. The name of the file in the URL only specifies the name of the root directory inside the tarball, while the `release` parameter selects which tree to download.
All the URLs in the download page include a commit hash, which I wanted to avoid when I made #31609. I thought that omitting it was enough, but this resulted in downloading the most recent commit. Using the tag name works too.
<!-- Mark items with [x] where applicable -->
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)
#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31614.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fossil-fix-31614.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]
From 0901645a24c0fc49420b4ef9bd29df489a57064f Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Tue, 22 Jun 2021 11:49:17 +0200
Subject: [PATCH] fossil: fix distfiles url
Tarballs are generated on demand as described at
https://fossil-scm.org/home/help?cmd=/tarball.
The URL in our template has the form
https://fossil-scm.org/home/tarball/<release>/<name>.tar.gz,
where <release> is the commit hash or tag name (defaults to
"trunk" if omitted) and <name> is used as the top-level
directory inside the tarball.
---
srcpkgs/fossil/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/fossil/template b/srcpkgs/fossil/template
index 0f27d910cc7c..6612883fae57 100644
--- a/srcpkgs/fossil/template
+++ b/srcpkgs/fossil/template
@@ -11,9 +11,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
license="BSD-2-Clause"
homepage="https://www.fossil-scm.org"
changelog="https://www.fossil-scm.org/home/doc/trunk/www/changes.wiki"
-distfiles="https://www.fossil-scm.org/home/tarball/fossil-${version}.tar.gz"
-checksum=1844918eacdfa625e1d7efbec688875a6f89eb6c639edc12f158c46ba585494a
-broken="checksum changed after 4 hours https://github.com/void-linux/void-packages/pull/31609"
+distfiles="https://fossil-scm.org/home/tarball/version-${version}/fossil-${version}.tar.gz"
+checksum=39f5a3960ebaa4984fcc953c3307ead5c0f21da4f66ecad516872f89843fcf79
post_extract() {
vsed -i 's/test_system_sqlite$/# &/' auto.def # failing on cross
next prev parent reply other threads:[~2021-06-22 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 16:33 [PR PATCH] " 4ricci
2021-06-22 17:04 ` Piraty
2021-06-22 18:30 ` 4ricci
2021-06-22 19:26 ` ericonr
2021-06-22 21:08 ` 4ricci [this message]
2021-06-23 0:29 ` sgn
2021-06-23 0:29 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622210840.F9EPO2VHihzt0GxH7XoAM7xCAjFidNfM0wPVkJ3_fJU@z \
--to=4ricci@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).