From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] cmake less cursed template, ship manpages, switch GUI to Qt6, and update
Date: Wed, 23 Jun 2021 02:53:56 +0200 [thread overview]
Message-ID: <20210623005356.13A7iilBEIR8lfP_bh_oOVr2701oepxGpzinXJOIfh8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31615@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/31615#discussion_r656677955
Comment:
I would say, let's remove those `hostmakedepends` in `environment`, force template add them explicitly.
next prev parent reply other threads:[~2021-06-23 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 16:39 [PR PATCH] " sgn
2021-06-23 0:52 ` [PR REVIEW] " ericonr
2021-06-23 0:52 ` ericonr
2021-06-23 0:53 ` sgn [this message]
2021-06-23 0:55 ` sgn
2021-06-28 15:33 ` [PR PATCH] [Updated] " sgn
2021-07-02 0:14 ` sgn
2021-07-02 0:28 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623005356.13A7iilBEIR8lfP_bh_oOVr2701oepxGpzinXJOIfh8@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).