From: Logarithmus <Logarithmus@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] zita-convolver: add fftw-devel dependency to zita-convolver-devel
Date: Sun, 27 Jun 2021 17:55:21 +0200 [thread overview]
Message-ID: <20210627155521.1xIcy5meBKGHnH6KD-ofxpbCoks0EACozuiuuVjd_Ag@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31666@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
There is an updated pull request by Logarithmus against master on the void-packages repository
https://github.com/Logarithmus/void-packages fix-zita-convolver-devel
https://github.com/void-linux/void-packages/pull/31666
zita-convolver: add fftw-devel dependency to zita-convolver-devel
<!-- Mark items with [x] where applicable -->
Without this change the packages which depend on `zita-convolver-devel` fail to compile due to missing `ftw3.h` header.
#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!--
#### Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
- [ ] aarch64-musl
- [ ] armv7l
- [ ] armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/31666.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-zita-convolver-devel-31666.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From 2d3eff3d4bea2e0f688e9d79dbcff464142d28b0 Mon Sep 17 00:00:00 2001
From: Artur Sinila <freesoftware@logarithmus.dev>
Date: Fri, 25 Jun 2021 22:07:03 +0300
Subject: [PATCH] zita-convolver: add fftw-devel dependency to
zita-convolver-devel
---
srcpkgs/zita-convolver/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/zita-convolver/template b/srcpkgs/zita-convolver/template
index fb0371162b03..39bc33d20a09 100644
--- a/srcpkgs/zita-convolver/template
+++ b/srcpkgs/zita-convolver/template
@@ -1,7 +1,7 @@
# Template file for 'zita-convolver'
pkgname=zita-convolver
version=4.0.3
-revision=2
+revision=3
build_wrksrc="source"
build_style=gnu-makefile
make_install_args="LIBDIR=/usr/lib"
@@ -14,7 +14,7 @@ homepage="http://kokkinizita.linuxaudio.org/linuxaudio/"
distfiles="http://kokkinizita.linuxaudio.org/linuxaudio/downloads/${pkgname}-${version}.tar.bz2"
checksum=9aa11484fb30b4e6ef00c8a3281eebcfad9221e3937b1beb5fe21b748d89325f
-CXXFLAGS="-fPIC -ffast-math -funroll-loops"
+CXXFLAGS="$CXXFLAGS -fPIC"
post_install() {
# add missing symlink
@@ -22,7 +22,7 @@ post_install() {
}
zita-convolver-devel_package() {
- depends="${sourcepkg}-${version}_${revision}"
+ depends="${sourcepkg}>=${version}_${revision} fftw-devel"
short_desc+=" - development files"
pkg_install() {
vmove usr/include
next prev parent reply other threads:[~2021-06-27 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:03 [PR PATCH] zita-convolver-devel: add fftw-devel dependency Logarithmus
2021-06-26 19:34 ` [PR REVIEW] " ericonr
2021-06-26 19:34 ` ericonr
2021-06-26 19:34 ` ericonr
2021-06-27 15:49 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 15:53 ` [PR REVIEW] zita-convolver: add fftw-devel dependency to zita-convolver-devel Logarithmus
2021-06-27 15:55 ` Logarithmus [this message]
2021-06-27 15:58 ` Logarithmus
2022-05-24 2:13 ` github-actions
2022-05-24 12:06 ` paper42
2022-05-24 12:06 ` [PR PATCH] [Closed]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210627155521.1xIcy5meBKGHnH6KD-ofxpbCoks0EACozuiuuVjd_Ag@z \
--to=logarithmus@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).