From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] pulseeffects: update to 5.0.4
Date: Sun, 27 Jun 2021 18:52:00 +0200 [thread overview]
Message-ID: <20210627165200.D_VAiKuMlZRYkabEkvXg8OKrtQ2Yh3u_diAf0Aa7jP0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31667@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31667#discussion_r659344621
Comment:
I don't generally see a problem with installing a readme file, some readmes provide useful quick start guides, but I don't see a reason in this case. The information inside is not useful imo for void users. There are some screenshots, list of effects available (accessible from inside the application, so not useful imo), links to packages for distributions (useless) and other for us useless parts. The only part that could be interesting to users are the packages needed for plugins, but we already established that people can get that information from inside the application.
I think many of the packages which install a README don't have to, but I think that should be solved on a case by case basis when someone touches the package. If you ever update a package and notice it installs a readme that is not useful, I am sure void maintainers wouldn't mind if you removed it.
I am not a maintainer, so I might be wrong, but I don't see any value in installing this particular readme.
next prev parent reply other threads:[~2021-06-27 16:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:21 [PR PATCH] " Logarithmus
2021-06-26 19:34 ` [PR REVIEW] " paper42
2021-06-26 19:35 ` paper42
2021-06-26 19:36 ` paper42
2021-06-26 19:38 ` ericonr
2021-06-26 19:38 ` ericonr
2021-06-26 19:38 ` ericonr
2021-06-27 15:15 ` Logarithmus
2021-06-27 15:22 ` Logarithmus
2021-06-27 15:23 ` Logarithmus
2021-06-27 15:35 ` Logarithmus
2021-06-27 15:38 ` Logarithmus
2021-06-27 15:45 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 16:07 ` [PR REVIEW] " paper42
2021-06-27 16:14 ` Logarithmus
2021-06-27 16:19 ` paper42
2021-06-27 16:21 ` Logarithmus
2021-06-27 16:52 ` paper42 [this message]
2021-06-27 18:34 ` Duncaen
2021-06-27 18:55 ` Logarithmus
2021-06-27 18:58 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 19:04 ` [PR REVIEW] " Duncaen
2021-06-27 19:05 ` Duncaen
2021-06-27 19:06 ` Duncaen
2021-06-27 22:12 ` paper42
2021-06-27 22:12 ` paper42
2021-06-27 22:24 ` [PR PATCH] [Updated] " Logarithmus
2021-06-27 22:37 ` [PR REVIEW] " Logarithmus
2021-06-27 22:37 ` Logarithmus
2021-06-27 22:42 ` Duncaen
2021-06-27 22:46 ` paper42
2021-06-27 22:47 ` paper42
2021-06-27 22:54 ` Logarithmus
2021-06-27 22:54 ` Logarithmus
2021-06-28 0:11 ` [PR PATCH] [Updated] " Logarithmus
2021-06-28 0:12 ` [PR REVIEW] " Logarithmus
2021-06-28 8:19 ` paper42
2021-06-28 8:28 ` paper42
2021-06-28 8:31 ` paper42
2021-06-28 9:00 ` [PR REVIEW] " Logarithmus
2021-06-29 1:55 ` [PR PATCH] [Updated] " Logarithmus
2021-06-29 1:55 ` [PR REVIEW] " Logarithmus
2021-06-29 1:58 ` [PR PATCH] [Updated] " Logarithmus
2021-06-29 1:58 ` Logarithmus
2021-07-02 22:58 ` paper42
2021-07-02 23:03 ` [PR PATCH] [Updated] " Logarithmus
2021-07-02 23:04 ` Logarithmus
2021-07-02 23:44 ` paper42
2021-07-02 23:54 ` [PR PATCH] [Updated] " Logarithmus
2021-07-02 23:56 ` Logarithmus
2021-07-03 10:13 ` paper42
2021-07-03 11:42 ` [PR PATCH] [Updated] " Logarithmus
2021-07-03 11:44 ` Logarithmus
2021-07-14 14:32 ` paper42
2021-07-14 14:36 ` Logarithmus
2021-07-17 2:54 ` [PR PATCH] [Merged]: " ericonr
2021-07-17 4:09 ` ericonr
2021-07-17 4:09 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210627165200.D_VAiKuMlZRYkabEkvXg8OKrtQ2Yh3u_diAf0Aa7jP0@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).