Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: limine-2.24
@ 2021-06-25 22:21 mintsuki
  2021-06-26  6:34 ` Anachron
                   ` (44 more replies)
  0 siblings, 45 replies; 46+ messages in thread
From: mintsuki @ 2021-06-25 22:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

There is a new pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1425 bytes --]

From 1f6f0fcda99590c9b92402c42c0e9a6d2dc3ee94 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 00:15:43 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..d40a5d17a79d
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,37 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+do_fetch() {
+	git clone --depth=1 --branch=v$version https://github.com/limine-bootloader/limine.git limine-$version
+}
+
+# This is necessary because /etc/mtools.conf contains a syntax error that makes mtools fail.
+post_fetch() {
+	mv /etc/mtools.conf /etc/mtools.conf.orig
+}
+
+do_build() {
+	make
+}
+
+# Restore original /etc/mtools.conf
+post_build() {
+	mv /etc/mtools.conf.orig /etc/mtools.conf
+}
+
+do_install() {
+	make install PREFIX="/usr" DESTDIR="$DESTDIR"
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
@ 2021-06-26  6:34 ` Anachron
  2021-06-26 11:38 ` [PR PATCH] [Updated] " mintsuki
                   ` (43 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Anachron @ 2021-06-26  6:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868956881

Comment:
- Pull in files using distfiles
- Use the make build_style
- Fix /etc/mtools.conf (vsed) instead of moving it
- Check if more archs/musl is supported

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
  2021-06-26  6:34 ` Anachron
@ 2021-06-26 11:38 ` mintsuki
  2021-06-26 11:51 ` mintsuki
                   ` (42 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 11:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1475 bytes --]

From f0f74b0c31b6ebbaa182bc9da454261c6fdfbf60 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 13:38:25 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..e18fac5caece
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,37 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+do_fetch() {
+	git clone --depth=1 --branch=v$version https://github.com/limine-bootloader/limine.git limine-$version
+}
+
+# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+pre_build() {
+	vsed -i /etc/mtools.conf -e 's/SAMPLE FILE/#### SAMPLE FILE/g'
+}
+
+do_build() {
+	make
+}
+
+# Restore original /etc/mtools.conf
+post_build() {
+	vsed -i /etc/mtools.conf -e 's/#### SAMPLE FILE/SAMPLE FILE/g'
+}
+
+do_install() {
+	make install PREFIX="/usr" DESTDIR="$DESTDIR"
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
  2021-06-26  6:34 ` Anachron
  2021-06-26 11:38 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 11:51 ` mintsuki
  2021-06-26 11:55 ` mintsuki
                   ` (41 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 11:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1380 bytes --]

From 57b708fc3159ce28daefd11af9a638a12ec24da6 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 13:51:30 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..5d907dcd9b56
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,30 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	make install PREFIX="/usr" DESTDIR="$DESTDIR"
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (2 preceding siblings ...)
  2021-06-26 11:51 ` mintsuki
@ 2021-06-26 11:55 ` mintsuki
  2021-06-26 11:55 ` [PR REVIEW] " Johnnynator
                   ` (40 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 11:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868990532

Comment:
- The `make` build_style does not seem to exist.
- Limine is exclusively for x86_64 and will not build on other architectures. musl support is irrelevant as the bootloader does not utilise the system's C library. `limine-install` builds with musl.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (3 preceding siblings ...)
  2021-06-26 11:55 ` mintsuki
@ 2021-06-26 11:55 ` Johnnynator
  2021-06-26 11:55 ` Johnnynator
                   ` (39 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 11:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659159172

Comment:
Your short_desc says
> Advanced x86/x86_64 BIOS and UEFI bootloader
so `archs="x86_64* i686*"` sounds more appropriate
If it is broken for some reaoson on `*musl` or `i686` than document the reason (and set a apporpiate `broken=` statement in the template

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (4 preceding siblings ...)
  2021-06-26 11:55 ` [PR REVIEW] " Johnnynator
@ 2021-06-26 11:55 ` Johnnynator
  2021-06-26 11:57 ` mintsuki
                   ` (38 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 11:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659159172

Comment:
Your short_desc says
> Advanced x86/x86_64 BIOS and UEFI bootloader

so `archs="x86_64* i686*"` sounds more appropriate
If it is broken for some reaoson on `*musl` or `i686` than document the reason (and set a apporpiate `broken=` statement in the template

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (5 preceding siblings ...)
  2021-06-26 11:55 ` Johnnynator
@ 2021-06-26 11:57 ` mintsuki
  2021-06-26 11:57 ` Johnnynator
                   ` (37 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

New review comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659159326

Comment:
On i686 it would need to either disable the UEFI component or use a 64 bit cross compiler, any suggestion? And it works on musl just fine.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (6 preceding siblings ...)
  2021-06-26 11:57 ` mintsuki
@ 2021-06-26 11:57 ` Johnnynator
  2021-06-26 11:57 ` mintsuki
                   ` (36 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868990739

Comment:
> Limine is exclusively for x86_64 and will not build on other architectures. musl support is irrelevant as the bootloader does not utilise the system's C library. limine-install builds with musl.

archs in void kinda incorrectly includes musl variants separately. So you always need to use a wildcard, so the package is getting build also for musl systems

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (7 preceding siblings ...)
  2021-06-26 11:57 ` Johnnynator
@ 2021-06-26 11:57 ` mintsuki
  2021-06-26 11:58 ` [PR REVIEW] " Johnnynator
                   ` (35 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868990826

Comment:
Okay, will do.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (8 preceding siblings ...)
  2021-06-26 11:57 ` mintsuki
@ 2021-06-26 11:58 ` Johnnynator
  2021-06-26 12:00 ` [PR PATCH] [Updated] " mintsuki
                   ` (34 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 11:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659159453

Comment:
Nah, using a 64bit cross on i686 is messy. If you can get it easly to only build the 32bit bios component, than do that. Otherwise just keep it `x86_64*`

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (9 preceding siblings ...)
  2021-06-26 11:58 ` [PR REVIEW] " Johnnynator
@ 2021-06-26 12:00 ` mintsuki
  2021-06-26 12:00 ` mintsuki
                   ` (33 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1381 bytes --]

From e5a44dc7e779d627142a005d0fa72a63be843d54 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 13:59:59 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..e2d926740f1b
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,30 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64*"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	make install PREFIX="/usr" DESTDIR="$DESTDIR"
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (10 preceding siblings ...)
  2021-06-26 12:00 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 12:00 ` mintsuki
  2021-06-26 12:04 ` [PR REVIEW] " mintsuki
                   ` (32 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868991127

Comment:
For now I enabled musl, until I figure out how to get a working i686 build.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (11 preceding siblings ...)
  2021-06-26 12:00 ` mintsuki
@ 2021-06-26 12:04 ` mintsuki
  2021-06-26 12:05 ` mintsuki
                   ` (31 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659160021

Comment:
Will do.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (12 preceding siblings ...)
  2021-06-26 12:04 ` [PR REVIEW] " mintsuki
@ 2021-06-26 12:05 ` mintsuki
  2021-06-26 12:21 ` mintsuki
                   ` (30 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868991745

Comment:
Okay seems that musl has broken `stdint.h` typedefs for fixed width integers when compiling code with `-m32`. Wonderful.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (13 preceding siblings ...)
  2021-06-26 12:05 ` mintsuki
@ 2021-06-26 12:21 ` mintsuki
  2021-06-26 12:21 ` mintsuki
                   ` (29 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868993552

Comment:
The Limine repository ships a cross toolchain. It would be possible to work around all these issues, in addition to letting Limine build on non-x86 architectures by letting it build its own toolchain. Obviously that takes some time though.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (14 preceding siblings ...)
  2021-06-26 12:21 ` mintsuki
@ 2021-06-26 12:21 ` mintsuki
  2021-06-26 12:23 ` [PR PATCH] [Updated] " mintsuki
                   ` (28 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868993552

Comment:
The Limine repository ships a cross toolchain. It would be possible to work around all these issues, in addition to letting Limine build on non-x86 architectures, by letting it build its own toolchain. Obviously that takes some time though.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (15 preceding siblings ...)
  2021-06-26 12:21 ` mintsuki
@ 2021-06-26 12:23 ` mintsuki
  2021-06-26 12:26 ` mintsuki
                   ` (27 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1861 bytes --]

From 33ec352fa2f3410f7a455f2116f464d418585c6c Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 14:23:22 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..25045064f3d0
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,42 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64 i686"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+}
+
+do_build() {
+	if [ "$XBPS_MACHINE" = "x86_64" ]; then
+		make limine-bios limine-uefi
+	elif [ "$XBPS_MACHINE" = "i686" ]; then
+		make limine-bios
+	fi
+	make bin/limine-install
+}
+
+do_install() {
+	vinstall bin/limine-install 755 /usr/bin
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	if [ "$XBPS_MACHINE" = "x86_64" ]; then
+		vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+		vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+	fi
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (16 preceding siblings ...)
  2021-06-26 12:23 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 12:26 ` mintsuki
  2021-06-26 12:28 ` mintsuki
                   ` (26 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1844 bytes --]

From 177c5f73ff37ace067e2aad728f7d7bf62eb2d0f Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 14:26:05 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 42 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..1fc4654d1e86
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,42 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64 i686"
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+}
+
+do_build() {
+	if [ "$XBPS_MACHINE" = "x86_64" ]; then
+		make limine-bios limine-uefi
+	elif [ "$XBPS_MACHINE" = "i686" ]; then
+		make limine-bios
+	fi
+	make bin/limine-install
+}
+
+do_install() {
+	vbin bin/limine-install
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	if [ "$XBPS_MACHINE" = "x86_64" ]; then
+		vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+		vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+	fi
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (17 preceding siblings ...)
  2021-06-26 12:26 ` mintsuki
@ 2021-06-26 12:28 ` mintsuki
  2021-06-26 12:31 ` [PR PATCH] [Updated] " mintsuki
                   ` (25 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868994313

Comment:
I will try doing what I mentioned, I hope I won't make the CI explode :)

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (18 preceding siblings ...)
  2021-06-26 12:28 ` mintsuki
@ 2021-06-26 12:31 ` mintsuki
  2021-06-26 12:34 ` mintsuki
                   ` (24 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1652 bytes --]

From da381a6c796124f983710f40451d1c2a6fa7b9a6 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 14:31:38 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..16bbb2aba9c7
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,36 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64 i686"
+hostmakedepends="which wget nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+	make toolchain
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin bin/limine-install
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (19 preceding siblings ...)
  2021-06-26 12:31 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 12:34 ` mintsuki
  2021-06-26 13:04 ` mintsuki
                   ` (23 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 12:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1658 bytes --]

From 2758e04a046ba24857f8db4a6c8e142cb04018bf Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 14:34:30 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..e54b3e62c36b
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,36 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64* i686*"
+hostmakedepends="which wget nasm mtools git tar"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+	make toolchain
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin bin/limine-install
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (20 preceding siblings ...)
  2021-06-26 12:34 ` mintsuki
@ 2021-06-26 13:04 ` mintsuki
  2021-06-26 13:12 ` [PR PATCH] [Updated] " mintsuki
                   ` (22 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 13:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-868998211

Comment:
```
In file included from ../../../gcc-11.1.0/libgcc/libgcov-merge.c:26:
../../../gcc-11.1.0/libgcc/libgcov.h:49:10: fatal error: sys/mman.h: No such file or directory
   49 | #include <sys/mman.h>
      |          ^~~~~~~~~~~~
```
Can not find `sys/mman.h`? That surely is odd; am I missing something?

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (21 preceding siblings ...)
  2021-06-26 13:04 ` mintsuki
@ 2021-06-26 13:12 ` mintsuki
  2021-06-26 13:34 ` mintsuki
                   ` (21 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1755 bytes --]

From ecf353655fef1eb98223f7f0b5fe3e3a4db0282b Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 15:12:25 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..4bc646db5cde
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,37 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64* i686*"
+hostmakedepends="which wget nasm mtools git tar"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i scripts/make_toolchain.sh -e 's/--without-headers/--disable-gcov --without-headers/g'
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	# This is necessary because stock /etc/mtools.conf may contain a syntax error that makes mtools fail.
+	vsed -i /etc/mtools.conf -e 's/^SAMPLE FILE/#### SAMPLE FILE/g'
+	make toolchain
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin bin/limine-install
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (22 preceding siblings ...)
  2021-06-26 13:12 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 13:34 ` mintsuki
  2021-06-26 13:44 ` [PR REVIEW] " Johnnynator
                   ` (20 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 13:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 1632 bytes --]

From 08b320596c4411258f22316510c78a7d4034e4ff Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 15:34:04 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..a3246bb2d4a1
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,36 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64* i686*"
+hostmakedepends="which wget nasm mtools git tar"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz"
+checksum=8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+
+pre_build() {
+	vsed -i Makefile -e 's/AR=/ARCH=x86_64 AR=/g'
+	vsed -i scripts/make_toolchain.sh -e 's/--without-headers/--disable-gcov --without-headers/g'
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	make toolchain
+}
+
+do_build() {
+	make
+}
+
+do_install() {
+	vbin bin/limine-install
+	vinstall bin/limine.sys 644 /usr/share/limine
+	vinstall bin/limine-cd.bin 644 /usr/share/limine
+	vinstall bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (23 preceding siblings ...)
  2021-06-26 13:34 ` mintsuki
@ 2021-06-26 13:44 ` Johnnynator
  2021-06-26 13:44 ` Johnnynator
                   ` (19 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 13:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659166811

Comment:
The way this package uses git is a no-go. git repos should never be downloaded at build time.
Similiar with `wget`, every file fetched should preferably be in distfiles and have a checksum, the build scripts do no even try to verify if a downloaded file is correct/didn't change.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (24 preceding siblings ...)
  2021-06-26 13:44 ` [PR REVIEW] " Johnnynator
@ 2021-06-26 13:44 ` Johnnynator
  2021-06-26 13:59 ` mintsuki
                   ` (18 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 13:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659166447

Comment:
Can be removed, fixed in the pacakge 4d8dcfcf7a33439d7abab56985004b08707caa38

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (25 preceding siblings ...)
  2021-06-26 13:44 ` Johnnynator
@ 2021-06-26 13:59 ` mintsuki
  2021-06-26 14:02 ` mintsuki
                   ` (17 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 13:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659171278

Comment:
Ideally since they download over `https` there should be no malicious tampering done at download time. It would be possible to download the packages needed using distfiles ahead of time anyways, will do that.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (26 preceding siblings ...)
  2021-06-26 13:59 ` mintsuki
@ 2021-06-26 14:02 ` mintsuki
  2021-06-26 14:03 ` mintsuki
                   ` (16 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 14:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869008021

Comment:
> Building a full gcc toolchain will end painfull. You can try to use add `cross-x86_64-linux-gnu` for `i686*` and `x86_64-musl` builds. (I initial forgot that we have it available on `i686` nowadays).
> 
> So you can add this after checksum
> 
> ```shell
> case "$XBPS_TARGET_MACHINE" in
>         x86_64);;
>         *) hostmakedepends+=" cross-x86_64-linux-gnu";;
> esac
> ```
> 
> and this as do_build
> 
> ```shell
> do_build() {
>         if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
>                 make
>         else
>                 CFLAGS="" make CROSS_COMPILE="x86_64-linux-gnu-" \
>                         CC="x86_64-linux-gnu-gcc" TOOLCHAIN="x86_64-linux-gnu" \
>                         CC_TOOLCHAIN="x86_64-linux-gnu-gcc"
>                 make bin/limine-install TOOLCHAIN="x86_64-linux-gnu"
>         fi
> }
> ```
> 
> The build system does all kinds of wonky assumptions, this should workaround most/all of them.

It needs a cross compiler on musl too, or alternatively an implementation of `stdint.h` that works. Using the provided cross compiler would be ideal.

The cross compiler *does* build, and if you see above, everything builds fine too, except `i686` where I assume the build system passes `-mtune=i686` to the CFLAGS when it should not do that as it will break stuff.

This can also easily be worked around by just unsetting the `CFLAGS` or stripping out the `-mtune` flag from them.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (27 preceding siblings ...)
  2021-06-26 14:02 ` mintsuki
@ 2021-06-26 14:03 ` mintsuki
  2021-06-26 14:04 ` mintsuki
                   ` (15 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 14:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869008021

Comment:
> Building a full gcc toolchain will end painfull. You can try to use add `cross-x86_64-linux-gnu` for `i686*` and `x86_64-musl` builds. (I initial forgot that we have it available on `i686` nowadays).
> 
> So you can add this after checksum
> 
> ```shell
> case "$XBPS_TARGET_MACHINE" in
>         x86_64);;
>         *) hostmakedepends+=" cross-x86_64-linux-gnu";;
> esac
> ```
> 
> and this as do_build
> 
> ```shell
> do_build() {
>         if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
>                 make
>         else
>                 CFLAGS="" make CROSS_COMPILE="x86_64-linux-gnu-" \
>                         CC="x86_64-linux-gnu-gcc" TOOLCHAIN="x86_64-linux-gnu" \
>                         CC_TOOLCHAIN="x86_64-linux-gnu-gcc"
>                 make bin/limine-install TOOLCHAIN="x86_64-linux-gnu"
>         fi
> }
> ```
> 
> The build system does all kinds of wonky assumptions, this should workaround most/all of them.

It needs a cross compiler on musl too, or alternatively an implementation of `stdint.h` that works. Using the provided cross compiler would be ideal.

The cross compiler *does* build, and check the CI, everything else builds fine too, except `i686` where I assume the build system passes `-mtune=i686` to the CFLAGS when it should not do that as it will break stuff.

This can also easily be worked around by just unsetting the `CFLAGS` or stripping out the `-mtune` flag from them.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (28 preceding siblings ...)
  2021-06-26 14:03 ` mintsuki
@ 2021-06-26 14:04 ` mintsuki
  2021-06-26 14:05 ` mintsuki
                   ` (14 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 14:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869008021

Comment:
> Building a full gcc toolchain will end painfull. You can try to use add `cross-x86_64-linux-gnu` for `i686*` and `x86_64-musl` builds. (I initial forgot that we have it available on `i686` nowadays).
> 
> So you can add this after checksum
> 
> ```shell
> case "$XBPS_TARGET_MACHINE" in
>         x86_64);;
>         *) hostmakedepends+=" cross-x86_64-linux-gnu";;
> esac
> ```
> 
> and this as do_build
> 
> ```shell
> do_build() {
>         if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
>                 make
>         else
>                 CFLAGS="" make CROSS_COMPILE="x86_64-linux-gnu-" \
>                         CC="x86_64-linux-gnu-gcc" TOOLCHAIN="x86_64-linux-gnu" \
>                         CC_TOOLCHAIN="x86_64-linux-gnu-gcc"
>                 make bin/limine-install TOOLCHAIN="x86_64-linux-gnu"
>         fi
> }
> ```
> 
> The build system does all kinds of wonky assumptions, this should workaround most/all of them.

It needs a cross compiler on musl too, or alternatively an implementation of `stdint.h` that works. Using the provided cross compiler would be ideal.

The cross compiler *does* build, and check the CI, everything else builds fine too, except on `i686`, where I assume the build system passes `-mtune=i686` as part of the CFLAGS when it should not do that, as it will break stuff related to `gnu-efi`.

This can also easily be worked around by just unsetting the `CFLAGS` or stripping out the `-mtune` flag from them.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (29 preceding siblings ...)
  2021-06-26 14:04 ` mintsuki
@ 2021-06-26 14:05 ` mintsuki
  2021-06-26 14:06 ` mintsuki
                   ` (13 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 14:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869008021

Comment:
> Building a full gcc toolchain will end painfull. You can try to use add `cross-x86_64-linux-gnu` for `i686*` and `x86_64-musl` builds. (I initial forgot that we have it available on `i686` nowadays).
> 
> So you can add this after checksum
> 
> ```shell
> case "$XBPS_TARGET_MACHINE" in
>         x86_64);;
>         *) hostmakedepends+=" cross-x86_64-linux-gnu";;
> esac
> ```
> 
> and this as do_build
> 
> ```shell
> do_build() {
>         if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
>                 make
>         else
>                 CFLAGS="" make CROSS_COMPILE="x86_64-linux-gnu-" \
>                         CC="x86_64-linux-gnu-gcc" TOOLCHAIN="x86_64-linux-gnu" \
>                         CC_TOOLCHAIN="x86_64-linux-gnu-gcc"
>                 make bin/limine-install TOOLCHAIN="x86_64-linux-gnu"
>         fi
> }
> ```
> 
> The build system does all kinds of wonky assumptions, this should workaround most/all of them.

It needs a cross compiler on musl too, or alternatively an implementation of `stdint.h` that works. Using the provided cross compiler would be ideal.

The cross compiler *does* build, and if you check the CI, everything else builds fine too, except on `i686`, where I assume the build system passes `-mtune=i686` as part of the CFLAGS when it should not do that, as it will break stuff related to `gnu-efi`.

This can also easily be worked around by just unsetting the `CFLAGS` or stripping out the `-mtune` flag from them.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (30 preceding siblings ...)
  2021-06-26 14:05 ` mintsuki
@ 2021-06-26 14:06 ` mintsuki
  2021-06-26 14:11 ` [PR REVIEW] " Johnnynator
                   ` (12 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 14:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869008021

Comment:
> Building a full gcc toolchain will end painfull. You can try to use add `cross-x86_64-linux-gnu` for `i686*` and `x86_64-musl` builds. (I initial forgot that we have it available on `i686` nowadays).
> 
> So you can add this after checksum
> 
> ```shell
> case "$XBPS_TARGET_MACHINE" in
>         x86_64);;
>         *) hostmakedepends+=" cross-x86_64-linux-gnu";;
> esac
> ```
> 
> and this as do_build
> 
> ```shell
> do_build() {
>         if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
>                 make
>         else
>                 CFLAGS="" make CROSS_COMPILE="x86_64-linux-gnu-" \
>                         CC="x86_64-linux-gnu-gcc" TOOLCHAIN="x86_64-linux-gnu" \
>                         CC_TOOLCHAIN="x86_64-linux-gnu-gcc"
>                 make bin/limine-install TOOLCHAIN="x86_64-linux-gnu"
>         fi
> }
> ```
> 
> The build system does all kinds of wonky assumptions, this should workaround most/all of them.

It needs a cross compiler on musl too, or alternatively an implementation of `stdint.h` that works. Using the provided cross compiler would be ideal.

The cross compiler *does* build, and if you check the CI, everything else builds fine too, except on `i686`, where I assume the build system passes `-mtune=i686` as part of the `CFLAGS` when it should not do that, as it will break stuff related to `gnu-efi`.

This can also easily be worked around by just unsetting the `CFLAGS` or stripping out the `-mtune` flag from them.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (31 preceding siblings ...)
  2021-06-26 14:06 ` mintsuki
@ 2021-06-26 14:11 ` Johnnynator
  2021-06-26 14:11 ` Johnnynator
                   ` (11 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 14:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659172523

Comment:
This isn't mainly about mailicous, but about reproducibility and such. It isn't that uncommon that someone randomly changes a tag or so.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (32 preceding siblings ...)
  2021-06-26 14:11 ` [PR REVIEW] " Johnnynator
@ 2021-06-26 14:11 ` Johnnynator
  2021-06-26 14:16 ` Johnnynator
                   ` (10 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 14:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659172523

Comment:
This isn't only about preventing mailicous actors, but about reproducibility and such. It isn't that uncommon that someone randomly changes a tag or so.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (33 preceding siblings ...)
  2021-06-26 14:11 ` Johnnynator
@ 2021-06-26 14:16 ` Johnnynator
  2021-06-26 15:02 ` [PR PATCH] [Updated] " mintsuki
                   ` (9 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-26 14:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659173156

Comment:
Also using `distfiles` allows us to cache the file, so it doesn't need to be downloaded for every run for every arch.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (34 preceding siblings ...)
  2021-06-26 14:16 ` Johnnynator
@ 2021-06-26 15:02 ` mintsuki
  2021-06-26 15:06 ` mintsuki
                   ` (8 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 2519 bytes --]

From e159a6435289d693e1380abfab3b2c3f1e33b1ca Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 17:01:55 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 54 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..d2191e018673
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,54 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+create_wrksrc=yes
+archs="x86_64* i686*"
+hostmakedepends="which nasm mtools git tar"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz>limine.tar.gz https://github.com/stivale/stivale/archive/f8d1674dfa0241d990339dc52fbaf56319e690a7.tar.gz>stivale.tar.gz https://netcologne.dl.sourceforge.net/project/gnu-efi/gnu-efi-3.0.13.tar.bz2"
+checksum="8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172 508035442f453fbda116735d041d18daf3a47fe28d4318ba2e8360a5f3af9f12 2fccf715279c46ee69c4859186af8150d07a13f4d19876e5459cd65be82d3b7d"
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64);;
+	*) hostmakedepends+=" cross-x86_64-linux-gnu";;
+esac
+
+pre_build() {
+	cd limine-$version
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	mv ../stivale-f8d1674dfa0241d990339dc52fbaf56319e690a7 ./stivale
+	mv ../gnu-efi-3.0.13 ./gnu-efi
+}
+
+do_build() {
+	cd limine-$version
+	if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
+		CC="gcc"
+		AR="ar"
+		TOOLCHAIN=""
+	else
+		CC="x86_64-linux-gnu-gcc"
+		AR="x86_64-linux-gnu-ar"
+		TOOLCHAIN="TOOLCHAIN=x86_64-linux-gnu"
+	fi
+	CFLAGS="" make -C gnu-efi/gnuefi CC="$CC" AR="$AR"
+	CFLAGS="" make -C gnu-efi/lib CC="$CC" ARCH=x86_64 x86_64/efi_stub.o
+	CFLAGS="" make $TOOLCHAIN
+}
+
+do_install() {
+	vbin limine-$version/bin/limine-install
+	vinstall limine-$version/bin/limine.sys 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-cd.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense limine-$version/LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (35 preceding siblings ...)
  2021-06-26 15:02 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-26 15:06 ` mintsuki
  2021-06-26 15:10 ` mintsuki
                   ` (7 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 15:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 2534 bytes --]

From 3155b77ba1d51dd98a0ba3df4a3e5cae867a1507 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sat, 26 Jun 2021 17:06:34 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 54 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..2c5a9ee18980
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,54 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64* i686*"
+create_wrksrc=yes
+hostmakedepends="which nasm mtools git tar"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz>limine.tar.gz https://github.com/stivale/stivale/archive/f8d1674dfa0241d990339dc52fbaf56319e690a7.tar.gz>stivale.tar.gz https://netcologne.dl.sourceforge.net/project/gnu-efi/gnu-efi-3.0.13.tar.bz2"
+checksum="8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172 508035442f453fbda116735d041d18daf3a47fe28d4318ba2e8360a5f3af9f12 2fccf715279c46ee69c4859186af8150d07a13f4d19876e5459cd65be82d3b7d"
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64);;
+	*) hostmakedepends+=" cross-x86_64-linux-gnu";;
+esac
+
+pre_build() {
+	cd limine-$version
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	mv ../stivale-f8d1674dfa0241d990339dc52fbaf56319e690a7 ./stivale
+	mv ../gnu-efi-3.0.13 ./gnu-efi
+}
+
+do_build() {
+	cd limine-$version
+	if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
+		CC="gcc"
+		AR="ar"
+		unset TOOLCHAIN
+	else
+		CC="x86_64-linux-gnu-gcc"
+		AR="x86_64-linux-gnu-ar"
+		TOOLCHAIN="TOOLCHAIN=x86_64-linux-gnu"
+	fi
+	CFLAGS="" make -C gnu-efi/gnuefi CC="$CC" ARCH=x86_64 AR="$AR"
+	CFLAGS="" make -C gnu-efi/lib CC="$CC" ARCH=x86_64 x86_64/efi_stub.o
+	CFLAGS="" make $TOOLCHAIN
+}
+
+do_install() {
+	vbin limine-$version/bin/limine-install
+	vinstall limine-$version/bin/limine.sys 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-cd.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-eltorito-efi.bin 644 /usr/share/limine
+}
+
+post_install() {
+	vlicense limine-$version/LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (36 preceding siblings ...)
  2021-06-26 15:06 ` mintsuki
@ 2021-06-26 15:10 ` mintsuki
  2021-06-27 19:19 ` [PR REVIEW] " Johnnynator
                   ` (6 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-26 15:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869016325

Comment:
Everything should be good now.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (38 preceding siblings ...)
  2021-06-27 19:19 ` [PR REVIEW] " Johnnynator
@ 2021-06-27 19:19 ` Johnnynator
  2021-06-27 19:19 ` Johnnynator
                   ` (4 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-27 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659179934

Comment:
No need to do a `post_install` if you already have a custom `do_install`

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (37 preceding siblings ...)
  2021-06-26 15:10 ` mintsuki
@ 2021-06-27 19:19 ` Johnnynator
  2021-06-27 19:19 ` Johnnynator
                   ` (5 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-27 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659179443

Comment:
pls go with one distfile and one chekcsum per line.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR REVIEW] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (39 preceding siblings ...)
  2021-06-27 19:19 ` Johnnynator
@ 2021-06-27 19:19 ` Johnnynator
  2021-06-27 19:45 ` [PR PATCH] [Updated] " mintsuki
                   ` (3 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: Johnnynator @ 2021-06-27 19:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#discussion_r659179646

Comment:
`tar` shouldn't be needed anymore?

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Updated] New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (40 preceding siblings ...)
  2021-06-27 19:19 ` Johnnynator
@ 2021-06-27 19:45 ` mintsuki
  2021-06-27 19:49 ` mintsuki
                   ` (2 subsequent siblings)
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-27 19:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is an updated pull request by mintsuki against master on the void-packages repository

https://github.com/mintsuki-org/void-packages master
https://github.com/void-linux/void-packages/pull/31658

New package: limine-2.24
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31658.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-31658.patch --]
[-- Type: text/x-diff, Size: 2490 bytes --]

From c3394bebc00949b424f0761a214e1e06d199c272 Mon Sep 17 00:00:00 2001
From: mintsuki <mintsuki@protonmail.com>
Date: Sun, 27 Jun 2021 21:45:17 +0200
Subject: [PATCH] New package: limine-2.24

---
 srcpkgs/limine/template | 59 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 srcpkgs/limine/template

diff --git a/srcpkgs/limine/template b/srcpkgs/limine/template
new file mode 100644
index 000000000000..ef03b0262a74
--- /dev/null
+++ b/srcpkgs/limine/template
@@ -0,0 +1,59 @@
+# Template file for 'limine'
+pkgname=limine
+version=2.24
+revision=1
+archs="x86_64* i686*"
+create_wrksrc=yes
+hostmakedepends="which nasm mtools git"
+short_desc="Advanced x86/x86_64 BIOS and UEFI bootloader"
+maintainer="mintsuki <mintsuki@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://limine-bootloader.org"
+distfiles="
+https://github.com/limine-bootloader/limine/archive/refs/tags/v$version.tar.gz
+https://github.com/stivale/stivale/archive/f8d1674dfa0241d990339dc52fbaf56319e690a7.tar.gz
+https://netcologne.dl.sourceforge.net/project/gnu-efi/gnu-efi-3.0.13.tar.bz2
+"
+checksum="
+8e1dc14b097485c4a36107f701bbd75f27d919a818a01ebe26e82cb2fd0d9172
+508035442f453fbda116735d041d18daf3a47fe28d4318ba2e8360a5f3af9f12
+2fccf715279c46ee69c4859186af8150d07a13f4d19876e5459cd65be82d3b7d
+"
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64);;
+	*) hostmakedepends+=" cross-x86_64-linux-gnu";;
+esac
+
+pre_build() {
+	cd limine-$version
+	vsed -i stage23/Makefile -e "s/\$(LIMINE_VERSION)/v$version/g"
+	mv ../stivale-f8d1674dfa0241d990339dc52fbaf56319e690a7 ./stivale
+	mv ../gnu-efi-3.0.13 ./gnu-efi
+}
+
+do_build() {
+	cd limine-$version
+	if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
+		CC="gcc"
+		AR="ar"
+		unset TOOLCHAIN
+	else
+		CC="x86_64-linux-gnu-gcc"
+		AR="x86_64-linux-gnu-ar"
+		TOOLCHAIN="TOOLCHAIN=x86_64-linux-gnu"
+	fi
+	CFLAGS="" make -C gnu-efi/gnuefi ARCH=x86_64 CC="$CC" AR="$AR"
+	CFLAGS="" make -C gnu-efi/lib ARCH=x86_64 CC="$CC" x86_64/efi_stub.o
+	CFLAGS="" make $TOOLCHAIN
+}
+
+do_install() {
+	vbin limine-$version/bin/limine-install
+	vinstall limine-$version/bin/limine.sys 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-cd.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-pxe.bin 644 /usr/share/limine
+	vinstall limine-$version/bin/BOOTX64.EFI 644 /usr/share/limine
+	vinstall limine-$version/bin/limine-eltorito-efi.bin 644 /usr/share/limine
+	vlicense limine-$version/LICENSE.md
+}

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (41 preceding siblings ...)
  2021-06-27 19:45 ` [PR PATCH] [Updated] " mintsuki
@ 2021-06-27 19:49 ` mintsuki
  2021-07-11  3:06 ` [PR PATCH] [Closed]: " mintsuki
  2021-07-11  3:13 ` ericonr
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-06-27 19:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by mintsuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-869215278

Comment:
All done.

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PR PATCH] [Closed]: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (42 preceding siblings ...)
  2021-06-27 19:49 ` mintsuki
@ 2021-07-11  3:06 ` mintsuki
  2021-07-11  3:13 ` ericonr
  44 siblings, 0 replies; 46+ messages in thread
From: mintsuki @ 2021-07-11  3:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

There's a closed pull request on the void-packages repository

New package: limine-2.24
https://github.com/void-linux/void-packages/pull/31658

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: New package: limine-2.24
  2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
                   ` (43 preceding siblings ...)
  2021-07-11  3:06 ` [PR PATCH] [Closed]: " mintsuki
@ 2021-07-11  3:13 ` ericonr
  44 siblings, 0 replies; 46+ messages in thread
From: ericonr @ 2021-07-11  3:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31658#issuecomment-877734387

Comment:
@mintsuki are you no longer interested in this package?

^ permalink raw reply	[flat|nested] 46+ messages in thread

end of thread, other threads:[~2021-07-11  3:13 UTC | newest]

Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25 22:21 [PR PATCH] New package: limine-2.24 mintsuki
2021-06-26  6:34 ` Anachron
2021-06-26 11:38 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 11:51 ` mintsuki
2021-06-26 11:55 ` mintsuki
2021-06-26 11:55 ` [PR REVIEW] " Johnnynator
2021-06-26 11:55 ` Johnnynator
2021-06-26 11:57 ` mintsuki
2021-06-26 11:57 ` Johnnynator
2021-06-26 11:57 ` mintsuki
2021-06-26 11:58 ` [PR REVIEW] " Johnnynator
2021-06-26 12:00 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 12:00 ` mintsuki
2021-06-26 12:04 ` [PR REVIEW] " mintsuki
2021-06-26 12:05 ` mintsuki
2021-06-26 12:21 ` mintsuki
2021-06-26 12:21 ` mintsuki
2021-06-26 12:23 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 12:26 ` mintsuki
2021-06-26 12:28 ` mintsuki
2021-06-26 12:31 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 12:34 ` mintsuki
2021-06-26 13:04 ` mintsuki
2021-06-26 13:12 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 13:34 ` mintsuki
2021-06-26 13:44 ` [PR REVIEW] " Johnnynator
2021-06-26 13:44 ` Johnnynator
2021-06-26 13:59 ` mintsuki
2021-06-26 14:02 ` mintsuki
2021-06-26 14:03 ` mintsuki
2021-06-26 14:04 ` mintsuki
2021-06-26 14:05 ` mintsuki
2021-06-26 14:06 ` mintsuki
2021-06-26 14:11 ` [PR REVIEW] " Johnnynator
2021-06-26 14:11 ` Johnnynator
2021-06-26 14:16 ` Johnnynator
2021-06-26 15:02 ` [PR PATCH] [Updated] " mintsuki
2021-06-26 15:06 ` mintsuki
2021-06-26 15:10 ` mintsuki
2021-06-27 19:19 ` [PR REVIEW] " Johnnynator
2021-06-27 19:19 ` Johnnynator
2021-06-27 19:19 ` Johnnynator
2021-06-27 19:45 ` [PR PATCH] [Updated] " mintsuki
2021-06-27 19:49 ` mintsuki
2021-07-11  3:06 ` [PR PATCH] [Closed]: " mintsuki
2021-07-11  3:13 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).