Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gnome-font-viewer: needs gettext in hostmakedepends.
@ 2021-07-01  8:47 not-chicken
  2021-07-01 12:48 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 1 reply; 2+ messages in thread
From: not-chicken @ 2021-07-01  8:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages gfv
https://github.com/void-linux/void-packages/pull/31734

gnome-font-viewer: needs gettext in hostmakedepends.
This also fixes the lack of desktop file, as package installs translated file
which was getting ignored when gettext was not found on the host system:
https://gitlab.gnome.org/GNOME/gnome-font-viewer/-/blob/1e5b/src/meson.build#L42

Fixes #31730

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/31734.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gfv-31734.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]

From ca681f067144f657dbae42ce1139b68be5fe5cd9 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Thu, 1 Jul 2021 13:49:09 +0530
Subject: [PATCH] gnome-font-viewer: needs gettext in hostmakedepends.

This also fixes the lack of desktop file, as package installs translated file
which was getting ignored when gettext was not found on the host system:
https://gitlab.gnome.org/GNOME/gnome-font-viewer/-/blob/1e5b/src/meson.build#L42
---
 srcpkgs/gnome-font-viewer/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-font-viewer/template b/srcpkgs/gnome-font-viewer/template
index 92748bbb386e..61d1e9cfc756 100644
--- a/srcpkgs/gnome-font-viewer/template
+++ b/srcpkgs/gnome-font-viewer/template
@@ -1,9 +1,9 @@
 # Template file for 'gnome-font-viewer'
 pkgname=gnome-font-viewer
 version=40.0
-revision=1
+revision=2
 build_style=meson
-hostmakedepends="pkg-config glib-devel"
+hostmakedepends="pkg-config glib-devel gettext"
 makedepends="fontconfig-devel freetype-devel glib-devel gtk+3-devel
  gnome-desktop-devel harfbuzz-devel libhandy1-devel"
 depends="desktop-file-utils"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: gnome-font-viewer: needs gettext in hostmakedepends.
  2021-07-01  8:47 [PR PATCH] gnome-font-viewer: needs gettext in hostmakedepends not-chicken
@ 2021-07-01 12:48 ` sgn
  0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2021-07-01 12:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

There's a merged pull request on the void-packages repository

gnome-font-viewer: needs gettext in hostmakedepends.
https://github.com/void-linux/void-packages/pull/31734

Description:
This also fixes the lack of desktop file, as package installs translated file
which was getting ignored when gettext was not found on the host system:
https://gitlab.gnome.org/GNOME/gnome-font-viewer/-/blob/1e5b/src/meson.build#L42

Fixes #31730

<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-01 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01  8:47 [PR PATCH] gnome-font-viewer: needs gettext in hostmakedepends not-chicken
2021-07-01 12:48 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).