Github messages for voidlinux
 help / color / mirror / Atom feed
From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New packages: mold-0.9.1, mimalloc-1.7.2
Date: Thu, 01 Jul 2021 16:49:56 +0200	[thread overview]
Message-ID: <20210701144956.64EpVRg-LW1P_Ol1enxwLoh6sl_pOTQViTJNNNEeXQI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31706@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/31706#discussion_r662359071

Comment:
1) in the past things have been overly lax (until recently there wasn't even CI with unit tests)
2) with most things it's generally safe to assume things work okay, since most things don't have platform specific code, and weren't developed with any specific platform in mind
3) this is a thing that explicitly has platform specific code, and is developed with a single platform in mind for the time being

considering making this work for cross targets involves special compiler setup that complicates the template, and fixing other targets appears to require patching, and even if you do make it build it will not be tested, i don't see any reason to include it in the packages - and i can pretty much guarantee you that there will be zero users trying to link with mold from an arm/ppc/whatever host to x86_64 target (until recently we didn't even ship cross-compilers to x86_64 and nobody complained for years, until i went ahead and added them)

  parent reply	other threads:[~2021-07-01 14:49 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  0:36 [PR PATCH] New package: mimalloc-1.7.2 Logarithmus
2021-06-29  0:56 ` [PR REVIEW] " sgn
2021-06-29  0:56 ` sgn
2021-06-29  0:56 ` sgn
2021-06-29  0:56 ` sgn
2021-06-29  0:56 ` sgn
2021-06-29  0:57 ` sgn
2021-06-29  0:58 ` sgn
2021-06-29  1:02 ` Logarithmus
2021-06-29  1:03 ` Logarithmus
2021-06-29  1:03 ` Logarithmus
2021-06-29  1:28 ` Logarithmus
2021-06-29  1:28 ` Logarithmus
2021-06-29  1:32 ` sgn
2021-06-29  1:33 ` Logarithmus
2021-06-29  1:35 ` sgn
2021-06-29  1:36 ` sgn
2021-06-29  1:38 ` Logarithmus
2021-06-29  1:40 ` [PR PATCH] [Updated] " Logarithmus
2021-06-29  1:41 ` Logarithmus
2021-06-29 16:48 ` [PR PATCH] [Updated] " Logarithmus
2021-06-29 17:19 ` Logarithmus
2021-06-29 18:05 ` Logarithmus
2021-06-29 19:26 ` Logarithmus
2021-06-29 19:34 ` Logarithmus
2021-06-29 20:15 ` Logarithmus
2021-06-29 20:15 ` Logarithmus
2021-06-29 20:16 ` Logarithmus
2021-06-30  9:06 ` [PR REVIEW] " travankor
2021-06-30 12:29 ` Logarithmus
2021-06-30 14:07 ` [PR PATCH] [Updated] " Logarithmus
2021-07-01 11:10 ` Logarithmus
2021-07-01 11:20 ` [PR REVIEW] New packages: mold-0.9.1, mimalloc-1.7.2 Logarithmus
2021-07-01 11:26 ` q66
2021-07-01 11:26 ` Logarithmus
2021-07-01 11:28 ` Logarithmus
2021-07-01 13:12 ` q66
2021-07-01 13:23 ` Vaelatern
2021-07-01 13:28 ` q66
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` ericonr
2021-07-01 13:40 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:54 ` Logarithmus
2021-07-01 13:58 ` Logarithmus
2021-07-01 14:00 ` Logarithmus
2021-07-01 14:08 ` q66
2021-07-01 14:26 ` Logarithmus
2021-07-01 14:27 ` Logarithmus
2021-07-01 14:30 ` q66
2021-07-01 14:37 ` Logarithmus
2021-07-01 14:38 ` Logarithmus
2021-07-01 14:39 ` Logarithmus
2021-07-01 14:45 ` Logarithmus
2021-07-01 14:49 ` q66 [this message]
2021-07-01 15:04 ` ericonr
2021-07-01 15:05 ` Logarithmus
2021-07-01 15:07 ` ericonr
2021-07-01 15:09 ` Logarithmus
2021-07-01 15:20 ` [PR PATCH] [Updated] " Logarithmus
2021-07-01 15:21 ` [PR REVIEW] " Logarithmus
2021-07-01 15:24 ` q66
2021-07-01 15:29 ` Logarithmus
2021-07-01 15:30 ` Logarithmus
2021-07-01 15:34 ` Logarithmus
2021-07-01 15:35 ` Logarithmus
2021-07-01 16:57 ` sgn
2021-07-01 16:59 ` Logarithmus
2021-07-12 15:27 ` [PR PATCH] [Updated] " Logarithmus
2021-07-13  2:18 ` Logarithmus
2021-07-13  2:23 ` Logarithmus
2021-07-13  2:26 ` [PR REVIEW] " sgn
2021-07-13  2:27 ` sgn
2021-07-13  2:29 ` Logarithmus
2021-07-13  2:37 ` Logarithmus
2021-07-13  2:37 ` Logarithmus
2021-07-13  2:47 ` [PR PATCH] [Updated] New packages: mold-0.9.2, mimalloc-1.7.2 Logarithmus
2021-07-13  2:55 ` [PR REVIEW] " Logarithmus
2021-07-13  2:56 ` Logarithmus
2021-07-13  3:32 ` [PR PATCH] [Updated] " Logarithmus
2021-07-13  3:42 ` [PR REVIEW] " Logarithmus
2021-07-13  3:47 ` [PR PATCH] [Updated] " Logarithmus
2021-07-13  3:49 ` Logarithmus
2021-07-13 10:33 ` [PR PATCH] [Updated] " Logarithmus
2021-07-13 10:37 ` Logarithmus
2021-07-13 10:44 ` Logarithmus
2021-07-13 11:08 ` Logarithmus
2021-07-13 13:12 ` [PR REVIEW] " ericonr
2021-07-13 13:12 ` ericonr
2021-07-13 13:12 ` ericonr
2021-07-13 13:12 ` ericonr
2021-07-13 13:13 ` Logarithmus
2021-07-13 13:15 ` Logarithmus
2021-07-13 13:18 ` Logarithmus
2021-07-24  1:48 ` [PR PATCH] [Updated] " Logarithmus
2021-07-24 10:24 ` Logarithmus
2021-07-24 10:32 ` [PR PATCH] [Updated] New packages: mold-0.9.3, mimalloc-1.7.2 Logarithmus
2021-07-24 12:13 ` [PR REVIEW] " sgn
2021-07-24 12:14 ` Logarithmus
2021-07-25 20:19 ` ericonr
2021-07-26 13:47 ` [PR PATCH] [Updated] " Logarithmus
2021-07-26 13:50 ` Logarithmus
2021-07-27  3:23 ` [PR REVIEW] " Logarithmus
2021-07-27  3:25 ` Logarithmus
2021-10-24 18:13 ` cinerea0
2021-12-20  1:45 ` Sinono3
2021-12-24 20:15 ` Logarithmus
2021-12-24 20:16 ` Logarithmus
2022-01-09 20:09 ` [PR REVIEW] " Anachron
2022-01-10 19:31 ` Chocimier
2022-01-10 22:08 ` Anachron
2022-01-11  8:27 ` Anachron
2022-01-14  4:15 ` cinerea0
2022-05-24  2:13 ` github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701144956.64EpVRg-LW1P_Ol1enxwLoh6sl_pOTQViTJNNNEeXQI@z \
    --to=q66@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    --subject='Re: [PR REVIEW] New packages: mold-0.9.1, mimalloc-1.7.2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).