[PR PATCH] pipewire: update to 0.3.30.

[PR PATCH] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 4915 bytes --]

From 75202ea61cc107c6669c4488320f8e6c3d765e59 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 13 Jun 2021 18:51:51 +0200
Subject: [PATCH] pipewire: update to 0.3.30.

---
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/fix-musl-rlimit-rttime.patch      | 13 ++++
 srcpkgs/pipewire/template                     |  5 +-
 3 files changed, 16 insertions(+), 64 deletions(-)
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch
 create mode 100644 srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch

diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index 8eea42116ad6..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- src/modules/module-filter-chain.c
-+++ src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
new file mode 100644
index 000000000000..8a6869228cfc
--- /dev/null
+++ b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
@@ -0,0 +1,13 @@
+--- src/modules/module-rt.c
++++ src/modules/module-rt.c
+@@ -49,6 +49,10 @@
+ 	"[rt.time.soft=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_SOFT)"] " \
+ 	"[rt.time.hard=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_HARD)"] "
+ 
++#ifndef RLIMIT_RTTIME
++#define RLIMIT_RTTIME 15
++#endif
++
+ static const struct spa_dict_item module_props[] = {
+ 	{ PW_KEY_MODULE_AUTHOR, "Jonas Holmberg <jonashg@axis.com>" },
+ 	{ PW_KEY_MODULE_DESCRIPTION, "Set thread priorities" },
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..0ad5ea7fb774 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.30
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=09a002a0846e168e8dc61b3aa579d38885aef32ac971351d5d3cde20bcd1759b
 
 build_options="sdl2"
 
@@ -150,6 +150,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: pipewire: update to 0.3.30.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-863716109

Comment:
Testing locally now.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-863946951

Comment:
> but not on musl.

It doesn't work because the new module still uses `sched_setscheduler`, which is not implemented in musl because the Linux API is per thread, not per process as required by the POSIX API.
I want to try if switching to `pthread_setschedparam(pthread_self(), ...)` makes it work on musl.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-863946951

Comment:
> but not on musl.

It doesn't work because the new module still uses `sched_setscheduler`, which is not implemented in musl because the Linux API is per thread, not per process as required by the POSIX API. https://github.com/void-linux/void-packages/issues/28728
I want to try if switching to `pthread_setschedparam(pthread_self(), ...)` makes it work on musl.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-863946951

Comment:
> but not on musl.

It doesn't work because the new module still uses `sched_setscheduler`, which is not implemented in musl because the Linux API is per thread, not per process as required by the POSIX API. https://github.com/void-linux/void-packages/issues/28728
I want to try if switching to `pthread_setschedparam(pthread_self(), ...)` makes it work on both libcs.

Re: pipewire: update to 0.3.30.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-864018646

Comment:
Btw, should we introduce a build option or document this in some way? I assume the `CAP_SYS_NICE` requirement is for the `pipewire` binary? 

Re: [PR PATCH] [Updated] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 4915 bytes --]

From 75202ea61cc107c6669c4488320f8e6c3d765e59 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 13 Jun 2021 18:51:51 +0200
Subject: [PATCH] pipewire: update to 0.3.30.

---
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/fix-musl-rlimit-rttime.patch      | 13 ++++
 srcpkgs/pipewire/template                     |  5 +-
 3 files changed, 16 insertions(+), 64 deletions(-)
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch
 create mode 100644 srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch

diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index 8eea42116ad6..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- src/modules/module-filter-chain.c
-+++ src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
new file mode 100644
index 000000000000..8a6869228cfc
--- /dev/null
+++ b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
@@ -0,0 +1,13 @@
+--- src/modules/module-rt.c
++++ src/modules/module-rt.c
+@@ -49,6 +49,10 @@
+ 	"[rt.time.soft=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_SOFT)"] " \
+ 	"[rt.time.hard=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_HARD)"] "
+ 
++#ifndef RLIMIT_RTTIME
++#define RLIMIT_RTTIME 15
++#endif
++
+ static const struct spa_dict_item module_props[] = {
+ 	{ PW_KEY_MODULE_AUTHOR, "Jonas Holmberg <jonashg@axis.com>" },
+ 	{ PW_KEY_MODULE_DESCRIPTION, "Set thread priorities" },
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..0ad5ea7fb774 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.30
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=09a002a0846e168e8dc61b3aa579d38885aef32ac971351d5d3cde20bcd1759b
 
 build_options="sdl2"
 
@@ -150,6 +150,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: [PR PATCH] [Updated] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 6183 bytes --]

From ba0be7085537e566f5e5a55cb9b13d8d761e672d Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.30.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  5 ++
 srcpkgs/pipewire/files/pipewire/run           |  5 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/fix-musl-rlimit-rttime.patch      | 13 ++++
 srcpkgs/pipewire/template                     |  9 ++-
 5 files changed, 30 insertions(+), 64 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch
 create mode 100644 srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..b153926f4448
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+mkdir -p /run/pulse
+chown pipewire:pipewire /run/pulse
+umask 002
+PULSE_RUNTIME_PATH=/run exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..65a602cf601b
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+mkdir -p /run/pipewire
+chown pipewire:pipewire /run/pipewire
+umask 002
+PIPEWIRE_RUNTIME_DIR=/run/pipewire XDG_CONFIG_HOME=/var/lib chpst -u pipewire:pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
new file mode 100644
index 000000000000..27d477b5acc9
--- /dev/null
+++ b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
@@ -0,0 +1,13 @@
+--- a/src/modules/module-rt.c
++++ b/src/modules/module-rt.c
+@@ -49,6 +49,10 @@
+ 	"[rt.time.soft=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_SOFT)"] " \
+ 	"[rt.time.hard=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_HARD)"] "
+ 
++#ifndef RLIMIT_RTTIME
++#define RLIMIT_RTTIME 15
++#endif
++
+ static const struct spa_dict_item module_props[] = {
+ 	{ PW_KEY_MODULE_AUTHOR, "Jonas Holmberg <jonashg@axis.com>" },
+ 	{ PW_KEY_MODULE_DESCRIPTION, "Set thread priorities" },
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..1d0cd232bb49 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.30
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,9 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=09a002a0846e168e8dc61b3aa579d38885aef32ac971351d5d3cde20bcd1759b
+make_dirs="/var/lib/pipewire 0755 root root"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+    vsv pipewire
+    vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: [PR PATCH] [Updated] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 6177 bytes --]

From f5495cc84c995cff469dfb772161264b02c9e5c8 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.30.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  5 ++
 srcpkgs/pipewire/files/pipewire/run           |  5 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/fix-musl-rlimit-rttime.patch      | 13 ++++
 srcpkgs/pipewire/template                     |  9 ++-
 5 files changed, 30 insertions(+), 64 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch
 create mode 100644 srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..b153926f4448
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+mkdir -p /run/pulse
+chown pipewire:pipewire /run/pulse
+umask 002
+PULSE_RUNTIME_PATH=/run exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..65a602cf601b
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+mkdir -p /run/pipewire
+chown pipewire:pipewire /run/pipewire
+umask 002
+PIPEWIRE_RUNTIME_DIR=/run/pipewire XDG_CONFIG_HOME=/var/lib chpst -u pipewire:pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
new file mode 100644
index 000000000000..27d477b5acc9
--- /dev/null
+++ b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
@@ -0,0 +1,13 @@
+--- a/src/modules/module-rt.c
++++ b/src/modules/module-rt.c
+@@ -49,6 +49,10 @@
+ 	"[rt.time.soft=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_SOFT)"] " \
+ 	"[rt.time.hard=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_HARD)"] "
+ 
++#ifndef RLIMIT_RTTIME
++#define RLIMIT_RTTIME 15
++#endif
++
+ static const struct spa_dict_item module_props[] = {
+ 	{ PW_KEY_MODULE_AUTHOR, "Jonas Holmberg <jonashg@axis.com>" },
+ 	{ PW_KEY_MODULE_DESCRIPTION, "Set thread priorities" },
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..1e2a55143485 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.30
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,9 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=09a002a0846e168e8dc61b3aa579d38885aef32ac971351d5d3cde20bcd1759b
+make_dirs="/var/lib/pipewire 0755 root root"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-864579583

Comment:
@st3r4g I added your suggestions to the package, could you test it? I am sorry for taking credit for this PR even though you did most of the work.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654963076

Comment:
maybe we could do this in a single command via `install`, (see dbus service). But then we also need to assign a fixed id to user pipewire.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654962531

Comment:
this needs to be owned by user pipewire

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654963513

Comment:
this could mess with system pulsaudio, in case someone has enabled both by mistake. It should probably be guarded

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654962803

Comment:
forgot exec here

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654963076

Comment:
maybe we could do this in a single command via `install`, (see dbus service). But then we also need to assign a fixed id to user pipewire. (By the way, should it be user `pipewire` or `_pipewire`?)

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654963513

Comment:
this could mess with system pulseaudio, in case someone has enabled both by mistake. It should probably be guarded

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654962531

Comment:
this needs to be owned by user pipewire (and group too)

Re: [PR REVIEW] pipewire: update to 0.3.30.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654967348

Comment:
I'm pretty sure it should be `_pipewire`.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654970209

Comment:
`install -o` can take both UIDs and names, ditto `-g`.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[heliocat]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New review comment by heliocat on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654970209

Comment:
`install -o` can take both UIDs and names, ditto `-g`. We may want to go with a fixed UID and GID for other reasons but install functionality shouldn't be a blocker.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654972166

Comment:
that's true, my bad

Re: [PR PATCH] [Updated] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 6218 bytes --]

From e66161b5e85788b64a1ad0598eca3b3b20052ba5 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.30.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  4 ++
 srcpkgs/pipewire/files/pipewire/run           |  4 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/fix-musl-rlimit-rttime.patch      | 13 ++++
 srcpkgs/pipewire/template                     |  9 ++-
 5 files changed, 28 insertions(+), 64 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch
 create mode 100644 srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..d5432d5091bf
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+! [ -d /run/pulse ] && install -m 755 -g pipewire -o pipewire -d /run/pulse
+umask 002
+PULSE_RUNTIME_PATH=/run exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..91801942fad5
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+! [ -d /run/pipewire ] && install -m 755 -g pipewire -o pipewire -d /run/pipewire
+umask 002
+PIPEWIRE_RUNTIME_DIR=/run/pipewire XDG_CONFIG_HOME=/var/lib exec chpst -u pipewire:pipewire pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
new file mode 100644
index 000000000000..27d477b5acc9
--- /dev/null
+++ b/srcpkgs/pipewire/patches/fix-musl-rlimit-rttime.patch
@@ -0,0 +1,13 @@
+--- a/src/modules/module-rt.c
++++ b/src/modules/module-rt.c
+@@ -49,6 +49,10 @@
+ 	"[rt.time.soft=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_SOFT)"] " \
+ 	"[rt.time.hard=<in usec: default " SPA_STRINGIFY(DEFAULT_RT_TIME_HARD)"] "
+ 
++#ifndef RLIMIT_RTTIME
++#define RLIMIT_RTTIME 15
++#endif
++
+ static const struct spa_dict_item module_props[] = {
+ 	{ PW_KEY_MODULE_AUTHOR, "Jonas Holmberg <jonashg@axis.com>" },
+ 	{ PW_KEY_MODULE_DESCRIPTION, "Set thread priorities" },
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..cd4900422d87 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.30
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -18,7 +18,9 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=09a002a0846e168e8dc61b3aa579d38885aef32ac971351d5d3cde20bcd1759b
+make_dirs="/var/lib/pipewire 0755 pipewire pipewire"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-864610951

Comment:
> > @st3r4g I added your suggestions to the package, could you test it? I am sorry for taking credit for this PR even though you did most of the work.
> 
> No problem, I don't mind. These are collaborative efforts. I will test it on another pc with runit, for now I just translated my execline scripts. But it would be good if someone could check that bluetooth works, which I don't use. And I've not yet figured out the dbus error...

I will try bluetooth tomorrow, I will have to reboot to a runit system. Do you have s6 services somewhere?

Re: pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-864610951

Comment:
> I will test it on another pc with runit, for now I just translated my execline scripts. But it would be good if someone could check that bluetooth works, which I don't use. And I've not yet figured out the dbus error...

I will try bluetooth tomorrow, I will have to reboot to a runit system. Do you have s6 services somewhere?

Re: [PR REVIEW] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654988138

Comment:
This will need adding a check script to pulseaudio, right?

Re: [PR REVIEW] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654988589

Comment:
> I'm pretty sure it should be `_pipewire`.

I am not sure, I think _pipewire would be used for a group which users do not have to interact with (users should never be a part of it). Names without the leading _ like wheel are often used for groups which users might want to be a part of. If we agree on this, then the pipewire group shouldn't have a leading _ in its name.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-864613661

Comment:
> Do you have s6 services somewhere?

I'm using these s6-rc definitions
[pipewire-s6-rc.tar.gz](https://github.com/void-linux/void-packages/files/6683095/pipewire-s6-rc.tar.gz)

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654991388

Comment:
actually it might be fine now that there's no chown anymore. the pipewire service will just fail, which is ok.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r654991388

Comment:
actually it might be fine now that there's no chown anymore. ~~the pipewire service will just fail, which is ok.~~ I'm not sure what happens, will check tomorrow

Re: [PR REVIEW] pipewire: update to 0.3.30.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r655005013

Comment:
I believe the namespacing is more about avoiding conflicts than specifying what a user should or shouldn't touch. Unless it's a common name (like http or plugdev), creating a user name without a leading underscore should always be harmless.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r655685238

Comment:
It fails with "Address already in use", it's ok as is

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-865366232

Comment:
About the "Failed to connect to system bus" error, it's a bug in pipewire logging: it's failing to connect to the *session* bus, which of course is not there.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-865366232

Comment:
About the "Failed to connect to system bus" error, it's a bug in pipewire logging: it's failing to connect to the *session* bus, which of course is not there, for system pipewire.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-865366232

Comment:
About the "Failed to connect to system bus" error, it's a bug in pipewire logging: it's failing to connect to the *session* bus, which of course is not there, for system pipewire. Maybe the problem is that pipewire-media-session shouldn't be running system-wide...

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-865366232

Comment:
About the "Failed to connect to system bus" error, it's a bug in pipewire logging: it's failing to connect to the *session* bus, which of course is not there, for system pipewire.

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r659031479

Comment:
needs pipewire:pipewire:**audio:video** too to work

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r659031479

Comment:
needs pipewire:pipewire:**audio:video** too to have the permissions to open hardware devices

Re: [PR REVIEW] pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r659069910

Comment:
Could you also split this line into multiple lines with `export ...` to make it more readable? same in pipewire-pulse

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-869011938

Comment:
> I wonder how jack handles this...

I think I got it. `/etc/security/limits.d/jack.conf` simply allows unprivileged process to set any RT priority.

Re: pipewire: update to 0.3.30.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-869011938

Comment:
> I wonder how jack handles this...

I think I got it. `/etc/security/limits.d/jack.conf` simply allows unprivileged processes to set any RT priority.

Re: [PR PATCH] [Updated] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.30.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 7675 bytes --]

From 43463302b9c6c01221a9599a7d952099bf0e6e39 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.31.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  5 ++
 srcpkgs/pipewire/files/pipewire/run           |  6 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/autostart-media-session.patch     | 10 +--
 srcpkgs/pipewire/template                     | 13 ++--
 5 files changed, 25 insertions(+), 71 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..f8a6ed3e4191
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+! [ -d /run/pulse ] && install -m 755 -g pipewire -o pipewire -d /run/pulse
+umask 002
+export PULSE_RUNTIME_PATH=/run
+exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..359524974831
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+! [ -d /run/pipewire ] && install -m 755 -g pipewire -o pipewire -d /run/pipewire
+umask 002
+export PIPEWIRE_RUNTIME_DIR=/run/pipewire
+export XDG_CONFIG_HOME=/var/lib
+exec chpst -u pipewire:pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/autostart-media-session.patch b/srcpkgs/pipewire/patches/autostart-media-session.patch
index bb107435cdd8..87ab20765488 100644
--- a/srcpkgs/pipewire/patches/autostart-media-session.patch
+++ b/srcpkgs/pipewire/patches/autostart-media-session.patch
@@ -2,14 +2,14 @@ Upstream's config does not autostart pipewire-media-session anymore, which
 is an essential component. It's not easy to start it externally in a script
 since it needs the pipewire socket up, and Void doesn't have a mechanism to
 ensure it (systemd socket activation).
---- a/src/daemon/pipewire.conf.in	2021-03-18 17:45:02.025992827 +0100
-+++ b/src/daemon/pipewire.conf.in	2021-03-18 17:47:17.606999440 +0100
-@@ -204,7 +204,7 @@
+--- a/src/daemon/pipewire.conf.in
++++ b/src/daemon/pipewire.conf.in
+@@ -234,7 +234,7 @@
      # but it is better to start it as a systemd service.
      # Run the session manager with -h for options.
      #
--    @comment@{ path = "@media_session_path@"  args = "" }
-+    { path = "@media_session_path@"  args = "" }
+-    @comment@{ path = "@session_manager_path@"  args = "@session_manager_args@" }
++    { path = "@session_manager_path@"  args = "@session_manager_args@" }
      #
      # You can optionally start the pulseaudio-server here as well
      # but it is better to start it as a systemd service.
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..56a4059f0860 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.31
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -8,17 +8,19 @@ configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disab
  -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d"
 hostmakedepends="doxygen graphviz pkg-config xmltoman gettext"
 makedepends="ffmpeg-devel gst-plugins-base1-devel jack-devel sbc-devel v4l-utils-devel
- libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel fdk-aac-devel
+ libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel libusb-devel fdk-aac-devel
  libsndfile-devel Vulkan-Headers vulkan-loader $(vopt_if sdl2 SDL2-devel)"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}"
 short_desc="Server and user space API to deal with multimedia pipelines"
-maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"
+maintainer="Stefano Ragni <stefano.ragni@outlook.com>"
 license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+make_dirs="/var/lib/pipewire 0755 pipewire pipewire"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: [PR REVIEW] pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r662629650

Comment:
> needs pipewire:pipewire:**audio:video** too to have the permissions to open hardware devices

done, this is not needed in the pipewire-pulse service right?

Re: pipewire: update to 0.3.30.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872592984

Comment:
sorry for the delay, in the meantime, a new upstream release got tagged. This release adds a new testing framework that makes some tests segfault.

* added libusb to makedepends, it should help with recognizing bluetooth device capabilities (0.3.31)
* removed the rttime patch as it is upstreamed now (0.3.31)
* changed the maintainer to @st3r4g

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r662881502

Comment:
> done, this is not needed in the pipewire-pulse service right?

right

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
```
Starting program: /builddir/pipewire-0.3.31/build/test/test-pwtest 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib64/libthread_db.so.1".
[Detaching after fork from child process 9045]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
37	iofwrite.c: No such file or directory.
(gdb) bt
#0  0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
#1  0x00005555555581f2 in fprintf (__fmt=0x555555559053 "pwtest\n", __stream=0x0) at /usr/include/bits/stdio2.h:103
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
#3  0x00005555555566e2 in main (argc=<optimized out>, argv=<optimized out>) at ../test/pwtest.c:1271
(gdb) f 2
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
1077		fprintf(fp, "pwtest\n");
(gdb) l
1072		/* Marker file to avoid removing a random directory during cleanup */
1073		r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
1074		spa_assert((size_t)r == strlen(dir) + 11);
1075		fp = fopen(path, "w");
1076		spa_assert(fp);
1077		fprintf(fp, "pwtest\n");
1078		fclose(fp);
1079	
1080		return dir;
1081	}
(gdb) p fp
$1 = (FILE *) 0x0
(gdb) p path
$2 = "/tmp/pwtest-11:35-XXXXXX/pwtest.dir", '\000' <repeats 230 times>...
(gdb) p dir
$3 = 0x55555555da20 "/tmp/pwtest-11:35-XXXXXX"
```
looks like `spa_assert` is not working?

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
```
Starting program: /builddir/pipewire-0.3.31/build/test/test-pwtest 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib64/libthread_db.so.1".
[Detaching after fork from child process 9045]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
37	iofwrite.c: No such file or directory.
(gdb) bt
#0  0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
#1  0x00005555555581f2 in fprintf (__fmt=0x555555559053 "pwtest\n", __stream=0x0) at /usr/include/bits/stdio2.h:103
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
#3  0x00005555555566e2 in main (argc=<optimized out>, argv=<optimized out>) at ../test/pwtest.c:1271
(gdb) f 2
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
1077		fprintf(fp, "pwtest\n");
(gdb) l
1072		/* Marker file to avoid removing a random directory during cleanup */
1073		r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
1074		spa_assert((size_t)r == strlen(dir) + 11);
1075		fp = fopen(path, "w");
1076		spa_assert(fp);
1077		fprintf(fp, "pwtest\n");
1078		fclose(fp);
1079	
1080		return dir;
1081	}
(gdb) p fp
$1 = (FILE *) 0x0
(gdb) p path
$2 = "/tmp/pwtest-11:35-XXXXXX/pwtest.dir", '\000' <repeats 230 times>...
(gdb) p dir
$3 = 0x55555555da20 "/tmp/pwtest-11:35-XXXXXX"
```

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1721 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
```
Starting program: /builddir/pipewire-0.3.31/build/test/test-pwtest 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib64/libthread_db.so.1".
[Detaching after fork from child process 9045]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
37	iofwrite.c: No such file or directory.
(gdb) bt
#0  0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
#1  0x00005555555581f2 in fprintf (__fmt=0x555555559053 "pwtest\n", __stream=0x0) at /usr/include/bits/stdio2.h:103
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
#3  0x00005555555566e2 in main (argc=<optimized out>, argv=<optimized out>) at ../test/pwtest.c:1271
(gdb) f 2
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
1077		fprintf(fp, "pwtest\n");
(gdb) l
1072		/* Marker file to avoid removing a random directory during cleanup */
1073		r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
1074		spa_assert((size_t)r == strlen(dir) + 11);
1075		fp = fopen(path, "w");
1076		spa_assert(fp);
1077		fprintf(fp, "pwtest\n");
1078		fclose(fp);
1079	
1080		return dir;
1081	}
(gdb) p fp
$1 = (FILE *) 0x0
(gdb) p path
$2 = "/tmp/pwtest-11:35-XXXXXX/pwtest.dir", '\000' <repeats 230 times>...
(gdb) p dir
$3 = 0x55555555da20 "/tmp/pwtest-11:35-XXXXXX"
```
`mkdtemp` doesn't work in the build environment?

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
```
Starting program: /builddir/pipewire-0.3.31/build/test/test-pwtest 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib64/libthread_db.so.1".
[Detaching after fork from child process 9045]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
37	iofwrite.c: No such file or directory.
(gdb) bt
#0  0x00007ffff7dae371 in __GI__IO_fwrite (buf=buf@entry=0x555555559053, size=size@entry=1, count=count@entry=7, fp=fp@entry=0x0) at iofwrite.c:37
#1  0x00005555555581f2 in fprintf (__fmt=0x555555559053 "pwtest\n", __stream=0x0) at /usr/include/bits/stdio2.h:103
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
#3  0x00005555555566e2 in main (argc=<optimized out>, argv=<optimized out>) at ../test/pwtest.c:1271
(gdb) f 2
#2  make_xdg_runtime_dir () at ../test/pwtest.c:1077
1077		fprintf(fp, "pwtest\n");
(gdb) l
1072		/* Marker file to avoid removing a random directory during cleanup */
1073		r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
1074		spa_assert((size_t)r == strlen(dir) + 11);
1075		fp = fopen(path, "w");
1076		spa_assert(fp);
1077		fprintf(fp, "pwtest\n");
1078		fclose(fp);
1079	
1080		return dir;
1081	}
(gdb) p fp
$1 = (FILE *) 0x0
(gdb) p path
$2 = "/tmp/pwtest-11:35-XXXXXX/pwtest.dir", '\000' <repeats 230 times>...
(gdb) p dir
$3 = 0x55555555da20 "/tmp/pwtest-11:35-XXXXXX"
```
Ah, `mkdtemp` is inside the assert, which is wrong.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of test:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of tests:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of tests:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing. [Some tests](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/test/test-spa-pod.c) rely heavily on assertions, so running them with `-Db_ndebug=true` is not so meaningful...

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of tests:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing. [Some tests](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/test/test-spa-pod.c) rely heavily on assertions, so building them with `-Db_ndebug=true` is not so meaningful...

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of tests:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing. [Some tests](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/test/test-spa-pod.c) rely heavily on assertions, so building them with `-Db_ndebug=true` is not so meaningful...
With `-Db_ndebug=false`, all tests pass.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-872935639

Comment:
This fixes the majority of tests:
```
--- test/pwtest.c.orig	2021-06-28 15:32:38.000000000 +0200
+++ test/pwtest.c	2021-07-02 14:31:33.196676364 +0200
@@ -1067,7 +1067,8 @@
 
 	int r = asprintf(&dir, "%s/pwtest-%02d:%02d-XXXXXX", tmpdir, tm->tm_hour, tm->tm_min);
 	spa_assert((size_t)r == strlen(tmpdir) + 20); /* rough estimate */
-	spa_assert(mkdtemp(dir) != NULL);
+	dir = mkdtemp(dir);
+	spa_assert(dir != NULL);
 
 	/* Marker file to avoid removing a random directory during cleanup */
 	r = spa_scnprintf(path, sizeof(path), "%s/pwtest.dir", dir);
```
Still, 2 are failing. [Some tests](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/test/test-spa-pod.c) rely heavily on assertions, so building them with `-Db_ndebug=true` is not so meaningful...
With `-Db_ndebug=false`, all tests pass. So, maybe again side-effects in assertions.

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r662881502

Comment:
> done, this is not needed in the pipewire-pulse service right?

right. pipewire-pulse doesn't need hardware access, its just a shim that connects to the pipewire daemon

Re: [PR PATCH] [Updated] pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.31.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 7833 bytes --]

From 8d16e203bd55983f2ef1e41ea21768754c6accee Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.31.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  5 ++
 srcpkgs/pipewire/files/pipewire/run           |  6 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/autostart-media-session.patch     | 10 +--
 srcpkgs/pipewire/template                     | 17 +++--
 5 files changed, 29 insertions(+), 71 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..f8a6ed3e4191
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+! [ -d /run/pulse ] && install -m 755 -g pipewire -o pipewire -d /run/pulse
+umask 002
+export PULSE_RUNTIME_PATH=/run
+exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..359524974831
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+! [ -d /run/pipewire ] && install -m 755 -g pipewire -o pipewire -d /run/pipewire
+umask 002
+export PIPEWIRE_RUNTIME_DIR=/run/pipewire
+export XDG_CONFIG_HOME=/var/lib
+exec chpst -u pipewire:pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/autostart-media-session.patch b/srcpkgs/pipewire/patches/autostart-media-session.patch
index bb107435cdd8..87ab20765488 100644
--- a/srcpkgs/pipewire/patches/autostart-media-session.patch
+++ b/srcpkgs/pipewire/patches/autostart-media-session.patch
@@ -2,14 +2,14 @@ Upstream's config does not autostart pipewire-media-session anymore, which
 is an essential component. It's not easy to start it externally in a script
 since it needs the pipewire socket up, and Void doesn't have a mechanism to
 ensure it (systemd socket activation).
---- a/src/daemon/pipewire.conf.in	2021-03-18 17:45:02.025992827 +0100
-+++ b/src/daemon/pipewire.conf.in	2021-03-18 17:47:17.606999440 +0100
-@@ -204,7 +204,7 @@
+--- a/src/daemon/pipewire.conf.in
++++ b/src/daemon/pipewire.conf.in
+@@ -234,7 +234,7 @@
      # but it is better to start it as a systemd service.
      # Run the session manager with -h for options.
      #
--    @comment@{ path = "@media_session_path@"  args = "" }
-+    { path = "@media_session_path@"  args = "" }
+-    @comment@{ path = "@session_manager_path@"  args = "@session_manager_args@" }
++    { path = "@session_manager_path@"  args = "@session_manager_args@" }
      #
      # You can optionally start the pulseaudio-server here as well
      # but it is better to start it as a systemd service.
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..88a06ab3db72 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.31
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
@@ -8,17 +8,19 @@ configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disab
  -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d"
 hostmakedepends="doxygen graphviz pkg-config xmltoman gettext"
 makedepends="ffmpeg-devel gst-plugins-base1-devel jack-devel sbc-devel v4l-utils-devel
- libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel fdk-aac-devel
+ libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel libusb-devel fdk-aac-devel
  libsndfile-devel Vulkan-Headers vulkan-loader $(vopt_if sdl2 SDL2-devel)"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}"
 short_desc="Server and user space API to deal with multimedia pipelines"
-maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"
+maintainer="Stefano Ragni <stefano.ragni@outlook.com>"
 license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+make_dirs="/var/lib/pipewire 0755 pipewire pipewire"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -33,9 +35,15 @@ if [ "$XBPS_TARGET_ENDIAN" = "le" ]; then
 	makedepends+=" ldacBT-devel"
 fi
 
+if [ -n "$XBPS_CHECK_PKGS" ]; then
+	configure_args+=" -Db_ndebug=false"
+fi
+
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +158,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-873288816

Comment:
@st3r4g I enabled assertions only when xbps-src runs check, but this is not really ideal. If the tests depend on assertions only in the tests/ directory (?), upstream could probably force enable assertions there. Would you like to create an issue or a PR?

Re: pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-873509330

Comment:
Given how meson works, it stands to reason that they expect assertions to be enabled for the final program as well. I would rather have them enabled at all times instead of building the package differently if tests are enabled or not.

Re: [PR PATCH] [Updated] pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.31.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 7737 bytes --]

From 9ee1188cc9f203a8b64e8300f1aae889a81ea8fb Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.31.

---
 srcpkgs/pipewire/files/pipewire-pulse/run     |  5 ++
 srcpkgs/pipewire/files/pipewire/run           |  6 ++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/autostart-media-session.patch     | 10 +--
 srcpkgs/pipewire/template                     | 15 +++--
 5 files changed, 26 insertions(+), 72 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch

diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..f8a6ed3e4191
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+! [ -d /run/pulse ] && install -m 755 -g pipewire -o pipewire -d /run/pulse
+umask 002
+export PULSE_RUNTIME_PATH=/run
+exec chpst -u pipewire:pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..359524974831
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+! [ -d /run/pipewire ] && install -m 755 -g pipewire -o pipewire -d /run/pipewire
+umask 002
+export PIPEWIRE_RUNTIME_DIR=/run/pipewire
+export XDG_CONFIG_HOME=/var/lib
+exec chpst -u pipewire:pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/autostart-media-session.patch b/srcpkgs/pipewire/patches/autostart-media-session.patch
index bb107435cdd8..87ab20765488 100644
--- a/srcpkgs/pipewire/patches/autostart-media-session.patch
+++ b/srcpkgs/pipewire/patches/autostart-media-session.patch
@@ -2,14 +2,14 @@ Upstream's config does not autostart pipewire-media-session anymore, which
 is an essential component. It's not easy to start it externally in a script
 since it needs the pipewire socket up, and Void doesn't have a mechanism to
 ensure it (systemd socket activation).
---- a/src/daemon/pipewire.conf.in	2021-03-18 17:45:02.025992827 +0100
-+++ b/src/daemon/pipewire.conf.in	2021-03-18 17:47:17.606999440 +0100
-@@ -204,7 +204,7 @@
+--- a/src/daemon/pipewire.conf.in
++++ b/src/daemon/pipewire.conf.in
+@@ -234,7 +234,7 @@
      # but it is better to start it as a systemd service.
      # Run the session manager with -h for options.
      #
--    @comment@{ path = "@media_session_path@"  args = "" }
-+    { path = "@media_session_path@"  args = "" }
+-    @comment@{ path = "@session_manager_path@"  args = "@session_manager_args@" }
++    { path = "@session_manager_path@"  args = "@session_manager_args@" }
      #
      # You can optionally start the pulseaudio-server here as well
      # but it is better to start it as a systemd service.
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..8577b6ce7a68 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,24 +1,26 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.31
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
  -Dbluez5=enabled -Dffmpeg=enabled -Dpipewire-alsa=enabled -Dpipewire-jack=enabled
- -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d"
+ -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d -Db_ndebug=false"
 hostmakedepends="doxygen graphviz pkg-config xmltoman gettext"
 makedepends="ffmpeg-devel gst-plugins-base1-devel jack-devel sbc-devel v4l-utils-devel
- libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel fdk-aac-devel
+ libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel libusb-devel fdk-aac-devel
  libsndfile-devel Vulkan-Headers vulkan-loader $(vopt_if sdl2 SDL2-devel)"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}"
 short_desc="Server and user space API to deal with multimedia pipelines"
-maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"
+maintainer="Stefano Ragni <stefano.ragni@outlook.com>"
 license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+make_dirs="/var/lib/pipewire 0755 pipewire pipewire"
+system_accounts="pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-874245196

Comment:
> Given how meson works, it stands to reason that they expect assertions to be enabled for the final program as well.

Meson doesn't disable assertions by default in release builds, right? Then yes, I agree.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-874245196

Comment:
> Given how meson works, it stands to reason that they expect assertions to be enabled for the final program as well.

Meson doesn't disable assertions by default in release builds, right? Then yes, I agree. Might quickly ask them on IRC to be sure.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-874245196

Comment:
> Given how meson works, it stands to reason that they expect assertions to be enabled for the final program as well.

Meson doesn't disable assertions by default in release builds, right? Then yes, I agree. Might quickly ask them on IRC to be sure. But looking at the Fedora rpm package, they are keeping the assertions.

Re: [PR REVIEW] pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666636142

Comment:
Why is this still going with `pipewire`? Packages should ideally stick to the `_*` namespace.

Re: [PR REVIEW] pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666636831

Comment:
How do you feel about making `PIPEWIRE_RUNTIME_DIR` configurable? Does that make sense?

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666851308

Comment:
I think there's no reason to make it configurable. It's the same in [upstream's systemd unit](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/daemon/systemd/system/pipewire.service.in) (`%t` expands to /run I guess)

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666851308

Comment:
I think there's no reason to make it configurable, because that is the default system socket path (the clients would need an env var with the custom location otherwise). It's the same in [upstream's systemd unit](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/daemon/systemd/system/pipewire.service.in) (`%t` expands to /run I guess)

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666851308

Comment:
I think there's no reason to make it configurable, because that is the default system socket path (the clients would need an env var with the custom location otherwise). It's the same in [upstream's systemd unit](https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/src/daemon/systemd/system/pipewire.service.in) (`%t` expands to /run)

Re: [PR REVIEW] pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r666856393

Comment:
upstream uses the `pipewire` user name, but I have no problem adding `_` to be consistent with void's policy

Re: [PR REVIEW] pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r668978096

Comment:
`_seatd` wasn't an upstream recommendation either... I think using `_pipewire` is more correct.

Re: [PR PATCH] [Updated] pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages pipewire-0.3.30
https://github.com/void-linux/void-packages/pull/31549

pipewire: update to 0.3.31.
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

A patch file from https://github.com/void-linux/void-packages/pull/31549.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.30-31549.patch --]
[-- Type: text/x-diff, Size: 8802 bytes --]

From 2ce3d22bf85623e94cd55776a57b7c6f8128edcf Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 20 Jun 2021 17:50:52 +0200
Subject: [PATCH] pipewire: update to 0.3.31.

* add a libusb dependency to improve bluetooth device capabilities detection
* add experimental system services for pipewire and pipewire-pulse
---
 srcpkgs/pipewire/files/README.voidlinux       |  4 ++
 srcpkgs/pipewire/files/pipewire-pulse/run     |  7 +++
 srcpkgs/pipewire/files/pipewire/run           |  8 +++
 srcpkgs/pipewire/patches/6df32666b4.patch     | 62 -------------------
 .../patches/autostart-media-session.patch     | 10 +--
 srcpkgs/pipewire/template                     | 15 +++--
 6 files changed, 34 insertions(+), 72 deletions(-)
 create mode 100644 srcpkgs/pipewire/files/pipewire-pulse/run
 create mode 100644 srcpkgs/pipewire/files/pipewire/run
 delete mode 100644 srcpkgs/pipewire/patches/6df32666b4.patch

diff --git a/srcpkgs/pipewire/files/README.voidlinux b/srcpkgs/pipewire/files/README.voidlinux
index 0c3d167f0aef..33892fdef84b 100644
--- a/srcpkgs/pipewire/files/README.voidlinux
+++ b/srcpkgs/pipewire/files/README.voidlinux
@@ -7,3 +7,7 @@ Optional dependencies:
 * `libspa-jack` for running pipewire and jack side-by-side
 * `libspa-v4l2` for video camera support
 * `rtkit` for realtime priority acquisition
+
+The system services /etc/sv/pipewire and /etc/sv/pipewire-pulse are
+experimental and only needed in rare cases so using them should be
+avoided in most setups.
diff --git a/srcpkgs/pipewire/files/pipewire-pulse/run b/srcpkgs/pipewire/files/pipewire-pulse/run
new file mode 100644
index 000000000000..f718570498a9
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire-pulse/run
@@ -0,0 +1,7 @@
+#!/bin/sh
+# this service is experimental and most setups should start pipewire as a user,
+# for further information, please refer to the handbook
+! [ -d /run/pulse ] && install -m 755 -g _pipewire -o _pipewire -d /run/pulse
+umask 002
+export PULSE_RUNTIME_PATH=/run
+exec chpst -u _pipewire:_pipewire pipewire-pulse
diff --git a/srcpkgs/pipewire/files/pipewire/run b/srcpkgs/pipewire/files/pipewire/run
new file mode 100644
index 000000000000..359d9871e0d1
--- /dev/null
+++ b/srcpkgs/pipewire/files/pipewire/run
@@ -0,0 +1,8 @@
+#!/bin/sh
+# this service is experimental and most setups should start pipewire as a user,
+# for further information, please refer to the handbook
+! [ -d /run/pipewire ] && install -m 755 -g _pipewire -o _pipewire -d /run/pipewire
+umask 002
+export PIPEWIRE_RUNTIME_DIR=/run/pipewire
+export XDG_CONFIG_HOME=/var/lib
+exec chpst -u _pipewire:_pipewire:audio:video pipewire
diff --git a/srcpkgs/pipewire/patches/6df32666b4.patch b/srcpkgs/pipewire/patches/6df32666b4.patch
deleted file mode 100644
index ea42982b704e..000000000000
--- a/srcpkgs/pipewire/patches/6df32666b4.patch
+++ /dev/null
@@ -1,62 +0,0 @@
-From 6df32666b44b5174aace3dcff39f39a58eba508f Mon Sep 17 00:00:00 2001
-From: Wim Taymans <wtaymans@redhat.com>
-Date: Thu, 20 May 2021 11:22:04 +0200
-Subject: [PATCH] filter-chain: check external ports only once
-
-When we duplicate the pipeline to match the channels, only check
-if a port was used only once for the first instance. Makes
-demonic filter work again.
----
- src/modules/module-filter-chain.c | 18 ++++--------------
- 1 file changed, 4 insertions(+), 14 deletions(-)
-
-diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
-index b1e727069..bb346b6d8 100644
---- a/src/modules/module-filter-chain.c
-+++ b/src/modules/module-filter-chain.c
-@@ -972,16 +972,6 @@ static int parse_link(struct graph *graph, struct spa_json *json)
- 		pw_log_error("unknown input port %s", input);
- 		return -ENOENT;
- 	}
--	if (in_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph input %d, use mixer",
--				input, in_port->external);
--		return -EINVAL;
--	}
--	if (out_port->external != SPA_ID_INVALID) {
--		pw_log_info("%s already used as graph output %d, use copy",
--				output, out_port->external);
--		return -EINVAL;
--	}
- 	if (in_port->n_links > 0) {
- 		pw_log_info("Can't have more than 1 link to %s, use a mixer", input);
- 		return -ENOTSUP;
-@@ -1334,10 +1324,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("input port %s[%d]:%s already used as input %d, use mixer",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_input);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
-@@ -1382,10 +1372,10 @@ static int setup_graph(struct graph *graph, struct spa_json *inputs, struct spa_
- 				} else {
- 					desc = port->node->desc;
- 					d = desc->desc;
--					if (port->external != SPA_ID_INVALID) {
-+					if (i == 0 && port->external != SPA_ID_INVALID) {
- 						pw_log_error("output port %s[%d]:%s already used as output %d, use copy",
- 							port->node->name, i, d->PortNames[port->p],
--							graph->n_output);
-+							port->external);
- 						res = -EBUSY;
- 						goto error;
- 					}
--- 
-GitLab
-
diff --git a/srcpkgs/pipewire/patches/autostart-media-session.patch b/srcpkgs/pipewire/patches/autostart-media-session.patch
index bb107435cdd8..87ab20765488 100644
--- a/srcpkgs/pipewire/patches/autostart-media-session.patch
+++ b/srcpkgs/pipewire/patches/autostart-media-session.patch
@@ -2,14 +2,14 @@ Upstream's config does not autostart pipewire-media-session anymore, which
 is an essential component. It's not easy to start it externally in a script
 since it needs the pipewire socket up, and Void doesn't have a mechanism to
 ensure it (systemd socket activation).
---- a/src/daemon/pipewire.conf.in	2021-03-18 17:45:02.025992827 +0100
-+++ b/src/daemon/pipewire.conf.in	2021-03-18 17:47:17.606999440 +0100
-@@ -204,7 +204,7 @@
+--- a/src/daemon/pipewire.conf.in
++++ b/src/daemon/pipewire.conf.in
+@@ -234,7 +234,7 @@
      # but it is better to start it as a systemd service.
      # Run the session manager with -h for options.
      #
--    @comment@{ path = "@media_session_path@"  args = "" }
-+    { path = "@media_session_path@"  args = "" }
+-    @comment@{ path = "@session_manager_path@"  args = "@session_manager_args@" }
++    { path = "@session_manager_path@"  args = "@session_manager_args@" }
      #
      # You can optionally start the pulseaudio-server here as well
      # but it is better to start it as a systemd service.
diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 43e3c1cfc9b4..6bf7f6f0a914 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,24 +1,26 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.28
+version=0.3.31
 revision=1
 build_style=meson
 configure_args="-Dman=enabled -Dgstreamer=enabled -Ddocs=enabled -Dsystemd=disabled
  -Dbluez5=enabled -Dffmpeg=enabled -Dpipewire-alsa=enabled -Dpipewire-jack=enabled
- -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d"
+ -Dvulkan=enabled -Dudevrulesdir=/usr/lib/udev/rules.d -Db_ndebug=false"
 hostmakedepends="doxygen graphviz pkg-config xmltoman gettext"
 makedepends="ffmpeg-devel gst-plugins-base1-devel jack-devel sbc-devel v4l-utils-devel
- libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel fdk-aac-devel
+ libva-devel libbluetooth-devel ncurses-devel libopenaptx-devel libusb-devel fdk-aac-devel
  libsndfile-devel Vulkan-Headers vulkan-loader $(vopt_if sdl2 SDL2-devel)"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}"
 short_desc="Server and user space API to deal with multimedia pipelines"
-maintainer="Kridsada Thanabulpong <sirn@ogsite.net>"
+maintainer="Stefano Ragni <stefano.ragni@outlook.com>"
 license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=1d9271e121a5049aef379e9bb7c50524faa6f971e668806637d7b9df1b7cab88
+checksum=2fec0eb47dbfcad51fb8bb3d59c26fe57e09204d63c9d2776070dbdc08aaaaae
+make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
+system_accounts="_pipewire"
 
 build_options="sdl2"
 
@@ -36,6 +38,8 @@ fi
 post_install() {
 	vlicense LICENSE
 	vdoc "${FILESDIR}/README.voidlinux"
+	vsv pipewire
+	vsv pipewire-pulse
 }
 
 libpipewire_package() {
@@ -150,6 +154,7 @@ libjack-pipewire_package() {
 	pkg_install() {
 		vmove usr/lib/pipewire-0.3/jack
 		vmove usr/bin/pw-jack
+		vmove usr/share/man/man1/pw-jack.1
 	}
 }
 

Re: [PR REVIEW] pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#discussion_r668998419

Comment:
sorry, fixed

Re: pipewire: update to 0.3.31.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-879295147

Comment:
> For completeness, the commit message could mention that libusb was added to improve bluetooth device detection; and I think since the package already has a `README.voidlinux` file, we could document the service as "experimental", so making breaking changes in a new release is possible.

I also mentioned that most users want to start pipewire{,-pulse} as a user, because I think there will be a lot of people trying to use the service without reading the handbook. I also mentioned it inside the service scripts.

Re: [PR PATCH] [Merged]: pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

There's a merged pull request on the void-packages repository

pipewire: update to 0.3.31.
https://github.com/void-linux/void-packages/pull/31549

Description:
#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

0.3.29 introduces `module-rt` which is supposed to replace rtkit on systems without it. I was able to make this work on my glibc system (replacing module-rtkit with module-rt in the configs and setting CAP_SYS_NICE on the binaries), but not on musl.

ping @ericonr, @st3r4g 

Re: pipewire: update to 0.3.31.

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-881926877

Comment:
With the update from 28->31, pipewire does not show up in alsamixer anymore, it says `This sound device does not have any controls.`, while before it was possible to raise volume/mute/etc using amixer commands.
Is this intentional or a bug?

Re: pipewire: update to 0.3.31.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-881954299

Comment:
There were some ALSA changes, I could see a bug slipping in. The changelog doesn't make it seem intentional.

Re: pipewire: update to 0.3.31.

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-882028660

Comment:
@dkwo looks like https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1384
should be fixed in next release

Re: pipewire: update to 0.3.31.

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/31549#issuecomment-882034410

Comment:
Great, thanks for pointing out.
So I'll just wait :)