From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] zathura: add make-deps and enable Dtests
Date: Fri, 02 Jul 2021 22:14:18 +0200 [thread overview]
Message-ID: <20210702201418.z_JbSkX5F9cG1BDMGIFOe-c9YPHtRfXf80hxmV84PuU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31724@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31724#discussion_r663228487
Comment:
No, `checkdepends` will be installed equivalently to how `makedepends` is, for the cases where we run tests.
```diff
diff --git a/srcpkgs/zathura/template b/srcpkgs/zathura/template
index 3a6afd35e5..31b514eb4a 100644
--- a/srcpkgs/zathura/template
+++ b/srcpkgs/zathura/template
@@ -7,8 +7,8 @@ configure_args="-Dsynctex=enabled"
hostmakedepends="pkg-config intltool python3-Sphinx desktop-file-utils
appstream-glib glib-devel librsvg-utils"
makedepends="girara-devel sqlite-devel file-devel zlib-devel libseccomp-devel
- libglib-devel texlive-devel gettext-devel"
-checkdepends="check-devel"
+ libglib-devel texlive-devel"
+checkdepends="check-devel gettext-devel"
short_desc="Highly customizable and functional document viewer"
maintainer="lemmi <lemmi@nerd2nerd.org>"
license="Zlib"
@@ -16,9 +16,10 @@ homepage="https://pwmt.org/projects/zathura"
distfiles="${homepage}/download/zathura-${version}.tar.xz"
checksum=e012dbfe2b981b826553a9af8420d42a9c5d3387fbe14a5399ce94a2d374a1e7
-if [ "$XBPS_CHECK_PKGS" = full ]; then
+if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=enabled"
- makedepends+=" check-devel"
+else
+ configure_args+=" -Dtests=disabled"
fi
post_install() {
```
next prev parent reply other threads:[~2021-07-02 20:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 13:25 [PR PATCH] " dkwo
2021-06-30 14:15 ` [PR REVIEW] " ericonr
2021-06-30 15:12 ` dkwo
2021-06-30 15:31 ` dkwo
2021-06-30 15:31 ` [PR PATCH] [Updated] " dkwo
2021-06-30 15:31 ` dkwo
2021-06-30 15:32 ` dkwo
2021-06-30 19:41 ` [PR REVIEW] " ericonr
2021-07-01 7:31 ` dkwo
2021-07-01 13:45 ` ericonr
2021-07-01 14:11 ` dkwo
2021-07-01 14:12 ` dkwo
2021-07-01 14:13 ` dkwo
2021-07-01 14:59 ` ericonr
2021-07-02 9:40 ` dkwo
2021-07-02 9:42 ` dkwo
2021-07-02 9:45 ` dkwo
2021-07-02 11:34 ` [PR PATCH] [Updated] " dkwo
2021-07-02 14:21 ` [PR REVIEW] " ericonr
2021-07-02 19:05 ` dkwo
2021-07-02 20:14 ` ericonr [this message]
2021-07-02 20:21 ` ericonr
2021-07-03 10:10 ` [PR PATCH] [Updated] " dkwo
2021-07-03 11:30 ` [PR REVIEW] " dkwo
2021-07-04 19:40 ` [PR PATCH] [Merged]: zathura: various fixes ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702201418.z_JbSkX5F9cG1BDMGIFOe-c9YPHtRfXf80hxmV84PuU@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).