Github messages for voidlinux
 help / color / mirror / Atom feed
From: FollieHiyuki <FollieHiyuki@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: libcaca: enable imlib2 support by default + add opengl build option
Date: Sat, 03 Jul 2021 05:57:09 +0200	[thread overview]
Message-ID: <20210703035709.bqjYuDtW6OMR-g8gz0JxniuTwErxO5nVunJo9nooeYo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31717@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by FollieHiyuki on void-packages repository

https://github.com/void-linux/void-packages/pull/31717#issuecomment-873339948

Comment:
@ericonr yes for example `cacaview` will open in an X11 window if built with x11 support, while with only imlib2 support it will open inside the terminal (which looks much nicer since it honor the terminal colors).

I think you can just revert back to my commit. I already tested it locally.

      parent reply	other threads:[~2021-07-03  3:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 22:51 [PR PATCH] " FollieHiyuki
2021-07-01 19:44 ` [PR PATCH] [Updated] " FollieHiyuki
2021-07-01 19:45 ` [PR REVIEW] " FollieHiyuki
2021-07-01 19:47 ` [PR PATCH] [Updated] " FollieHiyuki
2021-07-03  1:55 ` [PR PATCH] [Closed]: " ericonr
2021-07-03  3:17 ` FollieHiyuki
2021-07-03  3:26 ` ericonr
2021-07-03  3:57 ` FollieHiyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210703035709.bqjYuDtW6OMR-g8gz0JxniuTwErxO5nVunJo9nooeYo@z \
    --to=folliehiyuki@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).