From: heliocat <heliocat@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Omnibus lint pass for SPDX warnings - packages starting with Z
Date: Sat, 03 Jul 2021 08:16:49 +0200 [thread overview]
Message-ID: <20210703061649.OLFUwwFBJVrF6uLym9DSvcAeCnyzTgI5gQB7_CJGy0Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31733@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
New review comment by heliocat on void-packages repository
https://github.com/void-linux/void-packages/pull/31733#discussion_r663324660
Comment:
The only template that has a mis-located lib32mode is zsnes. Of the other six templates containing a lib32mode= line (doom3, mesa, pcsx2, qt5, swars, and wine), only doom3, qt5, and swars have lint errors and none of them complain about location.
Or are you saying to consolidate the lines of the zsnes template across the board? Entirely doable but I'd like to know that's the ask before redoing it.
next prev parent reply other threads:[~2021-07-03 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 7:19 [PR PATCH] " heliocat
2021-07-03 2:21 ` [PR REVIEW] " ericonr
2021-07-03 6:16 ` heliocat [this message]
2021-07-04 19:31 ` ericonr
2021-07-04 20:01 ` [PR PATCH] [Updated] " heliocat
2021-07-04 20:01 ` [PR REVIEW] " heliocat
2021-07-04 20:52 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210703061649.OLFUwwFBJVrF6uLym9DSvcAeCnyzTgI5gQB7_CJGy0Y@z \
--to=heliocat@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).